mirror of
https://github.com/git/git
synced 2024-08-28 20:20:07 +00:00
![Ævar Arnfjörð Bjarmason](/assets/img/avatar_default.png)
Fix a memory leak in "test-tool urlmatch-normalization", as a result we can mark the corresponding test as passing with SANITIZE=leak using "TEST_PASSES_SANITIZE_LEAK=true". Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
57 lines
1.3 KiB
C
57 lines
1.3 KiB
C
#include "test-tool.h"
|
|
#include "git-compat-util.h"
|
|
#include "urlmatch.h"
|
|
|
|
int cmd__urlmatch_normalization(int argc, const char **argv)
|
|
{
|
|
const char usage[] = "test-tool urlmatch-normalization [-p | -l] <url1> | <url1> <url2>";
|
|
char *url1 = NULL, *url2 = NULL;
|
|
int opt_p = 0, opt_l = 0;
|
|
int ret = 0;
|
|
|
|
/*
|
|
* For one url, succeed if url_normalize succeeds on it, fail otherwise.
|
|
* For two urls, succeed only if url_normalize succeeds on both and
|
|
* the results compare equal with strcmp. If -p is given (one url only)
|
|
* and url_normalize succeeds, print the result followed by "\n". If
|
|
* -l is given (one url only) and url_normalize succeeds, print the
|
|
* returned length in decimal followed by "\n".
|
|
*/
|
|
|
|
if (argc > 1 && !strcmp(argv[1], "-p")) {
|
|
opt_p = 1;
|
|
argc--;
|
|
argv++;
|
|
} else if (argc > 1 && !strcmp(argv[1], "-l")) {
|
|
opt_l = 1;
|
|
argc--;
|
|
argv++;
|
|
}
|
|
|
|
if (argc < 2 || argc > 3)
|
|
die("%s", usage);
|
|
|
|
if (argc == 2) {
|
|
struct url_info info;
|
|
url1 = url_normalize(argv[1], &info);
|
|
if (!url1)
|
|
return 1;
|
|
if (opt_p)
|
|
printf("%s\n", url1);
|
|
if (opt_l)
|
|
printf("%u\n", (unsigned)info.url_len);
|
|
goto cleanup;
|
|
}
|
|
|
|
if (opt_p || opt_l)
|
|
die("%s", usage);
|
|
|
|
url1 = url_normalize(argv[1], NULL);
|
|
url2 = url_normalize(argv[2], NULL);
|
|
ret = (url1 && url2 && !strcmp(url1, url2)) ? 0 : 1;
|
|
cleanup:
|
|
free(url1);
|
|
free(url2);
|
|
return ret;
|
|
}
|