mirror of
https://github.com/git/git
synced 2024-10-30 04:01:21 +00:00
3e3b9321ca
Mark those remaining tests that pass when run under SANITIZE=leak with TEST_PASSES_SANITIZE_LEAK=true, these were either omitted inf346fcb62a(Merge branch 'ab/mark-leak-free-tests-even-more', 2021-12-15) and5a4f8381b6(Merge branch 'ab/mark-leak-free-tests', 2021-10-25), or have had their memory leaks fixed since then. With this change there's now a a one-to-one mapping between those tests that we have opted-in via "TEST_PASSES_SANITIZE_LEAK=true", and those that pass with the new "check" mode: GIT_TEST_PASSING_SANITIZE_LEAK=check \ GIT_TEST_SANITIZE_LEAK_LOG=true \ make test SANITIZE=leak Note that the "GIT_TEST_SANITIZE_LEAK_LOG=true" is needed due to the edge cases noted in a preceding commit, i.e. in some cases we'd pass the test itself, but still have outstanding leaks due to ignored exit codes. The "GIT_TEST_SANITIZE_LEAK_LOG=true" corrects for that, we're only marking those tests as passing that really don't have any leaks, whether that was reflected in their exit code or not. Note that the change here to "t9100-git-svn-basic.sh" is marking that test as passing under SANITIZE=leak, we're removing a "TEST_FAILS_SANITIZE_LEAK=true" line, not "TEST_PASSES_SANITIZE_LEAK=true". See7a98d9ab00(revisions API: have release_revisions() release "cmdline", 2022-04-13) for the introduction of that t/lib-git-svn.sh-specific variable. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
104 lines
3 KiB
Bash
Executable file
104 lines
3 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='basic checkout-index tests
|
|
'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'checkout-index --gobbledegook' '
|
|
test_expect_code 129 git checkout-index --gobbledegook 2>err &&
|
|
test_i18ngrep "[Uu]sage" err
|
|
'
|
|
|
|
test_expect_success 'checkout-index -h in broken repository' '
|
|
mkdir broken &&
|
|
(
|
|
cd broken &&
|
|
git init &&
|
|
>.git/index &&
|
|
test_expect_code 129 git checkout-index -h >usage 2>&1
|
|
) &&
|
|
test_i18ngrep "[Uu]sage" broken/usage
|
|
'
|
|
|
|
test_expect_success 'checkout-index reports errors (cmdline)' '
|
|
test_must_fail git checkout-index -- does-not-exist 2>stderr &&
|
|
test_i18ngrep not.in.the.cache stderr
|
|
'
|
|
|
|
test_expect_success 'checkout-index reports errors (stdin)' '
|
|
echo does-not-exist |
|
|
test_must_fail git checkout-index --stdin 2>stderr &&
|
|
test_i18ngrep not.in.the.cache stderr
|
|
'
|
|
for mode in 'case' 'utf-8'
|
|
do
|
|
case "$mode" in
|
|
case) dir='A' symlink='a' mode_prereq='CASE_INSENSITIVE_FS' ;;
|
|
utf-8)
|
|
dir=$(printf "\141\314\210") symlink=$(printf "\303\244")
|
|
mode_prereq='UTF8_NFD_TO_NFC' ;;
|
|
esac
|
|
|
|
test_expect_success SYMLINKS,$mode_prereq \
|
|
"checkout-index with $mode-collision don't write to the wrong place" '
|
|
git init $mode-collision &&
|
|
(
|
|
cd $mode-collision &&
|
|
mkdir target-dir &&
|
|
|
|
empty_obj_hex=$(git hash-object -w --stdin </dev/null) &&
|
|
symlink_hex=$(printf "%s" "$PWD/target-dir" | git hash-object -w --stdin) &&
|
|
|
|
cat >objs <<-EOF &&
|
|
100644 blob ${empty_obj_hex} ${dir}/x
|
|
100644 blob ${empty_obj_hex} ${dir}/y
|
|
100644 blob ${empty_obj_hex} ${dir}/z
|
|
120000 blob ${symlink_hex} ${symlink}
|
|
EOF
|
|
|
|
git update-index --index-info <objs &&
|
|
|
|
# Note: the order is important here to exercise the
|
|
# case where the file at ${dir} has its type changed by
|
|
# the time Git tries to check out ${dir}/z.
|
|
#
|
|
# Also, we use core.precomposeUnicode=false because we
|
|
# want Git to treat the UTF-8 paths transparently on
|
|
# Mac OS, matching what is in the index.
|
|
#
|
|
git -c core.precomposeUnicode=false checkout-index -f \
|
|
${dir}/x ${dir}/y ${symlink} ${dir}/z &&
|
|
|
|
# Should not create ${dir}/z at ${symlink}/z
|
|
test_path_is_missing target-dir/z
|
|
|
|
)
|
|
'
|
|
done
|
|
|
|
test_expect_success 'checkout-index --temp correctly reports error on missing blobs' '
|
|
test_when_finished git reset --hard &&
|
|
missing_blob=$(echo "no such blob here" | git hash-object --stdin) &&
|
|
cat >objs <<-EOF &&
|
|
100644 $missing_blob file
|
|
120000 $missing_blob symlink
|
|
EOF
|
|
git update-index --index-info <objs &&
|
|
|
|
test_must_fail git checkout-index --temp symlink file 2>stderr &&
|
|
test_i18ngrep "unable to read sha1 file of file ($missing_blob)" stderr &&
|
|
test_i18ngrep "unable to read sha1 file of symlink ($missing_blob)" stderr
|
|
'
|
|
|
|
test_expect_success 'checkout-index --temp correctly reports error for submodules' '
|
|
git init sub &&
|
|
test_commit -C sub file &&
|
|
git submodule add ./sub &&
|
|
git commit -m sub &&
|
|
test_must_fail git checkout-index --temp sub 2>stderr &&
|
|
test_i18ngrep "cannot create temporary submodule sub" stderr
|
|
'
|
|
|
|
test_done
|