mirror of
https://github.com/git/git
synced 2024-09-12 21:04:12 +00:00
d55a30bb1d
The general strategy of "git prune" is to do a full reachability walk, then for each loose object see if we found it in our walk. But if we don't have any loose objects, we don't need to do the expensive walk in the first place. This patch postpones that walk until the first time we need to see its results. Note that this is really a specific case of a more general optimization, which is that we could traverse only far enough to find the object under consideration (i.e., stop the traversal when we find it, then pick up again when asked about the next object, etc). That could save us in some instances from having to do a full walk. But it's actually a bit tricky to do with our traversal code, and you'd need to do a full walk anyway if you have even a single unreachable object (which you generally do, if any objects are actually left after running git-repack). So in practice this lazy-load of the full walk catches one easy but common case (i.e., you've just repacked via git-gc, and there's nothing unreachable). The perf script is fairly contrived, but it does show off the improvement: Test HEAD^ HEAD ------------------------------------------------------------------------- 5304.4: prune with no objects 3.66(3.60+0.05) 0.00(0.00+0.00) -100.0% and would let us know if we accidentally regress this optimization. Note also that we need to take special care with prune_shallow(), which relies on us having performed the traversal. So this optimization can only kick in for a non-shallow repository. Since this is easy to get wrong and is not covered by existing tests, let's add an extra test to t5304 that covers this case explicitly. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
345 lines
8.9 KiB
Bash
Executable file
345 lines
8.9 KiB
Bash
Executable file
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2008 Johannes E. Schindelin
|
|
#
|
|
|
|
test_description='prune'
|
|
. ./test-lib.sh
|
|
|
|
day=$((60*60*24))
|
|
week=$(($day*7))
|
|
|
|
add_blob() {
|
|
before=$(git count-objects | sed "s/ .*//") &&
|
|
BLOB=$(echo aleph_0 | git hash-object -w --stdin) &&
|
|
BLOB_FILE=.git/objects/$(echo $BLOB | sed "s/^../&\//") &&
|
|
verbose test $((1 + $before)) = $(git count-objects | sed "s/ .*//") &&
|
|
test_path_is_file $BLOB_FILE &&
|
|
test-tool chmtime =+0 $BLOB_FILE
|
|
}
|
|
|
|
test_expect_success setup '
|
|
|
|
: > file &&
|
|
git add file &&
|
|
test_tick &&
|
|
git commit -m initial &&
|
|
git gc
|
|
|
|
'
|
|
|
|
test_expect_success 'prune stale packs' '
|
|
|
|
orig_pack=$(echo .git/objects/pack/*.pack) &&
|
|
: > .git/objects/tmp_1.pack &&
|
|
: > .git/objects/tmp_2.pack &&
|
|
test-tool chmtime =-86501 .git/objects/tmp_1.pack &&
|
|
git prune --expire 1.day &&
|
|
test_path_is_file $orig_pack &&
|
|
test_path_is_file .git/objects/tmp_2.pack &&
|
|
test_path_is_missing .git/objects/tmp_1.pack
|
|
|
|
'
|
|
|
|
test_expect_success 'prune --expire' '
|
|
|
|
add_blob &&
|
|
git prune --expire=1.hour.ago &&
|
|
verbose test $((1 + $before)) = $(git count-objects | sed "s/ .*//") &&
|
|
test_path_is_file $BLOB_FILE &&
|
|
test-tool chmtime =-86500 $BLOB_FILE &&
|
|
git prune --expire 1.day &&
|
|
verbose test $before = $(git count-objects | sed "s/ .*//") &&
|
|
test_path_is_missing $BLOB_FILE
|
|
|
|
'
|
|
|
|
test_expect_success 'gc: implicit prune --expire' '
|
|
|
|
add_blob &&
|
|
test-tool chmtime =-$((2*$week-30)) $BLOB_FILE &&
|
|
git gc &&
|
|
verbose test $((1 + $before)) = $(git count-objects | sed "s/ .*//") &&
|
|
test_path_is_file $BLOB_FILE &&
|
|
test-tool chmtime =-$((2*$week+1)) $BLOB_FILE &&
|
|
git gc &&
|
|
verbose test $before = $(git count-objects | sed "s/ .*//") &&
|
|
test_path_is_missing $BLOB_FILE
|
|
|
|
'
|
|
|
|
test_expect_success 'gc: refuse to start with invalid gc.pruneExpire' '
|
|
|
|
git config gc.pruneExpire invalid &&
|
|
test_must_fail git gc
|
|
|
|
'
|
|
|
|
test_expect_success 'gc: start with ok gc.pruneExpire' '
|
|
|
|
git config gc.pruneExpire 2.days.ago &&
|
|
git gc
|
|
|
|
'
|
|
|
|
test_expect_success 'prune: prune nonsense parameters' '
|
|
|
|
test_must_fail git prune garbage &&
|
|
test_must_fail git prune --- &&
|
|
test_must_fail git prune --no-such-option
|
|
|
|
'
|
|
|
|
test_expect_success 'prune: prune unreachable heads' '
|
|
|
|
git config core.logAllRefUpdates false &&
|
|
mv .git/logs .git/logs.old &&
|
|
: > file2 &&
|
|
git add file2 &&
|
|
git commit -m temporary &&
|
|
tmp_head=$(git rev-list -1 HEAD) &&
|
|
git reset HEAD^ &&
|
|
git prune &&
|
|
test_must_fail git reset $tmp_head --
|
|
|
|
'
|
|
|
|
test_expect_success 'prune: do not prune detached HEAD with no reflog' '
|
|
|
|
git checkout --detach --quiet &&
|
|
git commit --allow-empty -m "detached commit" &&
|
|
# verify that there is no reflogs
|
|
# (should be removed and disabled by previous test)
|
|
test_path_is_missing .git/logs &&
|
|
git prune -n >prune_actual &&
|
|
test_must_be_empty prune_actual
|
|
|
|
'
|
|
|
|
test_expect_success 'prune: prune former HEAD after checking out branch' '
|
|
|
|
head_sha1=$(git rev-parse HEAD) &&
|
|
git checkout --quiet master &&
|
|
git prune -v >prune_actual &&
|
|
grep "$head_sha1" prune_actual
|
|
|
|
'
|
|
|
|
test_expect_success 'prune: do not prune heads listed as an argument' '
|
|
|
|
: > file2 &&
|
|
git add file2 &&
|
|
git commit -m temporary &&
|
|
tmp_head=$(git rev-list -1 HEAD) &&
|
|
git reset HEAD^ &&
|
|
git prune -- $tmp_head &&
|
|
git reset $tmp_head --
|
|
|
|
'
|
|
|
|
test_expect_success 'gc --no-prune' '
|
|
|
|
add_blob &&
|
|
test-tool chmtime =-$((5001*$day)) $BLOB_FILE &&
|
|
git config gc.pruneExpire 2.days.ago &&
|
|
git gc --no-prune &&
|
|
verbose test 1 = $(git count-objects | sed "s/ .*//") &&
|
|
test_path_is_file $BLOB_FILE
|
|
|
|
'
|
|
|
|
test_expect_success 'gc respects gc.pruneExpire' '
|
|
|
|
git config gc.pruneExpire 5002.days.ago &&
|
|
git gc &&
|
|
test_path_is_file $BLOB_FILE &&
|
|
git config gc.pruneExpire 5000.days.ago &&
|
|
git gc &&
|
|
test_path_is_missing $BLOB_FILE
|
|
|
|
'
|
|
|
|
test_expect_success 'gc --prune=<date>' '
|
|
|
|
add_blob &&
|
|
test-tool chmtime =-$((5001*$day)) $BLOB_FILE &&
|
|
git gc --prune=5002.days.ago &&
|
|
test_path_is_file $BLOB_FILE &&
|
|
git gc --prune=5000.days.ago &&
|
|
test_path_is_missing $BLOB_FILE
|
|
|
|
'
|
|
|
|
test_expect_success 'gc --prune=never' '
|
|
|
|
add_blob &&
|
|
git gc --prune=never &&
|
|
test_path_is_file $BLOB_FILE &&
|
|
git gc --prune=now &&
|
|
test_path_is_missing $BLOB_FILE
|
|
|
|
'
|
|
|
|
test_expect_success 'gc respects gc.pruneExpire=never' '
|
|
|
|
git config gc.pruneExpire never &&
|
|
add_blob &&
|
|
git gc &&
|
|
test_path_is_file $BLOB_FILE &&
|
|
git config gc.pruneExpire now &&
|
|
git gc &&
|
|
test_path_is_missing $BLOB_FILE
|
|
|
|
'
|
|
|
|
test_expect_success 'prune --expire=never' '
|
|
|
|
add_blob &&
|
|
git prune --expire=never &&
|
|
test_path_is_file $BLOB_FILE &&
|
|
git prune &&
|
|
test_path_is_missing $BLOB_FILE
|
|
|
|
'
|
|
|
|
test_expect_success 'gc: prune old objects after local clone' '
|
|
add_blob &&
|
|
test-tool chmtime =-$((2*$week+1)) $BLOB_FILE &&
|
|
git clone --no-hardlinks . aclone &&
|
|
(
|
|
cd aclone &&
|
|
verbose test 1 = $(git count-objects | sed "s/ .*//") &&
|
|
test_path_is_file $BLOB_FILE &&
|
|
git gc --prune &&
|
|
verbose test 0 = $(git count-objects | sed "s/ .*//") &&
|
|
test_path_is_missing $BLOB_FILE
|
|
)
|
|
'
|
|
|
|
test_expect_success 'garbage report in count-objects -v' '
|
|
test_when_finished "rm -f .git/objects/pack/fake*" &&
|
|
test_when_finished "rm -f .git/objects/pack/foo*" &&
|
|
: >.git/objects/pack/foo &&
|
|
: >.git/objects/pack/foo.bar &&
|
|
: >.git/objects/pack/foo.keep &&
|
|
: >.git/objects/pack/foo.pack &&
|
|
: >.git/objects/pack/fake.bar &&
|
|
: >.git/objects/pack/fake.keep &&
|
|
: >.git/objects/pack/fake.pack &&
|
|
: >.git/objects/pack/fake.idx &&
|
|
: >.git/objects/pack/fake2.keep &&
|
|
: >.git/objects/pack/fake3.idx &&
|
|
git count-objects -v 2>stderr &&
|
|
grep "index file .git/objects/pack/fake.idx is too small" stderr &&
|
|
grep "^warning:" stderr | sort >actual &&
|
|
cat >expected <<\EOF &&
|
|
warning: garbage found: .git/objects/pack/fake.bar
|
|
warning: garbage found: .git/objects/pack/foo
|
|
warning: garbage found: .git/objects/pack/foo.bar
|
|
warning: no corresponding .idx or .pack: .git/objects/pack/fake2.keep
|
|
warning: no corresponding .idx: .git/objects/pack/foo.keep
|
|
warning: no corresponding .idx: .git/objects/pack/foo.pack
|
|
warning: no corresponding .pack: .git/objects/pack/fake3.idx
|
|
EOF
|
|
test_cmp expected actual
|
|
'
|
|
|
|
test_expect_success 'clean pack garbage with gc' '
|
|
test_when_finished "rm -f .git/objects/pack/fake*" &&
|
|
test_when_finished "rm -f .git/objects/pack/foo*" &&
|
|
: >.git/objects/pack/foo.keep &&
|
|
: >.git/objects/pack/foo.pack &&
|
|
: >.git/objects/pack/fake.idx &&
|
|
: >.git/objects/pack/fake2.keep &&
|
|
: >.git/objects/pack/fake2.idx &&
|
|
: >.git/objects/pack/fake3.keep &&
|
|
git gc &&
|
|
git count-objects -v 2>stderr &&
|
|
grep "^warning:" stderr | sort >actual &&
|
|
cat >expected <<\EOF &&
|
|
warning: no corresponding .idx or .pack: .git/objects/pack/fake3.keep
|
|
warning: no corresponding .idx: .git/objects/pack/foo.keep
|
|
warning: no corresponding .idx: .git/objects/pack/foo.pack
|
|
EOF
|
|
test_cmp expected actual
|
|
'
|
|
|
|
test_expect_success 'prune .git/shallow' '
|
|
SHA1=$(echo hi|git commit-tree HEAD^{tree}) &&
|
|
echo $SHA1 >.git/shallow &&
|
|
git prune --dry-run >out &&
|
|
grep $SHA1 .git/shallow &&
|
|
grep $SHA1 out &&
|
|
git prune &&
|
|
test_path_is_missing .git/shallow
|
|
'
|
|
|
|
test_expect_success 'prune .git/shallow when there are no loose objects' '
|
|
SHA1=$(echo hi|git commit-tree HEAD^{tree}) &&
|
|
echo $SHA1 >.git/shallow &&
|
|
git update-ref refs/heads/shallow-tip $SHA1 &&
|
|
git repack -ad &&
|
|
# verify assumption that all loose objects are gone
|
|
git count-objects | grep ^0 &&
|
|
git prune &&
|
|
echo $SHA1 >expect &&
|
|
test_cmp expect .git/shallow
|
|
'
|
|
|
|
test_expect_success 'prune: handle alternate object database' '
|
|
test_create_repo A &&
|
|
git -C A commit --allow-empty -m "initial commit" &&
|
|
git clone --shared A B &&
|
|
git -C B commit --allow-empty -m "next commit" &&
|
|
git -C B prune
|
|
'
|
|
|
|
test_expect_success 'prune: handle index in multiple worktrees' '
|
|
git worktree add second-worktree &&
|
|
echo "new blob for second-worktree" >second-worktree/blob &&
|
|
git -C second-worktree add blob &&
|
|
git prune --expire=now &&
|
|
git -C second-worktree show :blob >actual &&
|
|
test_cmp second-worktree/blob actual
|
|
'
|
|
|
|
test_expect_success 'prune: handle HEAD in multiple worktrees' '
|
|
git worktree add --detach third-worktree &&
|
|
echo "new blob for third-worktree" >third-worktree/blob &&
|
|
git -C third-worktree add blob &&
|
|
git -C third-worktree commit -m "third" &&
|
|
rm .git/worktrees/third-worktree/index &&
|
|
test_must_fail git -C third-worktree show :blob &&
|
|
git prune --expire=now &&
|
|
git -C third-worktree show HEAD:blob >actual &&
|
|
test_cmp third-worktree/blob actual
|
|
'
|
|
|
|
test_expect_success 'prune: handle HEAD reflog in multiple worktrees' '
|
|
git config core.logAllRefUpdates true &&
|
|
echo "lost blob for third-worktree" >expected &&
|
|
(
|
|
cd third-worktree &&
|
|
cat ../expected >blob &&
|
|
git add blob &&
|
|
git commit -m "second commit in third" &&
|
|
git reset --hard HEAD^
|
|
) &&
|
|
git prune --expire=now &&
|
|
SHA1=`git hash-object expected` &&
|
|
git -C third-worktree show "$SHA1" >actual &&
|
|
test_cmp expected actual
|
|
'
|
|
|
|
test_expect_success 'prune: handle expire option correctly' '
|
|
test_must_fail git prune --expire 2>error &&
|
|
test_i18ngrep "requires a value" error &&
|
|
|
|
test_must_fail git prune --expire=nyah 2>error &&
|
|
test_i18ngrep "malformed expiration" error &&
|
|
|
|
git prune --no-expire
|
|
'
|
|
|
|
test_done
|