Find a file
Jeff King d391c0ff94 diff: don't use pathname-based diff drivers for symlinks
When we're diffing symlinks, we consider the contents to be
the pathname that the symlink points to. When a user sets up
a userdiff driver like "*.pdf diff=pdf", their "diff.pdf.*"
config generally tells us what to do with the content of
pdf files.

With the current code, we will actually process a symlink
like "link.pdf" using a configured pdf driver, meaning we
are using contents which consist of a pathname with
configuration that is expecting contents that consist of an
actual pdf file.

The most noticeable example of this would have been
textconv; however, it was already protected in its own
textconv-specific code path. We can still see the breakage
with something like "diff.*.binary", though. You could
also see it with diff.*.funcname, though it is a bit harder
to trigger accidentally there.

This patch adds a check for S_ISREG lower in the callstack
than the textconv-specific check, which should block use of
any userdiff config for non-regular files. We can drop the
check in the textconv code, which is now redundant.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2010-09-23 18:32:32 -07:00
block-sha1
builtin revert: Fix trivial comment style issue 2010-09-06 17:33:59 -07:00
compat Merge branch 'sg/rerere-gc-old-still-used' into maint 2010-09-01 13:57:23 -07:00
contrib Typos in code comments, an error message, documentation 2010-08-22 13:25:08 -07:00
Documentation config.txt: fix placement of diff.noprefix 2010-09-10 09:31:13 -07:00
git-gui Merge git://repo.or.cz/git-gui into pt/git-gui 2010-08-02 09:28:30 -07:00
git_remote_helpers
gitk-git
gitweb Typos in code comments, an error message, documentation 2010-08-22 13:25:08 -07:00
perl
ppc
t diff: don't use pathname-based diff drivers for symlinks 2010-09-23 18:32:32 -07:00
templates
xdiff xdiff: optimise for no whitespace difference when ignoring whitespace. 2010-07-05 23:27:41 -07:00
.gitattributes
.gitignore Tell ignore file about generate files in /gitweb/static 2010-08-21 22:09:13 -07:00
.mailmap
abspath.c
aclocal.m4
advice.c
advice.h
alias.c
alloc.c
archive-tar.c
archive-zip.c
archive.c archive: abbreviate substituted commit ids again 2010-07-27 13:28:54 -07:00
archive.h
attr.c
attr.h
base85.c Standardize do { ... } while (0) style 2010-08-12 15:44:51 -07:00
bisect.c
bisect.h
blob.c
blob.h
branch.c
branch.h
builtin.h
bundle.c
bundle.h
cache-tree.c cache_tree_free: Fix small memory leak 2010-09-06 17:32:28 -07:00
cache-tree.h
cache.h Standardize do { ... } while (0) style 2010-08-12 15:44:51 -07:00
check-builtins.sh
check-racy.c
check_bindir
color.c
color.h
combine-diff.c
command-list.txt
commit.c
commit.h Merge branch 'ar/decorate-color' 2010-06-30 11:55:40 -07:00
config.c
config.mak.in
configure.ac
connect.c
convert.c
copy.c
COPYING
csum-file.c
csum-file.h
ctype.c
daemon.c
date.c parse_date: fix signedness in timezone calculation 2010-07-05 11:57:07 -07:00
decorate.c
decorate.h
delta.h
diff-delta.c fix >4GiB source delta assertion failure 2010-08-21 23:53:26 -07:00
diff-lib.c
diff-no-index.c
diff.c diff: don't use pathname-based diff drivers for symlinks 2010-09-23 18:32:32 -07:00
diff.h diff --follow: do call diffcore_std() as necessary 2010-08-13 12:17:45 -07:00
diffcore-break.c
diffcore-delta.c
diffcore-order.c
diffcore-pickaxe.c
diffcore-rename.c
diffcore.h diff --follow: do call diffcore_std() as necessary 2010-08-13 12:17:45 -07:00
dir.c git add: Add the "--ignore-missing" option for the dry run 2010-07-12 15:13:54 -07:00
dir.h git add: Add the "--ignore-missing" option for the dry run 2010-07-12 15:13:54 -07:00
editor.c
entry.c
environment.c
exec_cmd.c
exec_cmd.h
fast-import.c fast-import: export correctly marks larger than 2^20-1 2010-08-11 10:45:15 -07:00
fetch-pack.h
fixup-builtins
fsck.c
fsck.h
generate-cmdlist.sh
git-add--interactive.perl
git-am.sh
git-archimport.perl
git-bisect.sh
git-compat-util.h Merge branch 'tr/xsize-bits' into maint 2010-08-19 15:49:54 -07:00
git-cvsexportcommit.perl
git-cvsimport.perl
git-cvsserver.perl
git-difftool--helper.sh
git-difftool.perl
git-filter-branch.sh
git-instaweb.sh git-instaweb: Don't assume Apache executable is named apache2 2010-07-23 11:16:05 -07:00
git-lost-found.sh
git-merge-octopus.sh
git-merge-one-file.sh
git-merge-resolve.sh
git-mergetool--lib.sh
git-mergetool.sh
git-parse-remote.sh
git-pull.sh Merge branch 'en/rebase-against-rebase-fix' into maint 2010-09-01 13:43:55 -07:00
git-quiltimport.sh
git-rebase--interactive.sh git-rebase--interactive.sh: use printf instead of echo to print commit message 2010-07-25 23:14:18 -07:00
git-rebase.sh Merge branch 'jn/rebase-rename-am' into maint 2010-08-20 12:53:08 -07:00
git-relink.perl
git-remote-testgit.py
git-repack.sh
git-request-pull.sh
git-send-email.perl
git-sh-setup.sh
git-stash.sh
git-submodule.sh submodule sync: Update "submodule.<name>.url" 2010-08-18 13:54:30 -07:00
git-svn.perl git-svn: write memoized data explicitly to avoid Storable bug 2010-07-19 06:31:04 +00:00
GIT-VERSION-GEN Git 1.7.2.3 2010-09-03 09:38:53 -07:00
git-web--browse.sh Add a google-chrome option for web--browse 2010-07-25 23:14:18 -07:00
git.c Fix 'git log' early pager startup error case 2010-08-25 12:11:59 -07:00
git.spec.in git.spec.in: Add gitweb subpackage 2010-06-30 15:49:18 -07:00
graph.c Typos in code comments, an error message, documentation 2010-08-22 13:25:08 -07:00
graph.h
grep.c
grep.h
hash.c
hash.h
help.c
help.h
hex.c
http-backend.c Merge branch 'jp/string-list-api-cleanup' 2010-06-30 11:55:38 -07:00
http-fetch.c
http-push.c
http-walker.c
http.c
http.h Standardize do { ... } while (0) style 2010-08-12 15:44:51 -07:00
ident.c
imap-send.c imap-send: Fix sprintf usage 2010-08-09 11:35:46 -07:00
INSTALL INSTALL: configure /etc/xml/catalog to build docs on Cygwin 2010-07-25 23:14:18 -07:00
levenshtein.c
levenshtein.h
list-objects.c
list-objects.h
ll-merge.c
ll-merge.h
lockfile.c
log-tree.c
log-tree.h
mailmap.c
mailmap.h
Makefile compat/nedmalloc: don't force NDEBUG on the rest of git 2010-09-11 10:23:03 -07:00
match-trees.c
merge-file.c
merge-recursive.c merge-recursive: use "up-to-date" instead of "uptodate" in error message for consistency 2010-07-09 16:28:46 -07:00
merge-recursive.h
name-hash.c
notes-cache.c
notes-cache.h
notes.c Merge branch 'jp/string-list-api-cleanup' 2010-06-30 11:55:38 -07:00
notes.h
object.c Merge branch 'xx/trivial' into maint 2010-09-06 00:11:59 -07:00
object.h
pack-check.c Typos in code comments, an error message, documentation 2010-08-22 13:25:08 -07:00
pack-refs.c pack-refs: remove newly empty directories 2010-07-07 09:11:37 -07:00
pack-refs.h
pack-revindex.c
pack-revindex.h
pack-write.c
pack.h
pager.c
parse-options.c
parse-options.h parse-options: clarify PARSE_OPT_NOARG description 2010-08-24 10:37:39 -07:00
patch-delta.c
patch-ids.c
patch-ids.h
path.c Sync with 1.7.0 series 2010-07-27 15:01:36 -07:00
pkt-line.c
pkt-line.h
preload-index.c
pretty.c
progress.c
progress.h
quote.c
quote.h
reachable.c
reachable.h
read-cache.c core: Stop leaking ondisk_cache_entrys 2010-08-11 09:57:43 -07:00
README
reflog-walk.c
reflog-walk.h Introduce new pretty formats %g[sdD] for reflog information 2009-10-19 22:28:26 -07:00
refs.c Merge branch 'maint' 2010-07-07 11:18:26 -07:00
refs.h
RelNotes Prepare for 1.7.2.3 2010-09-01 15:10:03 -07:00
remote-curl.c Merge branch 'sp/fix-smart-http-deadlock-on-error' into maint 2010-08-18 16:30:11 -07:00
remote.c Merge branch 'jp/string-list-api-cleanup' 2010-06-30 11:55:38 -07:00
remote.h
replace_object.c
rerere.c Merge branch 'sg/rerere-gc-old-still-used' into maint 2010-09-01 13:57:23 -07:00
rerere.h
resolve-undo.c
resolve-undo.h
revision.c Merge branch 'jp/string-list-api-cleanup' 2010-06-30 11:55:38 -07:00
revision.h Merge branch 'tr/rev-list-count' 2010-06-30 11:55:38 -07:00
run-command.c
run-command.h
send-pack.h
server-info.c update-server-info: Shorten read_pack_info_file() 2010-07-19 11:13:52 -07:00
setup.c Merge branch 'maint-1.6.6' into maint-1.7.0 2010-07-25 21:52:48 -07:00
sha1-lookup.c
sha1-lookup.h
sha1_file.c
sha1_name.c Merge branch 'jc/sha1-name-find-fix' into maint 2010-08-19 15:49:24 -07:00
shallow.c
shell.c
shortlog.h
show-index.c
sideband.c
sideband.h
sigchain.c
sigchain.h
strbuf.c
strbuf.h
string-list.c
string-list.h
submodule.c
submodule.h
symlinks.c
tag.c Merge branch 'xx/trivial' into maint 2010-09-06 00:11:59 -07:00
tag.h
tar.h
test-chmtime.c
test-ctype.c
test-date.c test-date: fix sscanf type conversion 2010-07-06 08:42:15 -07:00
test-delta.c
test-dump-cache-tree.c
test-genrandom.c
test-index-version.c
test-match-trees.c
test-parse-options.c
test-path-utils.c
test-run-command.c
test-sha1.c
test-sha1.sh
test-sigchain.c
thread-utils.c
thread-utils.h
trace.c
transport-helper.c
transport.c
transport.h
tree-diff.c diff --follow: do call diffcore_std() as necessary 2010-08-13 12:17:45 -07:00
tree-walk.c
tree-walk.h tree-walk: Correct bitrotted comment about tree_entry() 2010-08-25 16:31:21 -07:00
tree.c
tree.h
unimplemented.sh
unpack-trees.c read-tree: stop leaking tree objects 2010-08-11 09:58:18 -07:00
unpack-trees.h
upload-pack.c
url.c
url.h
usage.c
userdiff.c
userdiff.h
utf8.c
utf8.h
walker.c
walker.h
wrap-for-bin.sh
wrapper.c xmalloc: include size in the failure message 2010-08-20 09:27:38 -07:00
write_or_die.c
ws.c
wt-status.c Merge branch 'jl/status-ignore-submodules' 2010-06-30 11:55:39 -07:00
wt-status.h Merge branch 'jl/status-ignore-submodules' 2010-06-30 11:55:39 -07:00
xdiff-interface.c xdiff-interface.c: always trim trailing space from xfuncname matches 2010-09-09 17:18:29 -07:00
xdiff-interface.h

////////////////////////////////////////////////////////////////

	GIT - the stupid content tracker

////////////////////////////////////////////////////////////////

"git" can mean anything, depending on your mood.

 - random three-letter combination that is pronounceable, and not
   actually used by any common UNIX command.  The fact that it is a
   mispronunciation of "get" may or may not be relevant.
 - stupid. contemptible and despicable. simple. Take your pick from the
   dictionary of slang.
 - "global information tracker": you're in a good mood, and it actually
   works for you. Angels sing, and a light suddenly fills the room.
 - "goddamn idiotic truckload of sh*t": when it breaks

Git is a fast, scalable, distributed revision control system with an
unusually rich command set that provides both high-level operations
and full access to internals.

Git is an Open Source project covered by the GNU General Public License.
It was originally written by Linus Torvalds with help of a group of
hackers around the net. It is currently maintained by Junio C Hamano.

Please read the file INSTALL for installation instructions.

See Documentation/gittutorial.txt to get started, then see
Documentation/everyday.txt for a useful minimum set of commands, and
Documentation/git-commandname.txt for documentation of each command.
If git has been correctly installed, then the tutorial can also be
read with "man gittutorial" or "git help tutorial", and the
documentation of each command with "man git-commandname" or "git help
commandname".

CVS users may also want to read Documentation/gitcvs-migration.txt
("man gitcvs-migration" or "git help cvs-migration" if git is
installed).

Many Git online resources are accessible from http://git-scm.com/
including full documentation and Git related tools.

The user discussion and development of Git take place on the Git
mailing list -- everyone is welcome to post bug reports, feature
requests, comments and patches to git@vger.kernel.org. To subscribe
to the list, send an email with just "subscribe git" in the body to
majordomo@vger.kernel.org. The mailing list archives are available at
http://marc.theaimsgroup.com/?l=git and other archival sites.

The messages titled "A note from the maintainer", "What's in
git.git (stable)" and "What's cooking in git.git (topics)" and
the discussion following them on the mailing list give a good
reference for project status, development direction and
remaining tasks.