mirror of
https://github.com/git/git
synced 2024-10-29 17:08:46 +00:00
d162b25f95
This removes the ability to inject "poison" gettext() messages via the GIT_TEST_GETTEXT_POISON special test setup. I initially added this as a compile-time option inbb946bba76(i18n: add GETTEXT_POISON to simulate unfriendly translator, 2011-02-22), and most recently modified to be toggleable at runtime in6cdccfce1e(i18n: make GETTEXT_POISON a runtime option, 2018-11-08).. The reason for its removal is that the trade-off of maintaining it v.s. what it's getting us has long since flipped. When gettext was integrated in5e9637c629(i18n: add infrastructure for translating Git with gettext, 2011-11-18) there was understandable concern on the Git ML that in marking messages for translation en-masse we'd inadvertently mark plumbing messages. The GETTEXT_POISON facility was a way to smoke those out via our test suite. Nowadays however we're done (or almost entirely done) with any marking of messages for translation. New messages are usually marked by their authors, who'll know whether it makes sense to translate them or not. If not any errors in marking the messages are much more likely to be spotted in review than in the the initial deluge of i18n patches in the 2011-2012 era. So let's just remove this. This leaves the test suite in a state where we still have a lot of test_i18n, C_LOCALE_OUTPUT etc. uses. Subsequent commits will remove those too. The change to t/lib-rebase.sh is a selective revert of the relevant part off2d17068fd(i18n: rebase-interactive: mark comments of squash for translation, 2016-06-17), and the comment in t/t3406-rebase-message.sh is fromc7108bf9ed(i18n: rebase: mark messages for translation, 2012-07-25). Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
99 lines
3.5 KiB
Bash
Executable file
99 lines
3.5 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='test env--helper'
|
|
|
|
. ./test-lib.sh
|
|
|
|
|
|
test_expect_success 'env--helper usage' '
|
|
test_must_fail git env--helper &&
|
|
test_must_fail git env--helper --type=bool &&
|
|
test_must_fail git env--helper --type=ulong &&
|
|
test_must_fail git env--helper --type=bool &&
|
|
test_must_fail git env--helper --type=bool --default &&
|
|
test_must_fail git env--helper --type=bool --default= &&
|
|
test_must_fail git env--helper --defaultxyz
|
|
'
|
|
|
|
test_expect_success 'env--helper bad default values' '
|
|
test_must_fail git env--helper --type=bool --default=1xyz MISSING &&
|
|
test_must_fail git env--helper --type=ulong --default=1xyz MISSING
|
|
'
|
|
|
|
test_expect_success 'env--helper --type=bool' '
|
|
# Test various --default bool values
|
|
echo true >expected &&
|
|
git env--helper --type=bool --default=1 MISSING >actual &&
|
|
test_cmp expected actual &&
|
|
git env--helper --type=bool --default=yes MISSING >actual &&
|
|
test_cmp expected actual &&
|
|
git env--helper --type=bool --default=true MISSING >actual &&
|
|
test_cmp expected actual &&
|
|
echo false >expected &&
|
|
test_must_fail git env--helper --type=bool --default=0 MISSING >actual &&
|
|
test_cmp expected actual &&
|
|
test_must_fail git env--helper --type=bool --default=no MISSING >actual &&
|
|
test_cmp expected actual &&
|
|
test_must_fail git env--helper --type=bool --default=false MISSING >actual &&
|
|
test_cmp expected actual &&
|
|
|
|
# No output with --exit-code
|
|
git env--helper --type=bool --default=true --exit-code MISSING >actual.out 2>actual.err &&
|
|
test_must_be_empty actual.out &&
|
|
test_must_be_empty actual.err &&
|
|
test_must_fail git env--helper --type=bool --default=false --exit-code MISSING >actual.out 2>actual.err &&
|
|
test_must_be_empty actual.out &&
|
|
test_must_be_empty actual.err &&
|
|
|
|
# Existing variable
|
|
EXISTS=true git env--helper --type=bool --default=false --exit-code EXISTS >actual.out 2>actual.err &&
|
|
test_must_be_empty actual.out &&
|
|
test_must_be_empty actual.err &&
|
|
test_must_fail \
|
|
env EXISTS=false \
|
|
git env--helper --type=bool --default=true --exit-code EXISTS >actual.out 2>actual.err &&
|
|
test_must_be_empty actual.out &&
|
|
test_must_be_empty actual.err
|
|
'
|
|
|
|
test_expect_success 'env--helper --type=ulong' '
|
|
echo 1234567890 >expected &&
|
|
git env--helper --type=ulong --default=1234567890 MISSING >actual.out 2>actual.err &&
|
|
test_cmp expected actual.out &&
|
|
test_must_be_empty actual.err &&
|
|
|
|
echo 0 >expected &&
|
|
test_must_fail git env--helper --type=ulong --default=0 MISSING >actual &&
|
|
test_cmp expected actual &&
|
|
|
|
git env--helper --type=ulong --default=1234567890 --exit-code MISSING >actual.out 2>actual.err &&
|
|
test_must_be_empty actual.out &&
|
|
test_must_be_empty actual.err &&
|
|
|
|
EXISTS=1234567890 git env--helper --type=ulong --default=0 EXISTS --exit-code >actual.out 2>actual.err &&
|
|
test_must_be_empty actual.out &&
|
|
test_must_be_empty actual.err &&
|
|
|
|
echo 1234567890 >expected &&
|
|
EXISTS=1234567890 git env--helper --type=ulong --default=0 EXISTS >actual.out 2>actual.err &&
|
|
test_cmp expected actual.out &&
|
|
test_must_be_empty actual.err
|
|
'
|
|
|
|
test_expect_success 'env--helper reads config thanks to trace2' '
|
|
mkdir home &&
|
|
git config -f home/.gitconfig include.path cycle &&
|
|
git config -f home/cycle include.path .gitconfig &&
|
|
|
|
test_must_fail \
|
|
env HOME="$(pwd)/home" \
|
|
git config -l 2>err &&
|
|
grep "exceeded maximum include depth" err &&
|
|
|
|
test_must_fail \
|
|
env HOME="$(pwd)/home" GIT_TEST_ENV_HELPER=true \
|
|
git -C cycle env--helper --type=bool --default=0 --exit-code GIT_TEST_ENV_HELPER 2>err &&
|
|
grep "exceeded maximum include depth" err
|
|
'
|
|
|
|
test_done
|