mirror of
https://github.com/git/git
synced 2024-11-05 18:59:29 +00:00
644bb953ce
While help.autocorrect can be set to 0 to decline auto-execution of possibly mistyped commands, it still spends cycles to compute the suggestions, and it wastes screen real estate. Update help.autocorrect to accept the string "never" to just exit with error upon mistyped commands to help users who prefer to never see suggested corrections at all. While at it, introduce "immediate" as a more readable way to immediately execute the auto-corrected command, which can be done with negative value. Signed-off-by: Drew DeVault <sir@cmpwn.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
66 lines
1.4 KiB
Bash
Executable file
66 lines
1.4 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='help.autocorrect finding a match'
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'setup' '
|
|
# An alias
|
|
git config alias.lgf "log --format=%s --first-parent" &&
|
|
|
|
# A random user-defined command
|
|
write_script git-distimdistim <<-EOF &&
|
|
echo distimdistim was called
|
|
EOF
|
|
|
|
PATH="$PATH:." &&
|
|
export PATH &&
|
|
|
|
git commit --allow-empty -m "a single log entry" &&
|
|
|
|
# Sanity check
|
|
git lgf >actual &&
|
|
echo "a single log entry" >expect &&
|
|
test_cmp expect actual &&
|
|
|
|
git distimdistim >actual &&
|
|
echo "distimdistim was called" >expect &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'autocorrect showing candidates' '
|
|
git config help.autocorrect 0 &&
|
|
|
|
test_must_fail git lfg 2>actual &&
|
|
grep "^ lgf" actual &&
|
|
|
|
test_must_fail git distimdist 2>actual &&
|
|
grep "^ distimdistim" actual
|
|
'
|
|
|
|
for immediate in -1 immediate
|
|
do
|
|
test_expect_success 'autocorrect running commands' '
|
|
git config help.autocorrect $immediate &&
|
|
|
|
git lfg >actual &&
|
|
echo "a single log entry" >expect &&
|
|
test_cmp expect actual &&
|
|
|
|
git distimdist >actual &&
|
|
echo "distimdistim was called" >expect &&
|
|
test_cmp expect actual
|
|
'
|
|
done
|
|
|
|
test_expect_success 'autocorrect can be declined altogether' '
|
|
git config help.autocorrect never &&
|
|
|
|
test_must_fail git lfg 2>actual &&
|
|
if test_have_prereq C_LOCALE_OUTPUT
|
|
then
|
|
grep "is not a git command" actual &&
|
|
test_line_count = 1 actual
|
|
fi
|
|
'
|
|
|
|
test_done
|