mirror of
https://github.com/git/git
synced 2024-07-17 11:07:55 +00:00
dc1cf3580e
Address the root cause of technical debt we've been carrying since sha1collisiondetection was made the default in [1]. In a preceding commit we narrowly fixed a bug where the "DC_SHA1" variable would be unset (in combination with "NO_APPLE_COMMON_CRYPTO=" on OSX), even though we had the sha1collisiondetection library enabled. But the only reason we needed to have such a user-exposed knob went away with [1], and it's been doing nothing useful since then. We don't care if you define DC_SHA1=*, we only care that you don't ask for any other SHA-1 implementation. If it turns out that you didn't, we'll use sha1collisiondetection, whether you had "DC_SHA1" set or not. As a result of this being confusing we had e.g. [2] for cmake and the recent [3] for ci/lib.sh setting "DC_SHA1" explicitly, even though this was always a NOOP. A much simpler way to do this is to stop having the Makefile and CMakeLists.txt set "DC_SHA1" to be picked up by the test-lib.sh, let's instead add a trivial "test-tool sha1-is-sha1dc". It returns zero if we're using sha1collisiondetection, non-zero otherwise. 1. |
||
|---|---|---|
| .. | ||
| config | ||
| util | ||
| check-directional-formatting.bash | ||
| install-dependencies.sh | ||
| install-docker-dependencies.sh | ||
| lib.sh | ||
| make-test-artifacts.sh | ||
| mount-fileshare.sh | ||
| print-test-failures.sh | ||
| run-build-and-tests.sh | ||
| run-docker-build.sh | ||
| run-docker.sh | ||
| run-static-analysis.sh | ||
| run-test-slice.sh | ||
| test-documentation.sh | ||