mirror of
https://github.com/git/git
synced 2024-10-30 14:03:28 +00:00
9ff2f06069
Make the replay_opts_release() function added in the preceding commit non-static, and use it for freeing the "struct replay_opts" constructed for "rebase" and "revert". To safely call our new replay_opts_release() we'll need to stop calling it in sequencer_remove_state(), and instead call it where we allocate the "struct replay_opts" itself. This is because in e.g. do_interactive_rebase() we construct a "struct replay_opts" with "get_replay_opts()", and then call "complete_action()". If we get far enough in that function without encountering errors we'll call "pick_commits()" which (indirectly) calls sequencer_remove_state() at the end. But if we encounter errors anywhere along the way we'd punt out early, and not free() the memory we allocated. Remembering whether we previously called sequencer_remove_state() would be a hassle. Using a FREE_AND_NULL() pattern would also work, as it would be safe to call replay_opts_release() repeatedly. But let's fix this properly instead, by having the owner of the data free() it. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
136 lines
2.5 KiB
Bash
Executable file
136 lines
2.5 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='cherry picking and reverting a merge
|
|
|
|
b---c
|
|
/ /
|
|
initial---a
|
|
|
|
'
|
|
|
|
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
|
|
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success setup '
|
|
|
|
>A &&
|
|
>B &&
|
|
git add A B &&
|
|
git commit -m "Initial" &&
|
|
git tag initial &&
|
|
git branch side &&
|
|
echo new line >A &&
|
|
git commit -m "add line to A" A &&
|
|
git tag a &&
|
|
git checkout side &&
|
|
echo new line >B &&
|
|
git commit -m "add line to B" B &&
|
|
git tag b &&
|
|
git checkout main &&
|
|
git merge side &&
|
|
git tag c
|
|
|
|
'
|
|
|
|
test_expect_success 'cherry-pick -m complains of bogus numbers' '
|
|
# expect 129 here to distinguish between cases where
|
|
# there was nothing to cherry-pick
|
|
test_expect_code 129 git cherry-pick -m &&
|
|
test_expect_code 129 git cherry-pick -m foo b &&
|
|
test_expect_code 129 git cherry-pick -m -1 b &&
|
|
test_expect_code 129 git cherry-pick -m 0 b
|
|
'
|
|
|
|
test_expect_success 'cherry-pick explicit first parent of a non-merge' '
|
|
|
|
git reset --hard &&
|
|
git checkout a^0 &&
|
|
git cherry-pick -m 1 b &&
|
|
git diff --exit-code c --
|
|
|
|
'
|
|
|
|
test_expect_success 'cherry pick a merge without -m should fail' '
|
|
|
|
git reset --hard &&
|
|
git checkout a^0 &&
|
|
test_must_fail git cherry-pick c &&
|
|
git diff --exit-code a --
|
|
|
|
'
|
|
|
|
test_expect_success 'cherry pick a merge (1)' '
|
|
|
|
git reset --hard &&
|
|
git checkout a^0 &&
|
|
git cherry-pick -m 1 c &&
|
|
git diff --exit-code c
|
|
|
|
'
|
|
|
|
test_expect_success 'cherry pick a merge (2)' '
|
|
|
|
git reset --hard &&
|
|
git checkout b^0 &&
|
|
git cherry-pick -m 2 c &&
|
|
git diff --exit-code c
|
|
|
|
'
|
|
|
|
test_expect_success 'cherry pick a merge relative to nonexistent parent should fail' '
|
|
|
|
git reset --hard &&
|
|
git checkout b^0 &&
|
|
test_must_fail git cherry-pick -m 3 c
|
|
|
|
'
|
|
|
|
test_expect_success 'revert explicit first parent of a non-merge' '
|
|
|
|
git reset --hard &&
|
|
git checkout c^0 &&
|
|
git revert -m 1 b &&
|
|
git diff --exit-code a --
|
|
|
|
'
|
|
|
|
test_expect_success 'revert a merge without -m should fail' '
|
|
|
|
git reset --hard &&
|
|
git checkout c^0 &&
|
|
test_must_fail git revert c &&
|
|
git diff --exit-code c
|
|
|
|
'
|
|
|
|
test_expect_success 'revert a merge (1)' '
|
|
|
|
git reset --hard &&
|
|
git checkout c^0 &&
|
|
git revert -m 1 c &&
|
|
git diff --exit-code a --
|
|
|
|
'
|
|
|
|
test_expect_success 'revert a merge (2)' '
|
|
|
|
git reset --hard &&
|
|
git checkout c^0 &&
|
|
git revert -m 2 c &&
|
|
git diff --exit-code b --
|
|
|
|
'
|
|
|
|
test_expect_success 'revert a merge relative to nonexistent parent should fail' '
|
|
|
|
git reset --hard &&
|
|
git checkout c^0 &&
|
|
test_must_fail git revert -m 3 c &&
|
|
git diff --exit-code c
|
|
|
|
'
|
|
|
|
test_done
|