mirror of
https://github.com/git/git
synced 2024-08-24 10:15:51 +00:00
ea2d20d4c2
Test 2 of t5004 checks if a supposedly empty tar archive really
contains no files. 24676f02 (t5004: fix issue with empty archive test
and bsdtar) removed our commit hash to make it work with bsdtar, but
the test still fails on NetBSD and OpenBSD, which use their own tar
that considers a tar file containing only NULs as broken.
Here's what the different archivers do when asked to create a tar
file without entries:
$ uname -v
NetBSD 6.0.1 (GENERIC)
$ gtar --version | head -1
tar (GNU tar) 1.26
$ bsdtar --version
bsdtar 2.8.4 - libarchive 2.8.4
$ : >zero.tar
$ perl -e 'print "\0" x 10240' >tenk.tar
$ sha1 zero.tar tenk.tar
SHA1 (zero.tar) = da39a3ee5e6b4b0d3255bfef95601890afd80709
SHA1 (tenk.tar) = 34e163be8e43c5631d8b92e9c43ab0bf0fa62b9c
$ : | tar cf - -T - | sha1
da39a3ee5e6b4b0d3255bfef95601890afd80709
$ : | gtar cf - -T - | sha1
34e163be8e43c5631d8b92e9c43ab0bf0fa62b9c
$ : | bsdtar cf - -T - | sha1
34e163be8e43c5631d8b92e9c43ab0bf0fa62b9c
So NetBSD's native tar creates an empty file, while GNU tar and bsdtar
both give us 10KB of NULs -- just like git archive with an empty tree.
Now let's see how the archivers handle these two kinds of empty tar
files:
$ tar tf zero.tar; echo $?
tar: Unexpected EOF on archive file
1
$ gtar tf zero.tar; echo $?
gtar: This does not look like a tar archive
gtar: Exiting with failure status due to previous errors
2
$ bsdtar tf zero.tar; echo $?
0
$ tar tf tenk.tar; echo $?
tar: Cannot identify format. Searching...
tar: End of archive volume 1 reached
tar: Sorry, unable to determine archive format.
1
$ gtar tf tenk.tar; echo $?
0
$ bsdtar tf tenk.tar; echo $?
0
NetBSD's tar complains about both, bsdtar happily accepts any of them
and GNU tar doesn't like zero-length archive files. So the safest
course of action is to stay with our block-of-NULs format which is
compatible with GNU tar and bsdtar, as we can't make NetBSD's native
tar happy anyway.
We can simplify our test, however, by taking tar out of the picture.
Instead of extracting the archive and checking for the non-presence of
files, check if the file has a size of 10KB and contains only NULs.
This makes t5004 pass on NetBSD and OpenBSD.
Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
102 lines
2.9 KiB
Bash
Executable file
102 lines
2.9 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='test corner cases of git-archive'
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'create commit with empty tree' '
|
|
git commit --allow-empty -m foo
|
|
'
|
|
|
|
# Make a dir and clean it up afterwards
|
|
make_dir() {
|
|
mkdir "$1" &&
|
|
test_when_finished "rm -rf '$1'"
|
|
}
|
|
|
|
# Check that the dir given in "$1" contains exactly the
|
|
# set of paths given as arguments.
|
|
check_dir() {
|
|
dir=$1; shift
|
|
{
|
|
echo "$dir" &&
|
|
for i in "$@"; do
|
|
echo "$dir/$i"
|
|
done
|
|
} | sort >expect &&
|
|
find "$dir" ! -name pax_global_header -print | sort >actual &&
|
|
test_cmp expect actual
|
|
}
|
|
|
|
test_expect_success 'tar archive of empty tree is empty' '
|
|
git archive --format=tar HEAD: >empty.tar &&
|
|
perl -e "print \"\\0\" x 10240" >10knuls.tar &&
|
|
test_cmp 10knuls.tar empty.tar
|
|
'
|
|
|
|
test_expect_success 'tar archive of empty tree with prefix' '
|
|
git archive --format=tar --prefix=foo/ HEAD >prefix.tar &&
|
|
make_dir extract &&
|
|
"$TAR" xf prefix.tar -C extract &&
|
|
check_dir extract foo
|
|
'
|
|
|
|
test_expect_success UNZIP 'zip archive of empty tree is empty' '
|
|
# Detect the exit code produced when our particular flavor of unzip
|
|
# sees an empty archive. Infozip will generate a warning and exit with
|
|
# code 1. But in the name of sanity, we do not expect other unzip
|
|
# implementations to do the same thing (it would be perfectly
|
|
# reasonable to exit 0, for example).
|
|
#
|
|
# This makes our test less rigorous on some platforms (unzip may not
|
|
# handle the empty repo at all, making our later check of its exit code
|
|
# a no-op). But we cannot do anything reasonable except skip the test
|
|
# on such platforms anyway, and this is the moral equivalent.
|
|
"$GIT_UNZIP" "$TEST_DIRECTORY"/t5004/empty.zip
|
|
expect_code=$?
|
|
|
|
git archive --format=zip HEAD >empty.zip &&
|
|
make_dir extract &&
|
|
(
|
|
cd extract &&
|
|
test_expect_code $expect_code "$GIT_UNZIP" ../empty.zip
|
|
) &&
|
|
check_dir extract
|
|
'
|
|
|
|
test_expect_success UNZIP 'zip archive of empty tree with prefix' '
|
|
# We do not have to play exit-code tricks here, because our
|
|
# result should not be empty; it has a directory in it.
|
|
git archive --format=zip --prefix=foo/ HEAD >prefix.zip &&
|
|
make_dir extract &&
|
|
(
|
|
cd extract &&
|
|
"$GIT_UNZIP" ../prefix.zip
|
|
) &&
|
|
check_dir extract foo
|
|
'
|
|
|
|
test_expect_success 'archive complains about pathspec on empty tree' '
|
|
test_must_fail git archive --format=tar HEAD -- foo >/dev/null
|
|
'
|
|
|
|
test_expect_success 'create a commit with an empty subtree' '
|
|
empty_tree=$(git hash-object -t tree /dev/null) &&
|
|
root_tree=$(printf "040000 tree $empty_tree\tsub\n" | git mktree)
|
|
'
|
|
|
|
test_expect_success 'archive empty subtree with no pathspec' '
|
|
git archive --format=tar $root_tree >subtree-all.tar &&
|
|
make_dir extract &&
|
|
"$TAR" xf subtree-all.tar -C extract &&
|
|
check_dir extract sub
|
|
'
|
|
|
|
test_expect_success 'archive empty subtree by direct pathspec' '
|
|
git archive --format=tar $root_tree -- sub >subtree-path.tar &&
|
|
make_dir extract &&
|
|
"$TAR" xf subtree-path.tar -C extract &&
|
|
check_dir extract sub
|
|
'
|
|
|
|
test_done
|