mirror of
https://github.com/git/git
synced 2024-08-27 11:39:22 +00:00
![Ævar Arnfjörð Bjarmason](/assets/img/avatar_default.png)
Mark those remaining tests that pass when run under SANITIZE=leak with TEST_PASSES_SANITIZE_LEAK=true, these were either omitted inf346fcb62a
(Merge branch 'ab/mark-leak-free-tests-even-more', 2021-12-15) and5a4f8381b6
(Merge branch 'ab/mark-leak-free-tests', 2021-10-25), or have had their memory leaks fixed since then. With this change there's now a a one-to-one mapping between those tests that we have opted-in via "TEST_PASSES_SANITIZE_LEAK=true", and those that pass with the new "check" mode: GIT_TEST_PASSING_SANITIZE_LEAK=check \ GIT_TEST_SANITIZE_LEAK_LOG=true \ make test SANITIZE=leak Note that the "GIT_TEST_SANITIZE_LEAK_LOG=true" is needed due to the edge cases noted in a preceding commit, i.e. in some cases we'd pass the test itself, but still have outstanding leaks due to ignored exit codes. The "GIT_TEST_SANITIZE_LEAK_LOG=true" corrects for that, we're only marking those tests as passing that really don't have any leaks, whether that was reflected in their exit code or not. Note that the change here to "t9100-git-svn-basic.sh" is marking that test as passing under SANITIZE=leak, we're removing a "TEST_FAILS_SANITIZE_LEAK=true" line, not "TEST_PASSES_SANITIZE_LEAK=true". See7a98d9ab00
(revisions API: have release_revisions() release "cmdline", 2022-04-13) for the introduction of that t/lib-git-svn.sh-specific variable. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
67 lines
1.7 KiB
Bash
Executable file
67 lines
1.7 KiB
Bash
Executable file
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2007 Johannes Sixt
|
|
#
|
|
|
|
test_description='merging symlinks on filesystem w/o symlink support.
|
|
|
|
This tests that git merge-recursive writes merge results as plain files
|
|
if core.symlinks is false.'
|
|
|
|
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
|
|
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'setup' '
|
|
git config core.symlinks false &&
|
|
>file &&
|
|
git add file &&
|
|
git commit -m initial &&
|
|
git branch b-symlink &&
|
|
git branch b-file &&
|
|
l=$(printf file | git hash-object -t blob -w --stdin) &&
|
|
echo "120000 $l symlink" | git update-index --index-info &&
|
|
git commit -m main &&
|
|
git checkout b-symlink &&
|
|
l=$(printf file-different | git hash-object -t blob -w --stdin) &&
|
|
echo "120000 $l symlink" | git update-index --index-info &&
|
|
git commit -m b-symlink &&
|
|
git checkout b-file &&
|
|
echo plain-file >symlink &&
|
|
git add symlink &&
|
|
git commit -m b-file
|
|
'
|
|
|
|
test_expect_success 'merge main into b-symlink, which has a different symbolic link' '
|
|
git checkout b-symlink &&
|
|
test_must_fail git merge main
|
|
'
|
|
|
|
test_expect_success 'the merge result must be a file' '
|
|
test_path_is_file symlink
|
|
'
|
|
|
|
test_expect_success 'merge main into b-file, which has a file instead of a symbolic link' '
|
|
git reset --hard &&
|
|
git checkout b-file &&
|
|
test_must_fail git merge main
|
|
'
|
|
|
|
test_expect_success 'the merge result must be a file' '
|
|
test_path_is_file symlink
|
|
'
|
|
|
|
test_expect_success 'merge b-file, which has a file instead of a symbolic link, into main' '
|
|
git reset --hard &&
|
|
git checkout main &&
|
|
test_must_fail git merge b-file
|
|
'
|
|
|
|
test_expect_success 'the merge result must be a file' '
|
|
test_path_is_file symlink
|
|
'
|
|
|
|
test_done
|