mirror of
https://github.com/git/git
synced 2024-11-05 18:59:29 +00:00
f172556b89
"git cherry-pick", upon seeing a conflict, says: hint: after resolving the conflicts, mark the corrected paths hint: with 'git add <paths>' or 'git rm <paths>' hint: and commit the result with 'git commit' as if running "git commit" to conclude the resolution of this single step were the end of the story. This stems from the fact that the command originally was to pick a single commit and not a range of commits, and the message was written back then and has not been adjusted. When picking a range of commits and the command stops with a conflict in the middle of the range, however, after resolving the conflict and (optionally) recording the result with "git commit", the user has to run "git cherry-pick --continue" to have the rest of the range dealt with, "--skip" to drop the current commit, or "--abort" to discard the series. Suggest use of "git cherry-pick --continue/--skip/--abort" so that the message also covers the case where a range of commits are being picked. Similarly, this optimization can be applied to git revert, suggest use of "git revert --continue/--skip/--abort" so that the message also covers the case where a range of commits are being reverted. It is worth mentioning that now we use advice() to print the content of GIT_CHERRY_PICK_HELP in print_advice(), each line of output will start with "hint: ". Mentored-by: Christian Couder <christian.couder@gmail.com> Mentored-by: Hariom Verma <hariom18599@gmail.com> Helped-by: Phillip Wood <phillip.wood@dunelm.org.uk> Helped-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: ZheNing Hu <adlternative@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
177 lines
4.2 KiB
Bash
Executable file
177 lines
4.2 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='test cherry-pick and revert with renames
|
|
|
|
--
|
|
+ rename2: renames oops to opos
|
|
+ rename1: renames oops to spoo
|
|
+ added: adds extra line to oops
|
|
++ initial: has lines in oops
|
|
|
|
'
|
|
|
|
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
|
|
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
|
|
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success setup '
|
|
|
|
for l in a b c d e f g h i j k l m n o
|
|
do
|
|
echo $l$l$l$l$l$l$l$l$l
|
|
done >oops &&
|
|
|
|
test_tick &&
|
|
git add oops &&
|
|
git commit -m initial &&
|
|
git tag initial &&
|
|
|
|
test_tick &&
|
|
echo "Add extra line at the end" >>oops &&
|
|
git commit -a -m added &&
|
|
git tag added &&
|
|
|
|
test_tick &&
|
|
git mv oops spoo &&
|
|
git commit -m rename1 &&
|
|
git tag rename1 &&
|
|
|
|
test_tick &&
|
|
git checkout -b side initial &&
|
|
git mv oops opos &&
|
|
git commit -m rename2 &&
|
|
git tag rename2
|
|
'
|
|
|
|
test_expect_success 'cherry-pick --nonsense' '
|
|
|
|
pos=$(git rev-parse HEAD) &&
|
|
git diff --exit-code HEAD &&
|
|
test_must_fail git cherry-pick --nonsense 2>msg &&
|
|
git diff --exit-code HEAD "$pos" &&
|
|
test_i18ngrep "[Uu]sage:" msg
|
|
'
|
|
|
|
test_expect_success 'revert --nonsense' '
|
|
|
|
pos=$(git rev-parse HEAD) &&
|
|
git diff --exit-code HEAD &&
|
|
test_must_fail git revert --nonsense 2>msg &&
|
|
git diff --exit-code HEAD "$pos" &&
|
|
test_i18ngrep "[Uu]sage:" msg
|
|
'
|
|
|
|
test_expect_success 'cherry-pick after renaming branch' '
|
|
|
|
git checkout rename2 &&
|
|
git cherry-pick added &&
|
|
test $(git rev-parse HEAD^) = $(git rev-parse rename2) &&
|
|
test -f opos &&
|
|
grep "Add extra line at the end" opos &&
|
|
git reflog -1 | grep cherry-pick
|
|
|
|
'
|
|
|
|
test_expect_success 'revert after renaming branch' '
|
|
|
|
git checkout rename1 &&
|
|
git revert added &&
|
|
test $(git rev-parse HEAD^) = $(git rev-parse rename1) &&
|
|
test -f spoo &&
|
|
! grep "Add extra line at the end" spoo &&
|
|
git reflog -1 | grep revert
|
|
|
|
'
|
|
|
|
test_expect_success 'cherry-pick on stat-dirty working tree' '
|
|
git clone . copy &&
|
|
(
|
|
cd copy &&
|
|
git checkout initial &&
|
|
test-tool chmtime +40 oops &&
|
|
git cherry-pick added
|
|
)
|
|
'
|
|
|
|
test_expect_success 'revert forbidden on dirty working tree' '
|
|
|
|
echo content >extra_file &&
|
|
git add extra_file &&
|
|
test_must_fail git revert HEAD 2>errors &&
|
|
test_i18ngrep "your local changes would be overwritten by " errors
|
|
|
|
'
|
|
|
|
test_expect_success 'cherry-pick on unborn branch' '
|
|
git checkout --orphan unborn &&
|
|
git rm --cached -r . &&
|
|
rm -rf * &&
|
|
git cherry-pick initial &&
|
|
git diff --quiet initial &&
|
|
test_cmp_rev ! initial HEAD
|
|
'
|
|
|
|
test_expect_success 'cherry-pick "-" to pick from previous branch' '
|
|
git checkout unborn &&
|
|
test_commit to-pick actual content &&
|
|
git checkout main &&
|
|
git cherry-pick - &&
|
|
echo content >expect &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'cherry-pick "-" is meaningless without checkout' '
|
|
test_create_repo afresh &&
|
|
(
|
|
cd afresh &&
|
|
test_commit one &&
|
|
test_commit two &&
|
|
test_commit three &&
|
|
test_must_fail git cherry-pick -
|
|
)
|
|
'
|
|
|
|
test_expect_success 'cherry-pick "-" works with arguments' '
|
|
git checkout -b side-branch &&
|
|
test_commit change actual change &&
|
|
git checkout main &&
|
|
git cherry-pick -s - &&
|
|
echo "Signed-off-by: C O Mitter <committer@example.com>" >expect &&
|
|
git cat-file commit HEAD | grep ^Signed-off-by: >signoff &&
|
|
test_cmp expect signoff &&
|
|
echo change >expect &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'cherry-pick works with dirty renamed file' '
|
|
test_commit to-rename &&
|
|
git checkout -b unrelated &&
|
|
test_commit unrelated &&
|
|
git checkout @{-1} &&
|
|
git mv to-rename.t renamed &&
|
|
test_tick &&
|
|
git commit -m renamed &&
|
|
echo modified >renamed &&
|
|
git cherry-pick refs/heads/unrelated &&
|
|
test $(git rev-parse :0:renamed) = $(git rev-parse HEAD~2:to-rename.t) &&
|
|
grep -q "^modified$" renamed
|
|
'
|
|
|
|
test_expect_success 'advice from failed revert' '
|
|
test_commit --no-tag "add dream" dream dream &&
|
|
dream_oid=$(git rev-parse --short HEAD) &&
|
|
cat <<-EOF >expected &&
|
|
error: could not revert $dream_oid... add dream
|
|
hint: After resolving the conflicts, mark them with
|
|
hint: "git add/rm <pathspec>", then run
|
|
hint: "git revert --continue".
|
|
hint: You can instead skip this commit with "git revert --skip".
|
|
hint: To abort and get back to the state before "git revert",
|
|
hint: run "git revert --abort".
|
|
EOF
|
|
test_commit --append --no-tag "double-add dream" dream dream &&
|
|
test_must_fail git revert HEAD^ 2>actual &&
|
|
test_cmp expected actual
|
|
'
|
|
test_done
|