mirror of
https://github.com/git/git
synced 2024-11-05 18:59:29 +00:00
03267e8656
The read_cache() in prepare_to_commit() would end up clobbering the pointer we had for a previously populated "the_index.cache_tree" in the very common case of "git commit" stressed by e.g. the tests being changed here. We'd populate "the_index.cache_tree" by calling "update_main_cache_tree" in prepare_index(), but would not end up with a "fully prepared" index. What constitutes an existing index is clearly overly fuzzy, here we'll check "active_nr" (aka "the_index.cache_nr"), but our "the_index.cache_tree" might have been malloc()'d already. Thus the code added in11c8a74a64(commit: write cache-tree data when writing index anyway, 2011-12-06) would end up allocating the "cache_tree", and would interact here with code added in7168624c35(Do not generate full commit log message if it is not going to be used, 2007-11-28). The result was a very common memory leak. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Taylor Blau <me@ttaylorr.com>
73 lines
2 KiB
Bash
Executable file
73 lines
2 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='git merge --signoff
|
|
|
|
This test runs git merge --signoff and makes sure that it works.
|
|
'
|
|
|
|
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
|
|
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
# Setup test files
|
|
test_setup() {
|
|
# Expected commit message after merge --signoff
|
|
cat >expected-signed <<EOF &&
|
|
Merge branch 'main' into other-branch
|
|
|
|
Signed-off-by: $(git var GIT_COMMITTER_IDENT | sed -e "s/>.*/>/")
|
|
EOF
|
|
|
|
# Expected commit message after merge without --signoff (or with --no-signoff)
|
|
cat >expected-unsigned <<EOF &&
|
|
Merge branch 'main' into other-branch
|
|
EOF
|
|
|
|
# Initial commit and feature branch to merge main into it.
|
|
git commit --allow-empty -m "Initial empty commit" &&
|
|
git checkout -b other-branch &&
|
|
test_commit other-branch file1 1
|
|
}
|
|
|
|
# Setup repository, files & feature branch
|
|
# This step must be run if You want to test 2,3 or 4
|
|
# Order of 2,3,4 is not important, but 1 must be run before
|
|
# For example `-r 1,4` or `-r 1,4,2 -v` etc
|
|
# But not `-r 2` or `-r 4,3,2,1`
|
|
test_expect_success 'setup' '
|
|
test_setup
|
|
'
|
|
|
|
# Test with --signoff flag
|
|
test_expect_success 'git merge --signoff adds a sign-off line' '
|
|
git checkout main &&
|
|
test_commit main-branch-2 file2 2 &&
|
|
git checkout other-branch &&
|
|
git merge main --signoff --no-edit &&
|
|
git cat-file commit HEAD | sed -e "1,/^\$/d" >actual &&
|
|
test_cmp expected-signed actual
|
|
'
|
|
|
|
# Test without --signoff flag
|
|
test_expect_success 'git merge does not add a sign-off line' '
|
|
git checkout main &&
|
|
test_commit main-branch-3 file3 3 &&
|
|
git checkout other-branch &&
|
|
git merge main --no-edit &&
|
|
git cat-file commit HEAD | sed -e "1,/^\$/d" >actual &&
|
|
test_cmp expected-unsigned actual
|
|
'
|
|
|
|
# Test for --no-signoff flag
|
|
test_expect_success 'git merge --no-signoff flag cancels --signoff flag' '
|
|
git checkout main &&
|
|
test_commit main-branch-4 file4 4 &&
|
|
git checkout other-branch &&
|
|
git merge main --no-edit --signoff --no-signoff &&
|
|
git cat-file commit HEAD | sed -e "1,/^\$/d" >actual &&
|
|
test_cmp expected-unsigned actual
|
|
'
|
|
|
|
test_done
|