mirror of
https://github.com/git/git
synced 2024-11-05 18:59:29 +00:00
c65d18cb52
Fix a memory leak that's been with us since this code was added inca02465b41(push: use remote.$name.push as a refmap, 2013-12-03). The "remote = remote_get(...)" added in the same commit would seem to leak based only on the context here, but that function is a wrapper for sticking the remotes we fetch into "the_repository->remote_state". Seefd3cb0501e(remote: move static variables into per-repository struct, 2021-11-17) for the addition of code in repository.c that free's the "remote" allocated here. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
57 lines
1.4 KiB
Bash
Executable file
57 lines
1.4 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='check receive input limits'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
# Let's run tests with different unpack limits: 1 and 10000
|
|
# When the limit is 1, `git receive-pack` will call `git index-pack`.
|
|
# When the limit is 10000, `git receive-pack` will call `git unpack-objects`.
|
|
|
|
test_pack_input_limit () {
|
|
case "$1" in
|
|
index) unpack_limit=1 ;;
|
|
unpack) unpack_limit=10000 ;;
|
|
esac
|
|
|
|
test_expect_success 'prepare destination repository' '
|
|
rm -fr dest &&
|
|
git --bare init dest
|
|
'
|
|
|
|
test_expect_success "set unpacklimit to $unpack_limit" '
|
|
git --git-dir=dest config receive.unpacklimit "$unpack_limit"
|
|
'
|
|
|
|
test_expect_success 'setting receive.maxInputSize to 512 rejects push' '
|
|
git --git-dir=dest config receive.maxInputSize 512 &&
|
|
test_must_fail git push dest HEAD
|
|
'
|
|
|
|
test_expect_success 'bumping limit to 4k allows push' '
|
|
git --git-dir=dest config receive.maxInputSize 4k &&
|
|
git push dest HEAD
|
|
'
|
|
|
|
test_expect_success 'prepare destination repository (again)' '
|
|
rm -fr dest &&
|
|
git --bare init dest
|
|
'
|
|
|
|
test_expect_success 'lifting the limit allows push' '
|
|
git --git-dir=dest config receive.maxInputSize 0 &&
|
|
git push dest HEAD
|
|
'
|
|
}
|
|
|
|
test_expect_success "create known-size (1024 bytes) commit" '
|
|
test-tool genrandom foo 1024 >one-k &&
|
|
git add one-k &&
|
|
test_commit one-k
|
|
'
|
|
|
|
test_pack_input_limit index
|
|
test_pack_input_limit unpack
|
|
|
|
test_done
|