mirror of
https://github.com/git/git
synced 2024-11-05 18:59:29 +00:00
3e3b9321ca
Mark those remaining tests that pass when run under SANITIZE=leak with TEST_PASSES_SANITIZE_LEAK=true, these were either omitted inf346fcb62a(Merge branch 'ab/mark-leak-free-tests-even-more', 2021-12-15) and5a4f8381b6(Merge branch 'ab/mark-leak-free-tests', 2021-10-25), or have had their memory leaks fixed since then. With this change there's now a a one-to-one mapping between those tests that we have opted-in via "TEST_PASSES_SANITIZE_LEAK=true", and those that pass with the new "check" mode: GIT_TEST_PASSING_SANITIZE_LEAK=check \ GIT_TEST_SANITIZE_LEAK_LOG=true \ make test SANITIZE=leak Note that the "GIT_TEST_SANITIZE_LEAK_LOG=true" is needed due to the edge cases noted in a preceding commit, i.e. in some cases we'd pass the test itself, but still have outstanding leaks due to ignored exit codes. The "GIT_TEST_SANITIZE_LEAK_LOG=true" corrects for that, we're only marking those tests as passing that really don't have any leaks, whether that was reflected in their exit code or not. Note that the change here to "t9100-git-svn-basic.sh" is marking that test as passing under SANITIZE=leak, we're removing a "TEST_FAILS_SANITIZE_LEAK=true" line, not "TEST_PASSES_SANITIZE_LEAK=true". See7a98d9ab00(revisions API: have release_revisions() release "cmdline", 2022-04-13) for the introduction of that t/lib-git-svn.sh-specific variable. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
215 lines
6.2 KiB
Bash
Executable file
215 lines
6.2 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
# This test can give false success if your machine is sufficiently
|
|
# slow or all trials happened to happen on second boundaries.
|
|
|
|
test_description='racy split index'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'setup' '
|
|
# Only split the index when the test explicitly says so.
|
|
sane_unset GIT_TEST_SPLIT_INDEX &&
|
|
git config splitIndex.maxPercentChange 100 &&
|
|
|
|
echo "cached content" >racy-file &&
|
|
git add racy-file &&
|
|
git commit -m initial &&
|
|
|
|
echo something >other-file &&
|
|
# No raciness with this file.
|
|
test-tool chmtime =-20 other-file &&
|
|
|
|
echo "+cached content" >expect
|
|
'
|
|
|
|
check_cached_diff () {
|
|
git diff-index --patch --cached $EMPTY_TREE racy-file >diff &&
|
|
tail -1 diff >actual &&
|
|
test_cmp expect actual
|
|
}
|
|
|
|
trials="0 1 2 3 4"
|
|
for trial in $trials
|
|
do
|
|
test_expect_success "split the index while adding a racily clean file #$trial" '
|
|
rm -f .git/index .git/sharedindex.* &&
|
|
|
|
# The next three commands must be run within the same
|
|
# second (so both writes to racy-file result in the same
|
|
# mtime) to create the interesting racy situation.
|
|
echo "cached content" >racy-file &&
|
|
|
|
# Update and split the index. The cache entry of
|
|
# racy-file will be stored only in the shared index.
|
|
git update-index --split-index --add racy-file &&
|
|
|
|
# File size must stay the same.
|
|
echo "dirty worktree" >racy-file &&
|
|
|
|
# Subsequent git commands should notice that racy-file
|
|
# and the split index have the same mtime, and check
|
|
# the content of the file to see if it is actually
|
|
# clean.
|
|
check_cached_diff
|
|
'
|
|
done
|
|
|
|
for trial in $trials
|
|
do
|
|
test_expect_success "add a racily clean file to an already split index #$trial" '
|
|
rm -f .git/index .git/sharedindex.* &&
|
|
|
|
git update-index --split-index &&
|
|
|
|
# The next three commands must be run within the same
|
|
# second.
|
|
echo "cached content" >racy-file &&
|
|
|
|
# Update the split index. The cache entry of racy-file
|
|
# will be stored only in the split index.
|
|
git update-index --add racy-file &&
|
|
|
|
# File size must stay the same.
|
|
echo "dirty worktree" >racy-file &&
|
|
|
|
# Subsequent git commands should notice that racy-file
|
|
# and the split index have the same mtime, and check
|
|
# the content of the file to see if it is actually
|
|
# clean.
|
|
check_cached_diff
|
|
'
|
|
done
|
|
|
|
for trial in $trials
|
|
do
|
|
test_expect_success "split the index when the index contains a racily clean cache entry #$trial" '
|
|
rm -f .git/index .git/sharedindex.* &&
|
|
|
|
# The next three commands must be run within the same
|
|
# second.
|
|
echo "cached content" >racy-file &&
|
|
|
|
git update-index --add racy-file &&
|
|
|
|
# File size must stay the same.
|
|
echo "dirty worktree" >racy-file &&
|
|
|
|
# Now wait a bit to ensure that the split index written
|
|
# below will get a more recent mtime than racy-file.
|
|
sleep 1 &&
|
|
|
|
# Update and split the index when the index contains
|
|
# the racily clean cache entry of racy-file.
|
|
# A corresponding replacement cache entry with smudged
|
|
# stat data should be added to the new split index.
|
|
git update-index --split-index --add other-file &&
|
|
|
|
# Subsequent git commands should notice the smudged
|
|
# stat data in the replacement cache entry and that it
|
|
# doesnt match with the file the worktree.
|
|
check_cached_diff
|
|
'
|
|
done
|
|
|
|
for trial in $trials
|
|
do
|
|
test_expect_success "update the split index when it contains a new racily clean cache entry #$trial" '
|
|
rm -f .git/index .git/sharedindex.* &&
|
|
|
|
git update-index --split-index &&
|
|
|
|
# The next three commands must be run within the same
|
|
# second.
|
|
echo "cached content" >racy-file &&
|
|
|
|
# Update the split index. The cache entry of racy-file
|
|
# will be stored only in the split index.
|
|
git update-index --add racy-file &&
|
|
|
|
# File size must stay the same.
|
|
echo "dirty worktree" >racy-file &&
|
|
|
|
# Now wait a bit to ensure that the split index written
|
|
# below will get a more recent mtime than racy-file.
|
|
sleep 1 &&
|
|
|
|
# Update the split index when the racily clean cache
|
|
# entry of racy-file is only stored in the split index.
|
|
# An updated cache entry with smudged stat data should
|
|
# be added to the new split index.
|
|
git update-index --add other-file &&
|
|
|
|
# Subsequent git commands should notice the smudged
|
|
# stat data.
|
|
check_cached_diff
|
|
'
|
|
done
|
|
|
|
for trial in $trials
|
|
do
|
|
test_expect_success "update the split index when a racily clean cache entry is stored only in the shared index #$trial" '
|
|
rm -f .git/index .git/sharedindex.* &&
|
|
|
|
# The next three commands must be run within the same
|
|
# second.
|
|
echo "cached content" >racy-file &&
|
|
|
|
# Update and split the index. The cache entry of
|
|
# racy-file will be stored only in the shared index.
|
|
git update-index --split-index --add racy-file &&
|
|
|
|
# File size must stay the same.
|
|
echo "dirty worktree" >racy-file &&
|
|
|
|
# Now wait a bit to ensure that the split index written
|
|
# below will get a more recent mtime than racy-file.
|
|
sleep 1 &&
|
|
|
|
# Update the split index when the racily clean cache
|
|
# entry of racy-file is only stored in the shared index.
|
|
# A corresponding replacement cache entry with smudged
|
|
# stat data should be added to the new split index.
|
|
git update-index --add other-file &&
|
|
|
|
# Subsequent git commands should notice the smudged
|
|
# stat data.
|
|
check_cached_diff
|
|
'
|
|
done
|
|
|
|
for trial in $trials
|
|
do
|
|
test_expect_success "update the split index after unpack trees() copied a racily clean cache entry from the shared index #$trial" '
|
|
rm -f .git/index .git/sharedindex.* &&
|
|
|
|
# The next three commands must be run within the same
|
|
# second.
|
|
echo "cached content" >racy-file &&
|
|
|
|
# Update and split the index. The cache entry of
|
|
# racy-file will be stored only in the shared index.
|
|
git update-index --split-index --add racy-file &&
|
|
|
|
# File size must stay the same.
|
|
echo "dirty worktree" >racy-file &&
|
|
|
|
# Now wait a bit to ensure that the split index written
|
|
# below will get a more recent mtime than racy-file.
|
|
sleep 1 &&
|
|
|
|
# Update the split index after unpack_trees() copied the
|
|
# racily clean cache entry of racy-file from the shared
|
|
# index. A corresponding replacement cache entry
|
|
# with smudged stat data should be added to the new
|
|
# split index.
|
|
git read-tree -m HEAD &&
|
|
|
|
# Subsequent git commands should notice the smudged
|
|
# stat data.
|
|
check_cached_diff
|
|
'
|
|
done
|
|
|
|
test_done
|