mirror of
https://github.com/git/git
synced 2024-08-27 19:49:21 +00:00
![Johannes Schindelin](/assets/img/avatar_default.png)
Use 'test_atexit' to run cleanup commands to stop 'p4d' at the end of the test script or upon interrupt or failure, as it is shorter, simpler, and more robust than registering such cleanup commands in the trap on EXIT in the test scripts. Note that one of the test scripts, 't9801-git-p4-branch.sh', stops and then re-starts 'p4d' twice in the middle of the script; take care that the cleanup functions to stop 'p4d' are only registered once. Note also that 'git p4' tests invoke different functions in the trap on EXIT ('cleanup') and in the last test before 'test_done' ('kill_p4d'). Register both of these functions with 'test_atexit' for now, and a a later patch in this series will then clean up the redundancy. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
100 lines
1.8 KiB
Bash
Executable file
100 lines
1.8 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='git p4 with server triggers'
|
|
|
|
. ./lib-git-p4.sh
|
|
|
|
test_expect_success 'start p4d' '
|
|
start_p4d
|
|
'
|
|
|
|
test_expect_success 'init depot' '
|
|
(
|
|
cd "$cli" &&
|
|
echo file1 >file1 &&
|
|
p4 add file1 &&
|
|
p4 submit -d "change 1" &&
|
|
echo file2 >file2 &&
|
|
p4 add file2 &&
|
|
p4 submit -d "change 2"
|
|
)
|
|
'
|
|
|
|
test_expect_success 'clone with extra info lines from verbose p4 trigger' '
|
|
test_when_finished cleanup_git &&
|
|
(
|
|
p4 triggers -i <<-EOF
|
|
Triggers: p4triggertest-command command pre-user-change "echo verbose trigger"
|
|
EOF
|
|
) &&
|
|
(
|
|
p4 change -o | grep -s "verbose trigger"
|
|
) &&
|
|
git p4 clone --dest="$git" //depot/@all &&
|
|
(
|
|
p4 triggers -i <<-EOF
|
|
Triggers:
|
|
EOF
|
|
)
|
|
'
|
|
|
|
test_expect_success 'import with extra info lines from verbose p4 trigger' '
|
|
test_when_finished cleanup_git &&
|
|
(
|
|
cd "$cli" &&
|
|
echo file3 >file3 &&
|
|
p4 add file3 &&
|
|
p4 submit -d "change 3"
|
|
) &&
|
|
(
|
|
p4 triggers -i <<-EOF
|
|
Triggers: p4triggertest-command command pre-user-describe "echo verbose trigger"
|
|
EOF
|
|
) &&
|
|
(
|
|
p4 describe 1 | grep -s "verbose trigger"
|
|
) &&
|
|
git p4 clone --dest="$git" //depot/@all &&
|
|
(
|
|
cd "$git" &&
|
|
git p4 sync
|
|
)&&
|
|
(
|
|
p4 triggers -i <<-EOF
|
|
Triggers:
|
|
EOF
|
|
)
|
|
'
|
|
|
|
test_expect_success 'submit description with extra info lines from verbose p4 change trigger' '
|
|
test_when_finished cleanup_git &&
|
|
(
|
|
p4 triggers -i <<-EOF
|
|
Triggers: p4triggertest-command command pre-user-change "echo verbose trigger"
|
|
EOF
|
|
) &&
|
|
(
|
|
p4 change -o | grep -s "verbose trigger"
|
|
) &&
|
|
git p4 clone --dest="$git" //depot &&
|
|
(
|
|
cd "$git" &&
|
|
git config git-p4.skipSubmitEdit true &&
|
|
echo file4 >file4 &&
|
|
git add file4 &&
|
|
git commit -m file4 &&
|
|
git p4 submit
|
|
) &&
|
|
(
|
|
p4 triggers -i <<-EOF
|
|
Triggers:
|
|
EOF
|
|
) &&
|
|
(
|
|
cd "$cli" &&
|
|
test_path_is_file file4
|
|
)
|
|
'
|
|
|
|
test_done
|