mirror of
https://github.com/git/git
synced 2024-08-27 19:49:21 +00:00
![Jeff King](/assets/img/avatar_default.png)
The iteration order of a hashmap is undefined, and may depend on things like the exact set of items added, or the table has been grown or shrunk. In the case of an oidmap, it even depends on endianness, because we take the oid hash by casting sha1 bytes directly into an unsigned int. Let's sort the test-tool output from any hash iterators. In the case of t0011, this is just future-proofing. But for t0016, it actually fixes a reported failure on the big-endian s390 and nonstop ports. I didn't bother to teach the helper functions to optionally sort output. They are short enough that it's simpler to just repeat them inline for the iteration tests than it is to add a --sort option. Reported-by: Randall S. Becker <rsbecker@nexbridge.com> Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
111 lines
1.4 KiB
Bash
Executable file
111 lines
1.4 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='test oidmap'
|
|
. ./test-lib.sh
|
|
|
|
# This purposefully is very similar to t0011-hashmap.sh
|
|
|
|
test_oidmap () {
|
|
echo "$1" | test-tool oidmap $3 >actual &&
|
|
echo "$2" >expect &&
|
|
test_cmp expect actual
|
|
}
|
|
|
|
|
|
test_expect_success 'setup' '
|
|
|
|
test_commit one &&
|
|
test_commit two &&
|
|
test_commit three &&
|
|
test_commit four
|
|
|
|
'
|
|
|
|
test_expect_success 'put' '
|
|
|
|
test_oidmap "put one 1
|
|
put two 2
|
|
put invalidOid 4
|
|
put three 3" "NULL
|
|
NULL
|
|
Unknown oid: invalidOid
|
|
NULL"
|
|
|
|
'
|
|
|
|
test_expect_success 'replace' '
|
|
|
|
test_oidmap "put one 1
|
|
put two 2
|
|
put three 3
|
|
put invalidOid 4
|
|
put two deux
|
|
put one un" "NULL
|
|
NULL
|
|
NULL
|
|
Unknown oid: invalidOid
|
|
2
|
|
1"
|
|
|
|
'
|
|
|
|
test_expect_success 'get' '
|
|
|
|
test_oidmap "put one 1
|
|
put two 2
|
|
put three 3
|
|
get two
|
|
get four
|
|
get invalidOid
|
|
get one" "NULL
|
|
NULL
|
|
NULL
|
|
2
|
|
NULL
|
|
Unknown oid: invalidOid
|
|
1"
|
|
|
|
'
|
|
|
|
test_expect_success 'remove' '
|
|
|
|
test_oidmap "put one 1
|
|
put two 2
|
|
put three 3
|
|
remove one
|
|
remove two
|
|
remove invalidOid
|
|
remove four" "NULL
|
|
NULL
|
|
NULL
|
|
1
|
|
2
|
|
Unknown oid: invalidOid
|
|
NULL"
|
|
|
|
'
|
|
|
|
test_expect_success 'iterate' '
|
|
test-tool oidmap >actual.raw <<-\EOF &&
|
|
put one 1
|
|
put two 2
|
|
put three 3
|
|
iterate
|
|
EOF
|
|
|
|
# sort "expect" too so we do not rely on the order of particular oids
|
|
sort >expect <<-EOF &&
|
|
NULL
|
|
NULL
|
|
NULL
|
|
$(git rev-parse one) 1
|
|
$(git rev-parse two) 2
|
|
$(git rev-parse three) 3
|
|
EOF
|
|
|
|
sort <actual.raw >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_done
|