mirror of
https://github.com/git/git
synced 2024-08-27 11:39:22 +00:00
a75dc71f37
Some of the command line options in `cmd_pack_refs()` require us to allocate memory. This memory is never released and thus leaking, but we paper over this leak by declaring the respective variables as `static` function-level variables, which is somewhat awkward. Refactor the code to release the allocated memory and drop the `static` declaration. While at it, remove the useless `flags` variable. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
57 lines
1.8 KiB
C
57 lines
1.8 KiB
C
#include "builtin.h"
|
|
#include "config.h"
|
|
#include "gettext.h"
|
|
#include "parse-options.h"
|
|
#include "refs.h"
|
|
#include "repository.h"
|
|
#include "revision.h"
|
|
|
|
static char const * const pack_refs_usage[] = {
|
|
N_("git pack-refs [--all] [--no-prune] [--include <pattern>] [--exclude <pattern>]"),
|
|
NULL
|
|
};
|
|
|
|
int cmd_pack_refs(int argc, const char **argv, const char *prefix)
|
|
{
|
|
struct ref_exclusions excludes = REF_EXCLUSIONS_INIT;
|
|
struct string_list included_refs = STRING_LIST_INIT_NODUP;
|
|
struct pack_refs_opts pack_refs_opts = {
|
|
.exclusions = &excludes,
|
|
.includes = &included_refs,
|
|
.flags = PACK_REFS_PRUNE,
|
|
};
|
|
struct string_list option_excluded_refs = STRING_LIST_INIT_NODUP;
|
|
struct string_list_item *item;
|
|
int pack_all = 0;
|
|
int ret;
|
|
|
|
struct option opts[] = {
|
|
OPT_BOOL(0, "all", &pack_all, N_("pack everything")),
|
|
OPT_BIT(0, "prune", &pack_refs_opts.flags, N_("prune loose refs (default)"), PACK_REFS_PRUNE),
|
|
OPT_STRING_LIST(0, "include", pack_refs_opts.includes, N_("pattern"),
|
|
N_("references to include")),
|
|
OPT_STRING_LIST(0, "exclude", &option_excluded_refs, N_("pattern"),
|
|
N_("references to exclude")),
|
|
OPT_END(),
|
|
};
|
|
git_config(git_default_config, NULL);
|
|
if (parse_options(argc, argv, prefix, opts, pack_refs_usage, 0))
|
|
usage_with_options(pack_refs_usage, opts);
|
|
|
|
for_each_string_list_item(item, &option_excluded_refs)
|
|
add_ref_exclusion(pack_refs_opts.exclusions, item->string);
|
|
|
|
if (pack_all)
|
|
string_list_append(pack_refs_opts.includes, "*");
|
|
|
|
if (!pack_refs_opts.includes->nr)
|
|
string_list_append(pack_refs_opts.includes, "refs/tags/*");
|
|
|
|
ret = refs_pack_refs(get_main_ref_store(the_repository), &pack_refs_opts);
|
|
|
|
clear_ref_exclusions(&excludes);
|
|
string_list_clear(&included_refs, 0);
|
|
string_list_clear(&option_excluded_refs, 0);
|
|
return ret;
|
|
}
|