mirror of
https://github.com/git/git
synced 2024-11-05 18:59:29 +00:00
a4e7e317f8
Add a new "const struct config_context *ctx" arg to config_fn_t to hold additional information about the config iteration operation. config_context has a "struct key_value_info kvi" member that holds metadata about the config source being read (e.g. what kind of config source it is, the filename, etc). In this series, we're only interested in .kvi, so we could have just used "struct key_value_info" as an arg, but config_context makes it possible to add/adjust members in the future without changing the config_fn_t signature. We could also consider other ways of organizing the args (e.g. moving the config name and value into config_context or key_value_info), but in my experiments, the incremental benefit doesn't justify the added complexity (e.g. a config_fn_t will sometimes invoke another config_fn_t but with a different config value). In subsequent commits, the .kvi member will replace the global "struct config_reader" in config.c, making config iteration a global-free operation. It requires much more work for the machinery to provide meaningful values of .kvi, so for now, merely change the signature and call sites, pass NULL as a placeholder value, and don't rely on the arg in any meaningful way. Most of the changes are performed by contrib/coccinelle/config_fn_ctx.pending.cocci, which, for every config_fn_t: - Modifies the signature to accept "const struct config_context *ctx" - Passes "ctx" to any inner config_fn_t, if needed - Adds UNUSED attributes to "ctx", if needed Most config_fn_t instances are easily identified by seeing if they are called by the various config functions. Most of the remaining ones are manually named in the .cocci patch. Manual cleanups are still needed, but the majority of it is trivial; it's either adjusting config_fn_t that the .cocci patch didn't catch, or adding forward declarations of "struct config_context ctx" to make the signatures make sense. The non-trivial changes are in cases where we are invoking a config_fn_t outside of config machinery, and we now need to decide what value of "ctx" to pass. These cases are: - trace2/tr2_cfg.c:tr2_cfg_set_fl() This is indirectly called by git_config_set() so that the trace2 machinery can notice the new config values and update its settings using the tr2 config parsing function, i.e. tr2_cfg_cb(). - builtin/checkout.c:checkout_main() This calls git_xmerge_config() as a shorthand for parsing a CLI arg. This might be worth refactoring away in the future, since git_xmerge_config() can call git_default_config(), which can do much more than just parsing. Handle them by creating a KVI_INIT macro that initializes "struct key_value_info" to a reasonable default, and use that to construct the "ctx" arg. Signed-off-by: Glen Choo <chooglen@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| test-advise.c | ||
| test-bitmap.c | ||
| test-bloom.c | ||
| test-bundle-uri.c | ||
| test-cache-tree.c | ||
| test-chmtime.c | ||
| test-config.c | ||
| test-crontab.c | ||
| test-csprng.c | ||
| test-ctype.c | ||
| test-date.c | ||
| test-delta.c | ||
| test-dir-iterator.c | ||
| test-drop-caches.c | ||
| test-dump-cache-tree.c | ||
| test-dump-fsmonitor.c | ||
| test-dump-split-index.c | ||
| test-dump-untracked-cache.c | ||
| test-env-helper.c | ||
| test-example-decorate.c | ||
| test-fake-ssh.c | ||
| test-fast-rebase.c | ||
| test-fsmonitor-client.c | ||
| test-genrandom.c | ||
| test-genzeros.c | ||
| test-getcwd.c | ||
| test-hash-speed.c | ||
| test-hash.c | ||
| test-hashmap.c | ||
| test-hexdump.c | ||
| test-index-version.c | ||
| test-json-writer.c | ||
| test-lazy-init-name-hash.c | ||
| test-match-trees.c | ||
| test-mergesort.c | ||
| test-mktemp.c | ||
| test-oid-array.c | ||
| test-oidmap.c | ||
| test-oidtree.c | ||
| test-online-cpus.c | ||
| test-pack-mtimes.c | ||
| test-parse-options.c | ||
| test-parse-pathspec-file.c | ||
| test-partial-clone.c | ||
| test-path-utils.c | ||
| test-pcre2-config.c | ||
| test-pkt-line.c | ||
| test-prio-queue.c | ||
| test-proc-receive.c | ||
| test-progress.c | ||
| test-reach.c | ||
| test-read-cache.c | ||
| test-read-graph.c | ||
| test-read-midx.c | ||
| test-ref-store.c | ||
| test-reftable.c | ||
| test-regex.c | ||
| test-repository.c | ||
| test-revision-walking.c | ||
| test-rot13-filter.c | ||
| test-run-command.c | ||
| test-scrap-cache-tree.c | ||
| test-serve-v2.c | ||
| test-sha1.c | ||
| test-sha1.sh | ||
| test-sha256.c | ||
| test-sigchain.c | ||
| test-simple-ipc.c | ||
| test-strcmp-offset.c | ||
| test-string-list.c | ||
| test-submodule-config.c | ||
| test-submodule-nested-repo-config.c | ||
| test-submodule.c | ||
| test-subprocess.c | ||
| test-tool-utils.h | ||
| test-tool.c | ||
| test-tool.h | ||
| test-trace2.c | ||
| test-urlmatch-normalization.c | ||
| test-userdiff.c | ||
| test-wildmatch.c | ||
| test-windows-named-pipe.c | ||
| test-write-cache.c | ||
| test-xml-encode.c | ||