mirror of
https://github.com/git/git
synced 2024-08-24 18:26:02 +00:00
9081a421a6
The "checkout" command is one of the main sources of leaks in the test
suite, let's fix the common ones by not leaking from the "struct
branch_info".
Doing this is rather straightforward, albeit verbose, we need to
xstrdup() constant strings going into the struct, and free() the ones
we clobber as we go along.
This also means that we can delete previous partial leak fixes in this
area, i.e. the "path_to_free" accounting added by 96ec7b1e70 (Convert
resolve_ref+xstrdup to new resolve_refdup function, 2011-12-13).
There was some discussion about whether "we should retain the "const
char *" here and cast at free() time, or have it be a "char *". Since
this is not a public API with any sort of API boundary let's use
"char *", as is already being done for the "refname" member of the
same struct.
The tests to mark as passing were found with:
rm .prove; GIT_SKIP_TESTS=t0027 prove -j8 --state=save t[0-9]*.sh :: --immediate
# apply & compile this change
prove -j8 --state=failed :: --immediate
I.e. the ones that were newly passing when the --state=failed command
was run. I left out "t3040-subprojects-basic.sh" and
"t4131-apply-fake-ancestor.sh" to to optimization-level related
differences similar to the ones noted in[1], except that these would
be something the current 'linux-leaks' job would run into.
1. https://lore.kernel.org/git/cover-v3-0.6-00000000000-20211022T175227Z-avarab@gmail.com/
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
81 lines
2.1 KiB
Bash
Executable file
81 lines
2.1 KiB
Bash
Executable file
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2008 Deskin Miller
|
|
#
|
|
|
|
test_description='git svn partial-rebuild tests'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./lib-git-svn.sh
|
|
|
|
test_expect_success 'initialize svnrepo' '
|
|
mkdir import &&
|
|
(
|
|
(cd import &&
|
|
mkdir trunk branches tags &&
|
|
(cd trunk &&
|
|
echo foo > foo
|
|
) &&
|
|
svn_cmd import -m "import for git-svn" . "$svnrepo" >/dev/null
|
|
) &&
|
|
rm -rf import &&
|
|
svn_cmd co "$svnrepo"/trunk trunk &&
|
|
(cd trunk &&
|
|
echo bar >> foo &&
|
|
svn_cmd ci -m "updated trunk"
|
|
) &&
|
|
rm -rf trunk
|
|
)
|
|
'
|
|
|
|
test_expect_success 'import into git' '
|
|
git svn init --stdlayout "$svnrepo" &&
|
|
git svn fetch &&
|
|
git checkout remotes/origin/trunk
|
|
'
|
|
|
|
test_expect_success 'git svn branch tests' '
|
|
git svn branch a &&
|
|
base=$(git rev-parse HEAD:) &&
|
|
test $base = $(git rev-parse remotes/origin/a:) &&
|
|
git svn branch -m "created branch b blah" b &&
|
|
test $base = $(git rev-parse remotes/origin/b:) &&
|
|
test_must_fail git branch -m "no branchname" &&
|
|
git svn branch -n c &&
|
|
test_must_fail git rev-parse remotes/origin/c &&
|
|
test_must_fail git svn branch a &&
|
|
git svn branch -t tag1 &&
|
|
test $base = $(git rev-parse remotes/origin/tags/tag1:) &&
|
|
git svn branch --tag tag2 &&
|
|
test $base = $(git rev-parse remotes/origin/tags/tag2:) &&
|
|
git svn tag tag3 &&
|
|
test $base = $(git rev-parse remotes/origin/tags/tag3:) &&
|
|
git svn tag -m "created tag4 foo" tag4 &&
|
|
test $base = $(git rev-parse remotes/origin/tags/tag4:) &&
|
|
test_must_fail git svn tag -m "no tagname" &&
|
|
git svn tag -n tag5 &&
|
|
test_must_fail git rev-parse remotes/origin/tags/tag5 &&
|
|
test_must_fail git svn tag tag1
|
|
'
|
|
|
|
test_expect_success 'branch uses correct svn-remote' '
|
|
(svn_cmd co "$svnrepo" svn &&
|
|
cd svn &&
|
|
mkdir mirror &&
|
|
svn_cmd add mirror &&
|
|
svn_cmd copy trunk mirror/ &&
|
|
svn_cmd copy tags mirror/ &&
|
|
svn_cmd copy branches mirror/ &&
|
|
svn_cmd ci -m "made mirror" ) &&
|
|
rm -rf svn &&
|
|
git svn init -s -R mirror --prefix=mirror/ "$svnrepo"/mirror &&
|
|
git svn fetch -R mirror &&
|
|
git checkout mirror/trunk &&
|
|
base=$(git rev-parse HEAD:) &&
|
|
git svn branch -m "branch in mirror" d &&
|
|
test $base = $(git rev-parse remotes/mirror/d:) &&
|
|
test_must_fail git rev-parse remotes/d
|
|
'
|
|
|
|
test_done
|