mirror of
https://github.com/git/git
synced 2024-08-25 02:35:46 +00:00
![Jeff King](/assets/img/avatar_default.png)
The sha1write function returns an int, but it will always be "0". The failure-prone parts of the function happen in the "flush" callback, which cannot pass an error back to us. So we just end up calling die() during the flush. Let's just drop the return value altogether, as it only confuses callers into thinking that it might be useful. Only one call site actually checked the return value. We can drop that check, since it just led to a die() anyway. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
43 lines
1.1 KiB
C
43 lines
1.1 KiB
C
#ifndef CSUM_FILE_H
|
|
#define CSUM_FILE_H
|
|
|
|
struct progress;
|
|
|
|
/* A SHA1-protected file */
|
|
struct sha1file {
|
|
int fd;
|
|
int check_fd;
|
|
unsigned int offset;
|
|
git_SHA_CTX ctx;
|
|
off_t total;
|
|
struct progress *tp;
|
|
const char *name;
|
|
int do_crc;
|
|
uint32_t crc32;
|
|
unsigned char buffer[8192];
|
|
};
|
|
|
|
/* Checkpoint */
|
|
struct sha1file_checkpoint {
|
|
off_t offset;
|
|
git_SHA_CTX ctx;
|
|
};
|
|
|
|
extern void sha1file_checkpoint(struct sha1file *, struct sha1file_checkpoint *);
|
|
extern int sha1file_truncate(struct sha1file *, struct sha1file_checkpoint *);
|
|
|
|
/* sha1close flags */
|
|
#define CSUM_CLOSE 1
|
|
#define CSUM_FSYNC 2
|
|
|
|
extern struct sha1file *sha1fd(int fd, const char *name);
|
|
extern struct sha1file *sha1fd_check(const char *name);
|
|
extern struct sha1file *sha1fd_throughput(int fd, const char *name, struct progress *tp);
|
|
extern int sha1close(struct sha1file *, unsigned char *, unsigned int);
|
|
extern void sha1write(struct sha1file *, void *, unsigned int);
|
|
extern void sha1flush(struct sha1file *f);
|
|
extern void crc32_begin(struct sha1file *);
|
|
extern uint32_t crc32_end(struct sha1file *);
|
|
|
|
#endif
|