mirror of
https://github.com/git/git
synced 2024-08-27 19:49:21 +00:00
![Andy Whitcroft](/assets/img/avatar_default.png)
We have a number of badly checked read() calls. Often we are expecting read() to read exactly the size we requested or fail, this fails to handle interrupts or short reads. Add a read_in_full() providing those semantics. Otherwise we at a minimum need to check for EINTR and EAGAIN, where this is appropriate use xread(). Signed-off-by: Andy Whitcroft <apw@shadowen.org> Signed-off-by: Junio C Hamano <junkio@cox.net>
114 lines
1.9 KiB
C
114 lines
1.9 KiB
C
#include "cache.h"
|
|
|
|
int read_in_full(int fd, void *buf, size_t count)
|
|
{
|
|
char *p = buf;
|
|
ssize_t total = 0;
|
|
ssize_t loaded = 0;
|
|
|
|
while (count > 0) {
|
|
loaded = xread(fd, p, count);
|
|
if (loaded <= 0) {
|
|
if (total)
|
|
return total;
|
|
else
|
|
return loaded;
|
|
}
|
|
count -= loaded;
|
|
p += loaded;
|
|
total += loaded;
|
|
}
|
|
|
|
return total;
|
|
}
|
|
|
|
void read_or_die(int fd, void *buf, size_t count)
|
|
{
|
|
ssize_t loaded;
|
|
|
|
loaded = read_in_full(fd, buf, count);
|
|
if (loaded == 0)
|
|
die("unexpected end of file");
|
|
else if (loaded < 0)
|
|
die("read error (%s)", strerror(errno));
|
|
}
|
|
|
|
void write_or_die(int fd, const void *buf, size_t count)
|
|
{
|
|
const char *p = buf;
|
|
ssize_t written;
|
|
|
|
while (count > 0) {
|
|
written = xwrite(fd, p, count);
|
|
if (written == 0)
|
|
die("disk full?");
|
|
else if (written < 0) {
|
|
if (errno == EPIPE)
|
|
exit(0);
|
|
die("write error (%s)", strerror(errno));
|
|
}
|
|
count -= written;
|
|
p += written;
|
|
}
|
|
}
|
|
|
|
int write_in_full(int fd, const void *buf, size_t count)
|
|
{
|
|
const char *p = buf;
|
|
ssize_t total = 0;
|
|
ssize_t wcount = 0;
|
|
|
|
while (count > 0) {
|
|
wcount = xwrite(fd, p, count);
|
|
if (wcount <= 0) {
|
|
if (total)
|
|
return total;
|
|
else
|
|
return wcount;
|
|
}
|
|
count -= wcount;
|
|
p += wcount;
|
|
total += wcount;
|
|
}
|
|
|
|
return wcount;
|
|
}
|
|
|
|
int write_or_whine_pipe(int fd, const void *buf, size_t count, const char *msg)
|
|
{
|
|
ssize_t written;
|
|
|
|
written = write_in_full(fd, buf, count);
|
|
if (written == 0) {
|
|
fprintf(stderr, "%s: disk full?\n", msg);
|
|
return 0;
|
|
}
|
|
else if (written < 0) {
|
|
if (errno == EPIPE)
|
|
exit(0);
|
|
fprintf(stderr, "%s: write error (%s)\n",
|
|
msg, strerror(errno));
|
|
return 0;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
int write_or_whine(int fd, const void *buf, size_t count, const char *msg)
|
|
{
|
|
ssize_t written;
|
|
|
|
written = write_in_full(fd, buf, count);
|
|
if (written == 0) {
|
|
fprintf(stderr, "%s: disk full?\n", msg);
|
|
return 0;
|
|
}
|
|
else if (written < 0) {
|
|
fprintf(stderr, "%s: write error (%s)\n",
|
|
msg, strerror(errno));
|
|
return 0;
|
|
}
|
|
|
|
return 1;
|
|
}
|