mirror of
https://github.com/git/git
synced 2024-10-30 14:03:28 +00:00
41ac414ea2
Originally, test_expect_failure was designed to be the opposite
of test_expect_success, but this was a bad decision. Most tests
run a series of commands that leads to the single command that
needs to be tested, like this:
test_expect_{success,failure} 'test title' '
setup1 &&
setup2 &&
setup3 &&
what is to be tested
'
And expecting a failure exit from the whole sequence misses the
point of writing tests. Your setup$N that are supposed to
succeed may have failed without even reaching what you are
trying to test. The only valid use of test_expect_failure is to
check a trivial single command that is expected to fail, which
is a minority in tests of Porcelain-ish commands.
This large-ish patch rewrites all uses of test_expect_failure to
use test_expect_success and rewrites the condition of what is
tested, like this:
test_expect_success 'test title' '
setup1 &&
setup2 &&
setup3 &&
! this command should fail
'
test_expect_failure is redefined to serve as a reminder that
that test *should* succeed but due to a known breakage in git it
currently does not pass. So if git-foo command should create a
file 'bar' but you discovered a bug that it doesn't, you can
write a test like this:
test_expect_failure 'git-foo should create bar' '
rm -f bar &&
git foo &&
test -f bar
'
This construct acts similar to test_expect_success, but instead
of reporting "ok/FAIL" like test_expect_success does, the
outcome is reported as "FIXED/still broken".
Signed-off-by: Junio C Hamano <gitster@pobox.com>
212 lines
6.4 KiB
Bash
Executable file
212 lines
6.4 KiB
Bash
Executable file
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2007 Andy Parkins
|
|
#
|
|
|
|
test_description='for-each-ref test'
|
|
|
|
. ./test-lib.sh
|
|
|
|
# Mon Jul 3 15:18:43 2006 +0000
|
|
datestamp=1151939923
|
|
setdate_and_increment () {
|
|
GIT_COMMITTER_DATE="$datestamp +0200"
|
|
datestamp=$(expr "$datestamp" + 1)
|
|
GIT_AUTHOR_DATE="$datestamp +0200"
|
|
datestamp=$(expr "$datestamp" + 1)
|
|
export GIT_COMMITTER_DATE GIT_AUTHOR_DATE
|
|
}
|
|
|
|
test_expect_success 'Create sample commit with known timestamp' '
|
|
setdate_and_increment &&
|
|
echo "Using $datestamp" > one &&
|
|
git add one &&
|
|
git commit -m "Initial" &&
|
|
setdate_and_increment &&
|
|
git tag -a -m "Tagging at $datestamp" testtag
|
|
'
|
|
|
|
test_expect_success 'Check atom names are valid' '
|
|
bad=
|
|
for token in \
|
|
refname objecttype objectsize objectname tree parent \
|
|
numparent object type author authorname authoremail \
|
|
authordate committer committername committeremail \
|
|
committerdate tag tagger taggername taggeremail \
|
|
taggerdate creator creatordate subject body contents
|
|
do
|
|
git for-each-ref --format="$token=%($token)" refs/heads || {
|
|
bad=$token
|
|
break
|
|
}
|
|
done
|
|
test -z "$bad"
|
|
'
|
|
|
|
test_expect_success 'Check invalid atoms names are errors' '
|
|
! git-for-each-ref --format="%(INVALID)" refs/heads
|
|
'
|
|
|
|
test_expect_success 'Check format specifiers are ignored in naming date atoms' '
|
|
git-for-each-ref --format="%(authordate)" refs/heads &&
|
|
git-for-each-ref --format="%(authordate:default) %(authordate)" refs/heads &&
|
|
git-for-each-ref --format="%(authordate) %(authordate:default)" refs/heads &&
|
|
git-for-each-ref --format="%(authordate:default) %(authordate:default)" refs/heads
|
|
'
|
|
|
|
test_expect_success 'Check valid format specifiers for date fields' '
|
|
git-for-each-ref --format="%(authordate:default)" refs/heads &&
|
|
git-for-each-ref --format="%(authordate:relative)" refs/heads &&
|
|
git-for-each-ref --format="%(authordate:short)" refs/heads &&
|
|
git-for-each-ref --format="%(authordate:local)" refs/heads &&
|
|
git-for-each-ref --format="%(authordate:iso8601)" refs/heads &&
|
|
git-for-each-ref --format="%(authordate:rfc2822)" refs/heads
|
|
'
|
|
|
|
test_expect_success 'Check invalid format specifiers are errors' '
|
|
! git-for-each-ref --format="%(authordate:INVALID)" refs/heads
|
|
'
|
|
|
|
cat >expected <<\EOF
|
|
'refs/heads/master' 'Mon Jul 3 17:18:43 2006 +0200' 'Mon Jul 3 17:18:44 2006 +0200'
|
|
'refs/tags/testtag' 'Mon Jul 3 17:18:45 2006 +0200'
|
|
EOF
|
|
|
|
test_expect_success 'Check unformatted date fields output' '
|
|
(git for-each-ref --shell --format="%(refname) %(committerdate) %(authordate)" refs/heads &&
|
|
git for-each-ref --shell --format="%(refname) %(taggerdate)" refs/tags) >actual &&
|
|
git diff expected actual
|
|
'
|
|
|
|
test_expect_success 'Check format "default" formatted date fields output' '
|
|
f=default &&
|
|
(git for-each-ref --shell --format="%(refname) %(committerdate:$f) %(authordate:$f)" refs/heads &&
|
|
git for-each-ref --shell --format="%(refname) %(taggerdate:$f)" refs/tags) >actual &&
|
|
git diff expected actual
|
|
'
|
|
|
|
# Don't know how to do relative check because I can't know when this script
|
|
# is going to be run and can't fake the current time to git, and hence can't
|
|
# provide expected output. Instead, I'll just make sure that "relative"
|
|
# doesn't exit in error
|
|
#
|
|
#cat >expected <<\EOF
|
|
#
|
|
#EOF
|
|
#
|
|
test_expect_success 'Check format "relative" date fields output' '
|
|
f=relative &&
|
|
(git for-each-ref --shell --format="%(refname) %(committerdate:$f) %(authordate:$f)" refs/heads &&
|
|
git for-each-ref --shell --format="%(refname) %(taggerdate:$f)" refs/tags) >actual
|
|
'
|
|
|
|
cat >expected <<\EOF
|
|
'refs/heads/master' '2006-07-03' '2006-07-03'
|
|
'refs/tags/testtag' '2006-07-03'
|
|
EOF
|
|
|
|
test_expect_success 'Check format "short" date fields output' '
|
|
f=short &&
|
|
(git for-each-ref --shell --format="%(refname) %(committerdate:$f) %(authordate:$f)" refs/heads &&
|
|
git for-each-ref --shell --format="%(refname) %(taggerdate:$f)" refs/tags) >actual &&
|
|
git diff expected actual
|
|
'
|
|
|
|
cat >expected <<\EOF
|
|
'refs/heads/master' 'Mon Jul 3 15:18:43 2006' 'Mon Jul 3 15:18:44 2006'
|
|
'refs/tags/testtag' 'Mon Jul 3 15:18:45 2006'
|
|
EOF
|
|
|
|
test_expect_success 'Check format "local" date fields output' '
|
|
f=local &&
|
|
(git for-each-ref --shell --format="%(refname) %(committerdate:$f) %(authordate:$f)" refs/heads &&
|
|
git for-each-ref --shell --format="%(refname) %(taggerdate:$f)" refs/tags) >actual &&
|
|
git diff expected actual
|
|
'
|
|
|
|
cat >expected <<\EOF
|
|
'refs/heads/master' '2006-07-03 17:18:43 +0200' '2006-07-03 17:18:44 +0200'
|
|
'refs/tags/testtag' '2006-07-03 17:18:45 +0200'
|
|
EOF
|
|
|
|
test_expect_success 'Check format "iso8601" date fields output' '
|
|
f=iso8601 &&
|
|
(git for-each-ref --shell --format="%(refname) %(committerdate:$f) %(authordate:$f)" refs/heads &&
|
|
git for-each-ref --shell --format="%(refname) %(taggerdate:$f)" refs/tags) >actual &&
|
|
git diff expected actual
|
|
'
|
|
|
|
cat >expected <<\EOF
|
|
'refs/heads/master' 'Mon, 3 Jul 2006 17:18:43 +0200' 'Mon, 3 Jul 2006 17:18:44 +0200'
|
|
'refs/tags/testtag' 'Mon, 3 Jul 2006 17:18:45 +0200'
|
|
EOF
|
|
|
|
test_expect_success 'Check format "rfc2822" date fields output' '
|
|
f=rfc2822 &&
|
|
(git for-each-ref --shell --format="%(refname) %(committerdate:$f) %(authordate:$f)" refs/heads &&
|
|
git for-each-ref --shell --format="%(refname) %(taggerdate:$f)" refs/tags) >actual &&
|
|
git diff expected actual
|
|
'
|
|
|
|
cat >expected <<\EOF
|
|
refs/heads/master
|
|
refs/tags/testtag
|
|
EOF
|
|
|
|
test_expect_success 'Verify ascending sort' '
|
|
git-for-each-ref --format="%(refname)" --sort=refname >actual &&
|
|
git diff expected actual
|
|
'
|
|
|
|
|
|
cat >expected <<\EOF
|
|
refs/tags/testtag
|
|
refs/heads/master
|
|
EOF
|
|
|
|
test_expect_success 'Verify descending sort' '
|
|
git-for-each-ref --format="%(refname)" --sort=-refname >actual &&
|
|
git diff expected actual
|
|
'
|
|
|
|
cat >expected <<\EOF
|
|
'refs/heads/master'
|
|
'refs/tags/testtag'
|
|
EOF
|
|
|
|
test_expect_success 'Quoting style: shell' '
|
|
git for-each-ref --shell --format="%(refname)" >actual &&
|
|
git diff expected actual
|
|
'
|
|
|
|
test_expect_success 'Quoting style: perl' '
|
|
git for-each-ref --perl --format="%(refname)" >actual &&
|
|
git diff expected actual
|
|
'
|
|
|
|
test_expect_success 'Quoting style: python' '
|
|
git for-each-ref --python --format="%(refname)" >actual &&
|
|
git diff expected actual
|
|
'
|
|
|
|
cat >expected <<\EOF
|
|
"refs/heads/master"
|
|
"refs/tags/testtag"
|
|
EOF
|
|
|
|
test_expect_success 'Quoting style: tcl' '
|
|
git for-each-ref --tcl --format="%(refname)" >actual &&
|
|
git diff expected actual
|
|
'
|
|
|
|
for i in "--perl --shell" "-s --python" "--python --tcl" "--tcl --perl"; do
|
|
test_expect_success "more than one quoting style: $i" "
|
|
git for-each-ref $i 2>&1 | (read line &&
|
|
case \$line in
|
|
\"error: more than one quoting style\"*) : happy;;
|
|
*) false
|
|
esac)
|
|
"
|
|
done
|
|
|
|
test_done
|