mirror of
https://github.com/git/git
synced 2024-11-05 18:59:29 +00:00
7a98d9ab00
Extend the the release_revisions() function so that it frees the "cmdline" in the "struct rev_info". This in combination with a preceding change to free "commits" and "mailmap" means that we can whitelist another test under "TEST_PASSES_SANITIZE_LEAK=true". There was a proposal in [1] to do away with xstrdup()-ing this add_rev_cmdline(), perhaps that would be worthwhile, but for now let's just free() it. We could also make that a "char *" in "struct rev_cmdline_entry" itself, but since we own it let's expose it as a constant to outside callers. I proposed that in [2] but have since changed my mind. See14d30cdfc0(ref-filter: fix memory leak in `free_array_item()`, 2019-07-10),c514c62a4f(checkout: fix leak of non-existent branch names, 2020-08-14) and other log history hits for "free((char *)" for prior art. This includes the tests we had false-positive passes on before my6798b08e84(perl Git.pm: don't ignore signalled failure in _cmd_close(), 2022-02-01), now they pass for real. Since there are 66 tests matching t/t[0-9]*git-svn*.sh it's easier to list those that don't pass than to touch most of those 66. So let's introduce a "TEST_FAILS_SANITIZE_LEAK=true", which if set in the tests won't cause lib-git-svn.sh to set "TEST_PASSES_SANITIZE_LEAK=true. This change also marks all the tests that we removed "TEST_FAILS_SANITIZE_LEAK=true" from in an earlier commit due to removing the UNLEAK() from cmd_format_patch(), we can now assert that its API use doesn't leak any "struct rev_info" memory. This change also made commit "t5503-tagfollow.sh" pass on current master, but that would regress when combined with ps/fetch-atomic-fixup'sde004e848a(t5503: simplify setup of test which exercises failure of backfill, 2022-03-03) (through no fault of that topic, that change started using "git clone" in the test, which has an outstanding leak). Let's leave that test out for now to avoid in-flight semantic conflicts. 1. https://lore.kernel.org/git/YUj%2FgFRh6pwrZalY@carlos-mbp.lan/ 2. https://lore.kernel.org/git/87o88obkb1.fsf@evledraar.gmail.com/ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
78 lines
1.6 KiB
Bash
Executable file
78 lines
1.6 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='rev-list testing in-commit-order'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'setup a commit history with trees, blobs' '
|
|
for x in one two three four
|
|
do
|
|
echo $x >$x &&
|
|
git add $x &&
|
|
git commit -m "add file $x" ||
|
|
return 1
|
|
done &&
|
|
for x in four three
|
|
do
|
|
git rm $x &&
|
|
git commit -m "remove $x" ||
|
|
return 1
|
|
done
|
|
'
|
|
|
|
test_expect_success 'rev-list --in-commit-order' '
|
|
git rev-list --in-commit-order --objects HEAD >actual.raw &&
|
|
cut -d" " -f1 >actual <actual.raw &&
|
|
|
|
git cat-file --batch-check="%(objectname)" >expect.raw <<-\EOF &&
|
|
HEAD^{commit}
|
|
HEAD^{tree}
|
|
HEAD^{tree}:one
|
|
HEAD^{tree}:two
|
|
HEAD~1^{commit}
|
|
HEAD~1^{tree}
|
|
HEAD~1^{tree}:three
|
|
HEAD~2^{commit}
|
|
HEAD~2^{tree}
|
|
HEAD~2^{tree}:four
|
|
HEAD~3^{commit}
|
|
# HEAD~3^{tree} skipped, same as HEAD~1^{tree}
|
|
HEAD~4^{commit}
|
|
# HEAD~4^{tree} skipped, same as HEAD^{tree}
|
|
HEAD~5^{commit}
|
|
HEAD~5^{tree}
|
|
EOF
|
|
grep -v "#" >expect <expect.raw &&
|
|
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'rev-list lists blobs and trees after commits' '
|
|
git rev-list --objects HEAD >actual.raw &&
|
|
cut -d" " -f1 >actual <actual.raw &&
|
|
|
|
git cat-file --batch-check="%(objectname)" >expect.raw <<-\EOF &&
|
|
HEAD^{commit}
|
|
HEAD~1^{commit}
|
|
HEAD~2^{commit}
|
|
HEAD~3^{commit}
|
|
HEAD~4^{commit}
|
|
HEAD~5^{commit}
|
|
HEAD^{tree}
|
|
HEAD^{tree}:one
|
|
HEAD^{tree}:two
|
|
HEAD~1^{tree}
|
|
HEAD~1^{tree}:three
|
|
HEAD~2^{tree}
|
|
HEAD~2^{tree}:four
|
|
# HEAD~3^{tree} skipped, same as HEAD~1^{tree}
|
|
# HEAD~4^{tree} skipped, same as HEAD^{tree}
|
|
HEAD~5^{tree}
|
|
EOF
|
|
grep -v "#" >expect <expect.raw &&
|
|
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_done
|