mirror of
https://github.com/git/git
synced 2024-11-05 18:59:29 +00:00
92d8ed8ac1
This saves 8K per `struct object_directory', meaning it saves around 800MB in my case involving 100K alternates (half or more of those alternates are unlikely to hold loose objects). This is implemented in two parts: a generic, allocation-free `cbtree' and the `oidtree' wrapper on top of it. The latter provides allocation using alloc_state as a memory pool to improve locality and reduce free(3) overhead. Unlike oid-array, the crit-bit tree does not require sorting. Performance is bound by the key length, for oidtree that is fixed at sizeof(struct object_id). There's no need to have 256 oidtrees to mitigate the O(n log n) overhead like we did with oid-array. Being a prefix trie, it is natively suited for expanding short object IDs via prefix-limited iteration in `find_short_object_filename'. On my busy workstation, p4205 performance seems to be roughly unchanged (+/-8%). Startup with 100K total alternates with no loose objects seems around 10-20% faster on a hot cache. (800MB in memory savings means more memory for the kernel FS cache). The generic cbtree implementation does impose some extra overhead for oidtree in that it uses memcmp(3) on "struct object_id" so it wastes cycles comparing 12 extra bytes on SHA-1 repositories. I've not yet explored reducing this overhead, but I expect there are many places in our code base where we'd want to investigate this. More information on crit-bit trees: https://cr.yp.to/critbit.html Signed-off-by: Eric Wong <e@80x24.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
49 lines
854 B
Bash
Executable file
49 lines
854 B
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='basic tests for the oidtree implementation'
|
|
. ./test-lib.sh
|
|
|
|
maxhexsz=$(test_oid hexsz)
|
|
echoid () {
|
|
prefix="${1:+$1 }"
|
|
shift
|
|
while test $# -gt 0
|
|
do
|
|
shortoid="$1"
|
|
shift
|
|
difference=$(($maxhexsz - ${#shortoid}))
|
|
printf "%s%s%0${difference}d\\n" "$prefix" "$shortoid" "0"
|
|
done
|
|
}
|
|
|
|
test_expect_success 'oidtree insert and contains' '
|
|
cat >expect <<-\EOF &&
|
|
0
|
|
0
|
|
0
|
|
1
|
|
1
|
|
0
|
|
EOF
|
|
{
|
|
echoid insert 444 1 2 3 4 5 a b c d e &&
|
|
echoid contains 44 441 440 444 4440 4444
|
|
echo clear
|
|
} | test-tool oidtree >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'oidtree each' '
|
|
echoid "" 123 321 321 >expect &&
|
|
{
|
|
echoid insert f 9 8 123 321 a b c d e
|
|
echo each 12300
|
|
echo each 3211
|
|
echo each 3210
|
|
echo each 32100
|
|
echo clear
|
|
} | test-tool oidtree >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_done
|