mirror of
https://github.com/git/git
synced 2024-10-30 13:20:15 +00:00
9081a421a6
The "checkout" command is one of the main sources of leaks in the test
suite, let's fix the common ones by not leaking from the "struct
branch_info".
Doing this is rather straightforward, albeit verbose, we need to
xstrdup() constant strings going into the struct, and free() the ones
we clobber as we go along.
This also means that we can delete previous partial leak fixes in this
area, i.e. the "path_to_free" accounting added by 96ec7b1e70 (Convert
resolve_ref+xstrdup to new resolve_refdup function, 2011-12-13).
There was some discussion about whether "we should retain the "const
char *" here and cast at free() time, or have it be a "char *". Since
this is not a public API with any sort of API boundary let's use
"char *", as is already being done for the "refname" member of the
same struct.
The tests to mark as passing were found with:
rm .prove; GIT_SKIP_TESTS=t0027 prove -j8 --state=save t[0-9]*.sh :: --immediate
# apply & compile this change
prove -j8 --state=failed :: --immediate
I.e. the ones that were newly passing when the --state=failed command
was run. I left out "t3040-subprojects-basic.sh" and
"t4131-apply-fake-ancestor.sh" to to optimization-level related
differences similar to the ones noted in[1], except that these would
be something the current 'linux-leaks' job would run into.
1. https://lore.kernel.org/git/cover-v3-0.6-00000000000-20211022T175227Z-avarab@gmail.com/
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
83 lines
1.8 KiB
Bash
Executable file
83 lines
1.8 KiB
Bash
Executable file
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2007 David Symonds
|
|
|
|
test_description='git checkout from subdirectories'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success setup '
|
|
|
|
echo "base" > file0 &&
|
|
git add file0 &&
|
|
mkdir dir1 &&
|
|
echo "hello" > dir1/file1 &&
|
|
git add dir1/file1 &&
|
|
mkdir dir2 &&
|
|
echo "bonjour" > dir2/file2 &&
|
|
git add dir2/file2 &&
|
|
test_tick &&
|
|
git commit -m "populate tree"
|
|
|
|
'
|
|
|
|
test_expect_success 'remove and restore with relative path' '
|
|
|
|
(
|
|
cd dir1 &&
|
|
rm ../file0 &&
|
|
git checkout HEAD -- ../file0 &&
|
|
test "base" = "$(cat ../file0)" &&
|
|
rm ../dir2/file2 &&
|
|
git checkout HEAD -- ../dir2/file2 &&
|
|
test "bonjour" = "$(cat ../dir2/file2)" &&
|
|
rm ../file0 ./file1 &&
|
|
git checkout HEAD -- .. &&
|
|
test "base" = "$(cat ../file0)" &&
|
|
test "hello" = "$(cat file1)"
|
|
)
|
|
|
|
'
|
|
|
|
test_expect_success 'checkout with empty prefix' '
|
|
|
|
rm file0 &&
|
|
git checkout HEAD -- file0 &&
|
|
test "base" = "$(cat file0)"
|
|
|
|
'
|
|
|
|
test_expect_success 'checkout with simple prefix' '
|
|
|
|
rm dir1/file1 &&
|
|
git checkout HEAD -- dir1 &&
|
|
test "hello" = "$(cat dir1/file1)" &&
|
|
rm dir1/file1 &&
|
|
git checkout HEAD -- dir1/file1 &&
|
|
test "hello" = "$(cat dir1/file1)"
|
|
|
|
'
|
|
|
|
test_expect_success 'checkout with complex relative path' '
|
|
(
|
|
cd dir1 &&
|
|
rm file1 &&
|
|
git checkout HEAD -- ../dir1/../dir1/file1 &&
|
|
test "hello" = "$(cat file1)"
|
|
)
|
|
'
|
|
|
|
test_expect_success 'relative path outside tree should fail' \
|
|
'test_must_fail git checkout HEAD -- ../../Makefile'
|
|
|
|
test_expect_success 'incorrect relative path to file should fail (1)' \
|
|
'test_must_fail git checkout HEAD -- ../file0'
|
|
|
|
test_expect_success 'incorrect relative path should fail (2)' \
|
|
'( cd dir1 && test_must_fail git checkout HEAD -- ./file0 )'
|
|
|
|
test_expect_success 'incorrect relative path should fail (3)' \
|
|
'( cd dir1 && test_must_fail git checkout HEAD -- ../../file0 )'
|
|
|
|
test_done
|