mirror of
https://github.com/git/git
synced 2024-10-28 19:25:47 +00:00
7f8ab8dc07
In commit 34110cd4e3 ("Make 'unpack_trees()'
have a separate source and destination index") I introduced a really
stupid bug in that it would always add merged entries with the CE_UPDATE
flag set. That caused us to always re-write the file, even when it was
already up-to-date in the source index.
Not only is that really stupid from a performance angle, but more
importantly it's actively wrong: if we have dirty state in the tree when
we merge, overwriting it with the result of the merge will incorrectly
overwrite that dirty state.
This trivially fixes the problem - simply don't set the CE_UPDATE flag
when the merge result matches the old state.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
160 lines
3.9 KiB
Bash
Executable file
160 lines
3.9 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='read-tree -m -u checks working tree files'
|
|
|
|
. ./test-lib.sh
|
|
|
|
# two-tree test
|
|
|
|
test_expect_success 'two-way setup' '
|
|
|
|
mkdir subdir &&
|
|
echo >file1 file one &&
|
|
echo >file2 file two &&
|
|
echo >subdir/file1 file one in subdirectory &&
|
|
echo >subdir/file2 file two in subdirectory &&
|
|
git update-index --add file1 file2 subdir/file1 subdir/file2 &&
|
|
git commit -m initial &&
|
|
|
|
git branch side &&
|
|
git tag -f branch-point &&
|
|
|
|
echo file2 is not tracked on the master anymore &&
|
|
rm -f file2 subdir/file2 &&
|
|
git update-index --remove file2 subdir/file2 &&
|
|
git commit -a -m "master removes file2 and subdir/file2"
|
|
'
|
|
|
|
test_expect_success 'two-way not clobbering' '
|
|
|
|
echo >file2 master creates untracked file2 &&
|
|
echo >subdir/file2 master creates untracked subdir/file2 &&
|
|
if err=`git read-tree -m -u master side 2>&1`
|
|
then
|
|
echo should have complained
|
|
false
|
|
else
|
|
echo "happy to see $err"
|
|
fi
|
|
'
|
|
|
|
echo file2 >.gitignore
|
|
|
|
test_expect_success 'two-way with incorrect --exclude-per-directory (1)' '
|
|
|
|
if err=`git read-tree -m --exclude-per-directory=.gitignore master side 2>&1`
|
|
then
|
|
echo should have complained
|
|
false
|
|
else
|
|
echo "happy to see $err"
|
|
fi
|
|
'
|
|
|
|
test_expect_success 'two-way with incorrect --exclude-per-directory (2)' '
|
|
|
|
if err=`git read-tree -m -u --exclude-per-directory=foo --exclude-per-directory=.gitignore master side 2>&1`
|
|
then
|
|
echo should have complained
|
|
false
|
|
else
|
|
echo "happy to see $err"
|
|
fi
|
|
'
|
|
|
|
test_expect_success 'two-way clobbering a ignored file' '
|
|
|
|
git read-tree -m -u --exclude-per-directory=.gitignore master side
|
|
'
|
|
|
|
rm -f .gitignore
|
|
|
|
# three-tree test
|
|
|
|
test_expect_success 'three-way not complaining on an untracked path in both' '
|
|
|
|
rm -f file2 subdir/file2 &&
|
|
git checkout side &&
|
|
echo >file3 file three &&
|
|
echo >subdir/file3 file three &&
|
|
git update-index --add file3 subdir/file3 &&
|
|
git commit -a -m "side adds file3 and removes file2" &&
|
|
|
|
git checkout master &&
|
|
echo >file2 file two is untracked on the master side &&
|
|
echo >subdir/file2 file two is untracked on the master side &&
|
|
|
|
git read-tree -m -u branch-point master side
|
|
'
|
|
|
|
test_expect_success 'three-way not clobbering a working tree file' '
|
|
|
|
git reset --hard &&
|
|
rm -f file2 subdir/file2 file3 subdir/file3 &&
|
|
git checkout master &&
|
|
echo >file3 file three created in master, untracked &&
|
|
echo >subdir/file3 file three created in master, untracked &&
|
|
if err=`git read-tree -m -u branch-point master side 2>&1`
|
|
then
|
|
echo should have complained
|
|
false
|
|
else
|
|
echo "happy to see $err"
|
|
fi
|
|
'
|
|
|
|
echo >.gitignore file3
|
|
|
|
test_expect_success 'three-way not complaining on an untracked file' '
|
|
|
|
git reset --hard &&
|
|
rm -f file2 subdir/file2 file3 subdir/file3 &&
|
|
git checkout master &&
|
|
echo >file3 file three created in master, untracked &&
|
|
echo >subdir/file3 file three created in master, untracked &&
|
|
|
|
git read-tree -m -u --exclude-per-directory=.gitignore branch-point master side
|
|
'
|
|
|
|
test_expect_success '3-way not overwriting local changes (setup)' '
|
|
|
|
git reset --hard &&
|
|
git checkout -b side-a branch-point &&
|
|
echo >>file1 "new line to be kept in the merge result" &&
|
|
git commit -a -m "side-a changes file1" &&
|
|
git checkout -b side-b branch-point &&
|
|
echo >>file2 "new line to be kept in the merge result" &&
|
|
git commit -a -m "side-b changes file2" &&
|
|
git checkout side-a
|
|
|
|
'
|
|
|
|
test_expect_success '3-way not overwriting local changes (our side)' '
|
|
|
|
# At this point, file1 from side-a should be kept as side-b
|
|
# did not touch it.
|
|
|
|
git reset --hard &&
|
|
|
|
echo >>file1 "local changes" &&
|
|
git read-tree -m -u branch-point side-a side-b &&
|
|
grep "new line to be kept" file1 &&
|
|
grep "local changes" file1
|
|
|
|
'
|
|
|
|
test_expect_success '3-way not overwriting local changes (their side)' '
|
|
|
|
# At this point, file2 from side-b should be taken as side-a
|
|
# did not touch it.
|
|
|
|
git reset --hard &&
|
|
|
|
echo >>file2 "local changes" &&
|
|
test_must_fail git read-tree -m -u branch-point side-a side-b &&
|
|
! grep "new line to be kept" file2 &&
|
|
grep "local changes" file2
|
|
|
|
'
|
|
|
|
test_done
|