mirror of
https://github.com/git/git
synced 2024-08-25 10:45:59 +00:00
![Ævar Arnfjörð Bjarmason](/assets/img/avatar_default.png)
When the "ab/various-leak-fixes" topic was merged in [1] only t6021 would fail if the tests were run in the "GIT_TEST_PASSING_SANITIZE_LEAK=check" mode, i.e. to check whether we marked all leak-free tests with "TEST_PASSES_SANITIZE_LEAK=true". Since then we've had various tests starting to pass under SANITIZE=leak. Let's mark those as passing, this is when they started to pass, narrowed down with "git bisect": - t5317-pack-objects-filter-objects.sh: Infaebba436e
(list-objects-filter: plug pattern_list leak, 2022-12-01). - t3210-pack-refs.sh, t5613-info-alternate.sh, t7403-submodule-sync.sh: In189e97bc4b
(diff: remove parseopts member from struct diff_options, 2022-12-01). - t1408-packed-refs.sh: Inab91f6b7c4
(Merge branch 'rs/diff-parseopts', 2022-12-19). - t0023-crlf-am.sh, t4152-am-subjects.sh, t4254-am-corrupt.sh, t4256-am-format-flowed.sh, t4257-am-interactive.sh, t5403-post-checkout-hook.sh: Ina658e881c1
(am: don't pass strvec to apply_parse_options(), 2022-12-13) - t1301-shared-repo.sh, t1302-repo-version.sh: Inb07a819c05
(reflog: clear leftovers in reflog_expiry_cleanup(), 2022-12-13). - t1304-default-acl.sh, t1410-reflog.sh, t5330-no-lazy-fetch-with-commit-graph.sh, t5502-quickfetch.sh, t5604-clone-reference.sh, t6014-rev-list-all.sh, t7701-repack-unpack-unreachable.sh: Inb0c61be320
(Merge branch 'rs/reflog-expiry-cleanup', 2022-12-26) - t3800-mktag.sh, t5302-pack-index.sh, t5306-pack-nobase.sh, t5573-pull-verify-signatures.sh, t7612-merge-verify-signatures.sh: In69bbbe484b
(hash-object: use fsck for object checks, 2023-01-18). - t1451-fsck-buffer.sh: In8e4309038f
(fsck: do not assume NUL-termination of buffers, 2023-01-19). - t6501-freshen-objects.sh: Inabf2bb895b
(Merge branch 'jk/hash-object-fsck', 2023-01-30) 1.9ea1378d04
(Merge branch 'ab/various-leak-fixes', 2022-12-14) Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
142 lines
3.9 KiB
Bash
Executable file
142 lines
3.9 KiB
Bash
Executable file
#!/bin/sh
|
|
#
|
|
# Copyright (C) 2006 Martin Waitz <tali@admingilde.org>
|
|
#
|
|
|
|
test_description='test transitive info/alternate entries'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'preparing first repository' '
|
|
test_create_repo A && (
|
|
cd A &&
|
|
echo "Hello World" > file1 &&
|
|
git add file1 &&
|
|
git commit -m "Initial commit" file1 &&
|
|
git repack -a -d &&
|
|
git prune
|
|
)
|
|
'
|
|
|
|
test_expect_success 'preparing second repository' '
|
|
git clone -l -s A B && (
|
|
cd B &&
|
|
echo "foo bar" > file2 &&
|
|
git add file2 &&
|
|
git commit -m "next commit" file2 &&
|
|
git repack -a -d -l &&
|
|
git prune
|
|
)
|
|
'
|
|
|
|
test_expect_success 'preparing third repository' '
|
|
git clone -l -s B C && (
|
|
cd C &&
|
|
echo "Goodbye, cruel world" > file3 &&
|
|
git add file3 &&
|
|
git commit -m "one more" file3 &&
|
|
git repack -a -d -l &&
|
|
git prune
|
|
)
|
|
'
|
|
|
|
test_expect_success 'count-objects shows the alternates' '
|
|
cat >expect <<-EOF &&
|
|
alternate: $(pwd)/B/.git/objects
|
|
alternate: $(pwd)/A/.git/objects
|
|
EOF
|
|
git -C C count-objects -v >actual &&
|
|
grep ^alternate: actual >actual.alternates &&
|
|
test_cmp expect actual.alternates
|
|
'
|
|
|
|
# Note: These tests depend on the hard-coded value of 5 as the maximum depth
|
|
# we will follow recursion. We start the depth at 0 and count links, not
|
|
# repositories. This means that in a chain like:
|
|
#
|
|
# A --> B --> C --> D --> E --> F --> G --> H
|
|
# 0 1 2 3 4 5 6
|
|
#
|
|
# we are OK at "G", but break at "H", even though "H" is actually the 8th
|
|
# repository, not the 6th, which you might expect. Counting the links allows
|
|
# N+1 repositories, and counting from 0 to 5 inclusive allows 6 links.
|
|
#
|
|
# Note also that we must use "--bare -l" to make the link to H. The "-l"
|
|
# ensures we do not do a connectivity check, and the "--bare" makes sure
|
|
# we do not try to checkout the result (which needs objects), either of
|
|
# which would cause the clone to fail.
|
|
test_expect_success 'creating too deep nesting' '
|
|
git clone -l -s C D &&
|
|
git clone -l -s D E &&
|
|
git clone -l -s E F &&
|
|
git clone -l -s F G &&
|
|
git clone --bare -l -s G H
|
|
'
|
|
|
|
test_expect_success 'validity of seventh repository' '
|
|
git -C G fsck
|
|
'
|
|
|
|
test_expect_success 'invalidity of eighth repository' '
|
|
test_must_fail git -C H fsck
|
|
'
|
|
|
|
test_expect_success 'breaking of loops' '
|
|
echo "$(pwd)"/B/.git/objects >>A/.git/objects/info/alternates &&
|
|
git -C C fsck
|
|
'
|
|
|
|
test_expect_success 'that info/alternates is necessary' '
|
|
rm -f C/.git/objects/info/alternates &&
|
|
test_must_fail git -C C fsck
|
|
'
|
|
|
|
test_expect_success 'that relative alternate is possible for current dir' '
|
|
echo "../../../B/.git/objects" >C/.git/objects/info/alternates &&
|
|
git fsck
|
|
'
|
|
|
|
test_expect_success 'that relative alternate is recursive' '
|
|
git -C D fsck
|
|
'
|
|
|
|
# we can reach "A" from our new repo both directly, and via "C".
|
|
# The deep/subdir is there to make sure we are not doing a stupid
|
|
# pure-text comparison of the alternate names.
|
|
test_expect_success 'relative duplicates are eliminated' '
|
|
mkdir -p deep/subdir &&
|
|
git init --bare deep/subdir/duplicate.git &&
|
|
cat >deep/subdir/duplicate.git/objects/info/alternates <<-\EOF &&
|
|
../../../../C/.git/objects
|
|
../../../../A/.git/objects
|
|
EOF
|
|
cat >expect <<-EOF &&
|
|
alternate: $(pwd)/C/.git/objects
|
|
alternate: $(pwd)/B/.git/objects
|
|
alternate: $(pwd)/A/.git/objects
|
|
EOF
|
|
git -C deep/subdir/duplicate.git count-objects -v >actual &&
|
|
grep ^alternate: actual >actual.alternates &&
|
|
test_cmp expect actual.alternates
|
|
'
|
|
|
|
test_expect_success CASE_INSENSITIVE_FS 'dup finding can be case-insensitive' '
|
|
git init --bare insensitive.git &&
|
|
# the previous entry for "A" will have used uppercase
|
|
cat >insensitive.git/objects/info/alternates <<-\EOF &&
|
|
../../C/.git/objects
|
|
../../a/.git/objects
|
|
EOF
|
|
cat >expect <<-EOF &&
|
|
alternate: $(pwd)/C/.git/objects
|
|
alternate: $(pwd)/B/.git/objects
|
|
alternate: $(pwd)/A/.git/objects
|
|
EOF
|
|
git -C insensitive.git count-objects -v >actual &&
|
|
grep ^alternate: actual >actual.alternates &&
|
|
test_cmp expect actual.alternates
|
|
'
|
|
|
|
test_done
|