mirror of
https://github.com/git/git
synced 2024-08-25 02:35:46 +00:00
![Ævar Arnfjörð Bjarmason](/assets/img/avatar_default.png)
When the "ab/various-leak-fixes" topic was merged in [1] only t6021 would fail if the tests were run in the "GIT_TEST_PASSING_SANITIZE_LEAK=check" mode, i.e. to check whether we marked all leak-free tests with "TEST_PASSES_SANITIZE_LEAK=true". Since then we've had various tests starting to pass under SANITIZE=leak. Let's mark those as passing, this is when they started to pass, narrowed down with "git bisect": - t5317-pack-objects-filter-objects.sh: Infaebba436e
(list-objects-filter: plug pattern_list leak, 2022-12-01). - t3210-pack-refs.sh, t5613-info-alternate.sh, t7403-submodule-sync.sh: In189e97bc4b
(diff: remove parseopts member from struct diff_options, 2022-12-01). - t1408-packed-refs.sh: Inab91f6b7c4
(Merge branch 'rs/diff-parseopts', 2022-12-19). - t0023-crlf-am.sh, t4152-am-subjects.sh, t4254-am-corrupt.sh, t4256-am-format-flowed.sh, t4257-am-interactive.sh, t5403-post-checkout-hook.sh: Ina658e881c1
(am: don't pass strvec to apply_parse_options(), 2022-12-13) - t1301-shared-repo.sh, t1302-repo-version.sh: Inb07a819c05
(reflog: clear leftovers in reflog_expiry_cleanup(), 2022-12-13). - t1304-default-acl.sh, t1410-reflog.sh, t5330-no-lazy-fetch-with-commit-graph.sh, t5502-quickfetch.sh, t5604-clone-reference.sh, t6014-rev-list-all.sh, t7701-repack-unpack-unreachable.sh: Inb0c61be320
(Merge branch 'rs/reflog-expiry-cleanup', 2022-12-26) - t3800-mktag.sh, t5302-pack-index.sh, t5306-pack-nobase.sh, t5573-pull-verify-signatures.sh, t7612-merge-verify-signatures.sh: In69bbbe484b
(hash-object: use fsck for object checks, 2023-01-18). - t1451-fsck-buffer.sh: In8e4309038f
(fsck: do not assume NUL-termination of buffers, 2023-01-19). - t6501-freshen-objects.sh: Inabf2bb895b
(Merge branch 'jk/hash-object-fsck', 2023-01-30) 1.9ea1378d04
(Merge branch 'ab/various-leak-fixes', 2022-12-14) Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
475 lines
13 KiB
Bash
Executable file
475 lines
13 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='git pack-objects using object filtering'
|
|
|
|
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
|
|
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
# Test blob:none filter.
|
|
|
|
test_expect_success 'setup r1' '
|
|
git init r1 &&
|
|
for n in 1 2 3 4 5
|
|
do
|
|
echo "This is file: $n" > r1/file.$n &&
|
|
git -C r1 add file.$n &&
|
|
git -C r1 commit -m "$n" || return 1
|
|
done
|
|
'
|
|
|
|
parse_verify_pack_blob_oid () {
|
|
awk '{print $1}' -
|
|
}
|
|
|
|
test_expect_success 'verify blob count in normal packfile' '
|
|
git -C r1 ls-files -s file.1 file.2 file.3 file.4 file.5 \
|
|
>ls_files_result &&
|
|
test_parse_ls_files_stage_oids <ls_files_result |
|
|
sort >expected &&
|
|
|
|
git -C r1 pack-objects --revs --stdout >all.pack <<-EOF &&
|
|
HEAD
|
|
EOF
|
|
git -C r1 index-pack ../all.pack &&
|
|
|
|
git -C r1 verify-pack -v ../all.pack >verify_result &&
|
|
grep blob verify_result |
|
|
parse_verify_pack_blob_oid |
|
|
sort >observed &&
|
|
|
|
test_cmp expected observed
|
|
'
|
|
|
|
test_expect_success 'verify blob:none packfile has no blobs' '
|
|
git -C r1 pack-objects --revs --stdout --filter=blob:none >filter.pack <<-EOF &&
|
|
HEAD
|
|
EOF
|
|
git -C r1 index-pack ../filter.pack &&
|
|
|
|
git -C r1 verify-pack -v ../filter.pack >verify_result &&
|
|
! grep blob verify_result
|
|
'
|
|
|
|
test_expect_success 'verify normal and blob:none packfiles have same commits/trees' '
|
|
git -C r1 verify-pack -v ../all.pack >verify_result &&
|
|
grep -E "commit|tree" verify_result |
|
|
parse_verify_pack_blob_oid |
|
|
sort >expected &&
|
|
|
|
git -C r1 verify-pack -v ../filter.pack >verify_result &&
|
|
grep -E "commit|tree" verify_result |
|
|
parse_verify_pack_blob_oid |
|
|
sort >observed &&
|
|
|
|
test_cmp expected observed
|
|
'
|
|
|
|
test_expect_success 'get an error for missing tree object' '
|
|
git init r5 &&
|
|
echo foo >r5/foo &&
|
|
git -C r5 add foo &&
|
|
git -C r5 commit -m "foo" &&
|
|
git -C r5 rev-parse HEAD^{tree} >tree &&
|
|
del=$(sed "s|..|&/|" tree) &&
|
|
rm r5/.git/objects/$del &&
|
|
test_must_fail git -C r5 pack-objects --revs --stdout 2>bad_tree <<-EOF &&
|
|
HEAD
|
|
EOF
|
|
grep "bad tree object" bad_tree
|
|
'
|
|
|
|
test_expect_success 'setup for tests of tree:0' '
|
|
mkdir r1/subtree &&
|
|
echo "This is a file in a subtree" >r1/subtree/file &&
|
|
git -C r1 add subtree/file &&
|
|
git -C r1 commit -m subtree
|
|
'
|
|
|
|
test_expect_success 'verify tree:0 packfile has no blobs or trees' '
|
|
git -C r1 pack-objects --revs --stdout --filter=tree:0 >commitsonly.pack <<-EOF &&
|
|
HEAD
|
|
EOF
|
|
git -C r1 index-pack ../commitsonly.pack &&
|
|
git -C r1 verify-pack -v ../commitsonly.pack >objs &&
|
|
! grep -E "tree|blob" objs
|
|
'
|
|
|
|
test_expect_success 'grab tree directly when using tree:0' '
|
|
# We should get the tree specified directly but not its blobs or subtrees.
|
|
git -C r1 pack-objects --revs --stdout --filter=tree:0 >commitsonly.pack <<-EOF &&
|
|
HEAD:
|
|
EOF
|
|
git -C r1 index-pack ../commitsonly.pack &&
|
|
git -C r1 verify-pack -v ../commitsonly.pack >objs &&
|
|
awk "/tree|blob/{print \$1}" objs >trees_and_blobs &&
|
|
git -C r1 rev-parse HEAD: >expected &&
|
|
test_cmp expected trees_and_blobs
|
|
'
|
|
|
|
# Test blob:limit=<n>[kmg] filter.
|
|
# We boundary test around the size parameter. The filter is strictly less than
|
|
# the value, so size 500 and 1000 should have the same results, but 1001 should
|
|
# filter more.
|
|
|
|
test_expect_success 'setup r2' '
|
|
git init r2 &&
|
|
for n in 1000 10000
|
|
do
|
|
printf "%"$n"s" X > r2/large.$n &&
|
|
git -C r2 add large.$n &&
|
|
git -C r2 commit -m "$n" || return 1
|
|
done
|
|
'
|
|
|
|
test_expect_success 'verify blob count in normal packfile' '
|
|
git -C r2 ls-files -s large.1000 large.10000 >ls_files_result &&
|
|
test_parse_ls_files_stage_oids <ls_files_result |
|
|
sort >expected &&
|
|
|
|
git -C r2 pack-objects --revs --stdout >all.pack <<-EOF &&
|
|
HEAD
|
|
EOF
|
|
git -C r2 index-pack ../all.pack &&
|
|
|
|
git -C r2 verify-pack -v ../all.pack >verify_result &&
|
|
grep blob verify_result |
|
|
parse_verify_pack_blob_oid |
|
|
sort >observed &&
|
|
|
|
test_cmp expected observed
|
|
'
|
|
|
|
test_expect_success 'verify blob:limit=500 omits all blobs' '
|
|
git -C r2 pack-objects --revs --stdout --filter=blob:limit=500 >filter.pack <<-EOF &&
|
|
HEAD
|
|
EOF
|
|
git -C r2 index-pack ../filter.pack &&
|
|
|
|
git -C r2 verify-pack -v ../filter.pack >verify_result &&
|
|
! grep blob verify_result
|
|
'
|
|
|
|
test_expect_success 'verify blob:limit=1000' '
|
|
git -C r2 pack-objects --revs --stdout --filter=blob:limit=1000 >filter.pack <<-EOF &&
|
|
HEAD
|
|
EOF
|
|
git -C r2 index-pack ../filter.pack &&
|
|
|
|
git -C r2 verify-pack -v ../filter.pack >verify_result &&
|
|
! grep blob verify_result
|
|
'
|
|
|
|
test_expect_success 'verify blob:limit=1001' '
|
|
git -C r2 ls-files -s large.1000 >ls_files_result &&
|
|
test_parse_ls_files_stage_oids <ls_files_result |
|
|
sort >expected &&
|
|
|
|
git -C r2 pack-objects --revs --stdout --filter=blob:limit=1001 >filter.pack <<-EOF &&
|
|
HEAD
|
|
EOF
|
|
git -C r2 index-pack ../filter.pack &&
|
|
|
|
git -C r2 verify-pack -v ../filter.pack >verify_result &&
|
|
grep blob verify_result |
|
|
parse_verify_pack_blob_oid |
|
|
sort >observed &&
|
|
|
|
test_cmp expected observed
|
|
'
|
|
|
|
test_expect_success 'verify blob:limit=10001' '
|
|
git -C r2 ls-files -s large.1000 large.10000 >ls_files_result &&
|
|
test_parse_ls_files_stage_oids <ls_files_result |
|
|
sort >expected &&
|
|
|
|
git -C r2 pack-objects --revs --stdout --filter=blob:limit=10001 >filter.pack <<-EOF &&
|
|
HEAD
|
|
EOF
|
|
git -C r2 index-pack ../filter.pack &&
|
|
|
|
git -C r2 verify-pack -v ../filter.pack >verify_result &&
|
|
grep blob verify_result |
|
|
parse_verify_pack_blob_oid |
|
|
sort >observed &&
|
|
|
|
test_cmp expected observed
|
|
'
|
|
|
|
test_expect_success 'verify blob:limit=1k' '
|
|
git -C r2 ls-files -s large.1000 >ls_files_result &&
|
|
test_parse_ls_files_stage_oids <ls_files_result |
|
|
sort >expected &&
|
|
|
|
git -C r2 pack-objects --revs --stdout --filter=blob:limit=1k >filter.pack <<-EOF &&
|
|
HEAD
|
|
EOF
|
|
git -C r2 index-pack ../filter.pack &&
|
|
|
|
git -C r2 verify-pack -v ../filter.pack >verify_result &&
|
|
grep blob verify_result |
|
|
parse_verify_pack_blob_oid |
|
|
sort >observed &&
|
|
|
|
test_cmp expected observed
|
|
'
|
|
|
|
test_expect_success 'verify explicitly specifying oversized blob in input' '
|
|
git -C r2 ls-files -s large.1000 large.10000 >ls_files_result &&
|
|
test_parse_ls_files_stage_oids <ls_files_result |
|
|
sort >expected &&
|
|
|
|
echo HEAD >objects &&
|
|
git -C r2 rev-parse HEAD:large.10000 >>objects &&
|
|
git -C r2 pack-objects --revs --stdout --filter=blob:limit=1k <objects >filter.pack &&
|
|
git -C r2 index-pack ../filter.pack &&
|
|
|
|
git -C r2 verify-pack -v ../filter.pack >verify_result &&
|
|
grep blob verify_result |
|
|
parse_verify_pack_blob_oid |
|
|
sort >observed &&
|
|
|
|
test_cmp expected observed
|
|
'
|
|
|
|
test_expect_success 'verify blob:limit=1m' '
|
|
git -C r2 ls-files -s large.1000 large.10000 >ls_files_result &&
|
|
test_parse_ls_files_stage_oids <ls_files_result |
|
|
sort >expected &&
|
|
|
|
git -C r2 pack-objects --revs --stdout --filter=blob:limit=1m >filter.pack <<-EOF &&
|
|
HEAD
|
|
EOF
|
|
git -C r2 index-pack ../filter.pack &&
|
|
|
|
git -C r2 verify-pack -v ../filter.pack >verify_result &&
|
|
grep blob verify_result |
|
|
parse_verify_pack_blob_oid |
|
|
sort >observed &&
|
|
|
|
test_cmp expected observed
|
|
'
|
|
|
|
test_expect_success 'verify normal and blob:limit packfiles have same commits/trees' '
|
|
git -C r2 verify-pack -v ../all.pack >verify_result &&
|
|
grep -E "commit|tree" verify_result |
|
|
parse_verify_pack_blob_oid |
|
|
sort >expected &&
|
|
|
|
git -C r2 verify-pack -v ../filter.pack >verify_result &&
|
|
grep -E "commit|tree" verify_result |
|
|
parse_verify_pack_blob_oid |
|
|
sort >observed &&
|
|
|
|
test_cmp expected observed
|
|
'
|
|
|
|
test_expect_success 'verify small limit and big limit results in small limit' '
|
|
git -C r2 ls-files -s large.1000 >ls_files_result &&
|
|
test_parse_ls_files_stage_oids <ls_files_result |
|
|
sort >expected &&
|
|
|
|
git -C r2 pack-objects --revs --stdout --filter=blob:limit=1001 \
|
|
--filter=blob:limit=10001 >filter.pack <<-EOF &&
|
|
HEAD
|
|
EOF
|
|
git -C r2 index-pack ../filter.pack &&
|
|
|
|
git -C r2 verify-pack -v ../filter.pack >verify_result &&
|
|
grep blob verify_result |
|
|
parse_verify_pack_blob_oid |
|
|
sort >observed &&
|
|
|
|
test_cmp expected observed
|
|
'
|
|
|
|
test_expect_success 'verify big limit and small limit results in small limit' '
|
|
git -C r2 ls-files -s large.1000 >ls_files_result &&
|
|
test_parse_ls_files_stage_oids <ls_files_result |
|
|
sort >expected &&
|
|
|
|
git -C r2 pack-objects --revs --stdout --filter=blob:limit=10001 \
|
|
--filter=blob:limit=1001 >filter.pack <<-EOF &&
|
|
HEAD
|
|
EOF
|
|
git -C r2 index-pack ../filter.pack &&
|
|
|
|
git -C r2 verify-pack -v ../filter.pack >verify_result &&
|
|
grep blob verify_result |
|
|
parse_verify_pack_blob_oid |
|
|
sort >observed &&
|
|
|
|
test_cmp expected observed
|
|
'
|
|
|
|
# Test sparse:path=<path> filter.
|
|
# !!!!
|
|
# NOTE: sparse:path filter support has been dropped for security reasons,
|
|
# so the tests have been changed to make sure that using it fails.
|
|
# !!!!
|
|
# Use a local file containing a sparse-checkout specification to filter
|
|
# out blobs not required for the corresponding sparse-checkout. We do not
|
|
# require sparse-checkout to actually be enabled.
|
|
|
|
test_expect_success 'setup r3' '
|
|
git init r3 &&
|
|
mkdir r3/dir1 &&
|
|
for n in sparse1 sparse2
|
|
do
|
|
echo "This is file: $n" > r3/$n &&
|
|
git -C r3 add $n &&
|
|
echo "This is file: dir1/$n" > r3/dir1/$n &&
|
|
git -C r3 add dir1/$n || return 1
|
|
done &&
|
|
git -C r3 commit -m "sparse" &&
|
|
echo dir1/ >pattern1 &&
|
|
echo sparse1 >pattern2
|
|
'
|
|
|
|
test_expect_success 'verify blob count in normal packfile' '
|
|
git -C r3 ls-files -s sparse1 sparse2 dir1/sparse1 dir1/sparse2 \
|
|
>ls_files_result &&
|
|
test_parse_ls_files_stage_oids <ls_files_result |
|
|
sort >expected &&
|
|
|
|
git -C r3 pack-objects --revs --stdout >all.pack <<-EOF &&
|
|
HEAD
|
|
EOF
|
|
git -C r3 index-pack ../all.pack &&
|
|
|
|
git -C r3 verify-pack -v ../all.pack >verify_result &&
|
|
grep blob verify_result |
|
|
parse_verify_pack_blob_oid |
|
|
sort >observed &&
|
|
|
|
test_cmp expected observed
|
|
'
|
|
|
|
test_expect_success 'verify sparse:path=pattern1 fails' '
|
|
test_must_fail git -C r3 pack-objects --revs --stdout \
|
|
--filter=sparse:path=../pattern1 <<-EOF
|
|
HEAD
|
|
EOF
|
|
'
|
|
|
|
test_expect_success 'verify sparse:path=pattern2 fails' '
|
|
test_must_fail git -C r3 pack-objects --revs --stdout \
|
|
--filter=sparse:path=../pattern2 <<-EOF
|
|
HEAD
|
|
EOF
|
|
'
|
|
|
|
# Test sparse:oid=<oid-ish> filter.
|
|
# Use a blob containing a sparse-checkout specification to filter
|
|
# out blobs not required for the corresponding sparse-checkout. We do not
|
|
# require sparse-checkout to actually be enabled.
|
|
|
|
test_expect_success 'setup r4' '
|
|
git init r4 &&
|
|
mkdir r4/dir1 &&
|
|
for n in sparse1 sparse2
|
|
do
|
|
echo "This is file: $n" > r4/$n &&
|
|
git -C r4 add $n &&
|
|
echo "This is file: dir1/$n" > r4/dir1/$n &&
|
|
git -C r4 add dir1/$n || return 1
|
|
done &&
|
|
echo dir1/ >r4/pattern &&
|
|
git -C r4 add pattern &&
|
|
git -C r4 commit -m "pattern"
|
|
'
|
|
|
|
test_expect_success 'verify blob count in normal packfile' '
|
|
git -C r4 ls-files -s pattern sparse1 sparse2 dir1/sparse1 dir1/sparse2 \
|
|
>ls_files_result &&
|
|
test_parse_ls_files_stage_oids <ls_files_result |
|
|
sort >expected &&
|
|
|
|
git -C r4 pack-objects --revs --stdout >all.pack <<-EOF &&
|
|
HEAD
|
|
EOF
|
|
git -C r4 index-pack ../all.pack &&
|
|
|
|
git -C r4 verify-pack -v ../all.pack >verify_result &&
|
|
grep blob verify_result |
|
|
parse_verify_pack_blob_oid |
|
|
sort >observed &&
|
|
|
|
test_cmp expected observed
|
|
'
|
|
|
|
test_expect_success 'verify sparse:oid=OID' '
|
|
git -C r4 ls-files -s dir1/sparse1 dir1/sparse2 >ls_files_result &&
|
|
test_parse_ls_files_stage_oids <ls_files_result |
|
|
sort >expected &&
|
|
|
|
git -C r4 ls-files -s pattern >staged &&
|
|
oid=$(test_parse_ls_files_stage_oids <staged) &&
|
|
git -C r4 pack-objects --revs --stdout --filter=sparse:oid=$oid >filter.pack <<-EOF &&
|
|
HEAD
|
|
EOF
|
|
git -C r4 index-pack ../filter.pack &&
|
|
|
|
git -C r4 verify-pack -v ../filter.pack >verify_result &&
|
|
grep blob verify_result |
|
|
parse_verify_pack_blob_oid |
|
|
sort >observed &&
|
|
|
|
test_cmp expected observed
|
|
'
|
|
|
|
test_expect_success 'verify sparse:oid=oid-ish' '
|
|
git -C r4 ls-files -s dir1/sparse1 dir1/sparse2 >ls_files_result &&
|
|
test_parse_ls_files_stage_oids <ls_files_result |
|
|
sort >expected &&
|
|
|
|
git -C r4 pack-objects --revs --stdout --filter=sparse:oid=main:pattern >filter.pack <<-EOF &&
|
|
HEAD
|
|
EOF
|
|
git -C r4 index-pack ../filter.pack &&
|
|
|
|
git -C r4 verify-pack -v ../filter.pack >verify_result &&
|
|
grep blob verify_result |
|
|
parse_verify_pack_blob_oid |
|
|
sort >observed &&
|
|
|
|
test_cmp expected observed
|
|
'
|
|
|
|
# Delete some loose objects and use pack-objects, but WITHOUT any filtering.
|
|
# This models previously omitted objects that we did not receive.
|
|
|
|
test_expect_success 'setup r1 - delete loose blobs' '
|
|
git -C r1 ls-files -s file.1 file.2 file.3 file.4 file.5 \
|
|
>ls_files_result &&
|
|
test_parse_ls_files_stage_oids <ls_files_result |
|
|
sort >expected &&
|
|
|
|
for id in `cat expected | sed "s|..|&/|"`
|
|
do
|
|
rm r1/.git/objects/$id || return 1
|
|
done
|
|
'
|
|
|
|
test_expect_success 'verify pack-objects fails w/ missing objects' '
|
|
test_must_fail git -C r1 pack-objects --revs --stdout >miss.pack <<-EOF
|
|
HEAD
|
|
EOF
|
|
'
|
|
|
|
test_expect_success 'verify pack-objects fails w/ --missing=error' '
|
|
test_must_fail git -C r1 pack-objects --revs --stdout --missing=error >miss.pack <<-EOF
|
|
HEAD
|
|
EOF
|
|
'
|
|
|
|
test_expect_success 'verify pack-objects w/ --missing=allow-any' '
|
|
git -C r1 pack-objects --revs --stdout --missing=allow-any >miss.pack <<-EOF
|
|
HEAD
|
|
EOF
|
|
'
|
|
|
|
test_done
|