mirror of
https://github.com/git/git
synced 2024-08-24 18:26:02 +00:00
9ed104e5ca
If `user.name` and `user.email` have not been configured and the
user invokes:
git commit --author=...
without specifying the committer identity, then Git errors out with
a message asking the user to configure `user.name` and `user.email`
but doesn't tell the user which attribution was missing. This can be
confusing for a user new to Git who isn't aware of the distinction
between user, author, and committer.
Give such users a bit more help by extending the error message to
also say which attribution is expected.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
48 lines
1.3 KiB
Bash
Executable file
48 lines
1.3 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='corner cases in ident strings'
|
|
. ./test-lib.sh
|
|
|
|
# confirm that we do not segfault _and_ that we do not say "(null)", as
|
|
# glibc systems will quietly handle our NULL pointer
|
|
#
|
|
# Note also that we can't use "env" here because we need to unset a variable,
|
|
# and "-u" is not portable.
|
|
test_expect_success 'empty name and missing email' '
|
|
(
|
|
sane_unset GIT_AUTHOR_EMAIL &&
|
|
GIT_AUTHOR_NAME= &&
|
|
test_must_fail git commit --allow-empty -m foo 2>err &&
|
|
test_i18ngrep ! null err
|
|
)
|
|
'
|
|
|
|
test_expect_success 'commit rejects all-crud name' '
|
|
test_must_fail env GIT_AUTHOR_NAME=" .;<>" \
|
|
git commit --allow-empty -m foo
|
|
'
|
|
|
|
# We must test the actual error message here, as an unwanted
|
|
# auto-detection could fail for other reasons.
|
|
test_expect_success 'empty configured name does not auto-detect' '
|
|
(
|
|
sane_unset GIT_AUTHOR_NAME &&
|
|
test_must_fail \
|
|
git -c user.name= commit --allow-empty -m foo 2>err &&
|
|
test_i18ngrep "empty ident name" err &&
|
|
test_i18ngrep "Author identity unknown" err
|
|
)
|
|
'
|
|
|
|
test_expect_success 'empty configured name does not auto-detect for committer' '
|
|
(
|
|
sane_unset GIT_COMMITTER_NAME &&
|
|
test_must_fail \
|
|
git -c user.name= commit --allow-empty -m foo 2>err &&
|
|
test_i18ngrep "empty ident name" err &&
|
|
test_i18ngrep "Committer identity unknown" err
|
|
)
|
|
'
|
|
|
|
test_done
|