mirror of
https://github.com/git/git
synced 2024-08-24 18:26:02 +00:00
![Alexandr Miloslavskiy](/assets/img/avatar_default.png)
Previously, `parse_pathspec_file()` was tested indirectly by invoking git commands with properly crafted inputs. As demonstrated by the previous bugfix, testing complicated black boxes indirectly can lead to tests that silently test the wrong thing. Introduce direct tests for `parse_pathspec_file()`. Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
109 lines
1.9 KiB
Bash
Executable file
109 lines
1.9 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='Test parse_pathspec_file()'
|
|
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'one item from stdin' '
|
|
cat >expect <<-\EOF &&
|
|
fileA.t
|
|
EOF
|
|
|
|
echo fileA.t |
|
|
test-tool parse-pathspec-file --pathspec-from-file=- >actual &&
|
|
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'one item from file' '
|
|
cat >expect <<-\EOF &&
|
|
fileA.t
|
|
EOF
|
|
|
|
echo fileA.t >list &&
|
|
test-tool parse-pathspec-file --pathspec-from-file=list >actual &&
|
|
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'NUL delimiters' '
|
|
cat >expect <<-\EOF &&
|
|
fileA.t
|
|
fileB.t
|
|
EOF
|
|
|
|
printf "fileA.t\0fileB.t\0" |
|
|
test-tool parse-pathspec-file --pathspec-from-file=- --pathspec-file-nul >actual &&
|
|
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'LF delimiters' '
|
|
cat >expect <<-\EOF &&
|
|
fileA.t
|
|
fileB.t
|
|
EOF
|
|
|
|
printf "fileA.t\nfileB.t\n" |
|
|
test-tool parse-pathspec-file --pathspec-from-file=- >actual &&
|
|
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'no trailing delimiter' '
|
|
cat >expect <<-\EOF &&
|
|
fileA.t
|
|
fileB.t
|
|
EOF
|
|
|
|
printf "fileA.t\nfileB.t" |
|
|
test-tool parse-pathspec-file --pathspec-from-file=- >actual &&
|
|
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'CRLF delimiters' '
|
|
cat >expect <<-\EOF &&
|
|
fileA.t
|
|
fileB.t
|
|
EOF
|
|
|
|
printf "fileA.t\r\nfileB.t\r\n" |
|
|
test-tool parse-pathspec-file --pathspec-from-file=- >actual &&
|
|
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'quotes' '
|
|
cat >expect <<-\EOF &&
|
|
fileA.t
|
|
EOF
|
|
|
|
cat >list <<-\EOF &&
|
|
"file\101.t"
|
|
EOF
|
|
|
|
test-tool parse-pathspec-file --pathspec-from-file=list >actual &&
|
|
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success '--pathspec-file-nul takes quotes literally' '
|
|
# Note: there is an extra newline because --pathspec-file-nul takes
|
|
# input \n literally, too
|
|
cat >expect <<-\EOF &&
|
|
"file\101.t"
|
|
|
|
EOF
|
|
|
|
cat >list <<-\EOF &&
|
|
"file\101.t"
|
|
EOF
|
|
|
|
test-tool parse-pathspec-file --pathspec-from-file=list --pathspec-file-nul >actual &&
|
|
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_done
|