mirror of
https://github.com/git/git
synced 2024-11-05 18:59:29 +00:00
8df786d298
We have various behavior that's shared across our Makefiles, or that really should be (e.g. via defined templates). Let's create a top-level "shared.mak" to house those sorts of things, and start by adding the ".DELETE_ON_ERROR" flag to it. See my own7b76d6bf22(Makefile: add and use the ".DELETE_ON_ERROR" flag, 2021-06-29) anddb10fc6c09(doc: simplify Makefile using .DELETE_ON_ERROR, 2021-05-21) for the addition and use of the ".DELETE_ON_ERROR" flag. I.e. this changes the behavior of existing rules in the altered Makefiles (except "Makefile" & "Documentation/Makefile"). I'm confident that this is safe having read the relevant rules in those Makfiles, and as the GNU make manual notes that it isn't the default behavior is out of an abundance of backwards compatibility caution. From edition 0.75 of its manual, covering GNU make 4.3: [Enabling '.DELETE_ON_ERROR' is] almost always what you want 'make' to do, but it is not historical practice; so for compatibility, you must explicitly request it. This doesn't introduce a bug by e.g. having this ".DELETE_ON_ERROR" flag only apply to this new shared.mak, Makefiles have no such scoping semantics. It does increase the danger that any Makefile without an explicit "The default target of this Makefile is..." snippet to define the default target as "all" could have its default rule changed if our new shared.mak ever defines a "real" rule. In subsequent commits we'll be careful not to do that, and such breakage would be obvious e.g. in the case of "make -C t". We might want to make that less fragile still (e.g. by using ".DEFAULT_GOAL" as noted in the preceding commit), but for now let's simply include "shared.mak" without adding that boilerplate to all the Makefiles that don't have it already. Most of those are already exposed to that potential caveat e.g. due to including "config.mak*". Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
21 lines
360 B
Makefile
21 lines
360 B
Makefile
# Import tree-wide shared Makefile behavior and libraries
|
|
include ../../shared.mak
|
|
|
|
-include ../../config.mak
|
|
export GIT_TEST_OPTIONS
|
|
|
|
all: test-lint perf
|
|
|
|
perf: pre-clean
|
|
./run
|
|
|
|
pre-clean:
|
|
rm -rf test-results test-trace
|
|
|
|
clean:
|
|
rm -rf build "trash directory".* test-results test-trace
|
|
|
|
test-lint:
|
|
$(MAKE) -C .. test-lint
|
|
|
|
.PHONY: all perf pre-clean clean
|