mirror of
https://github.com/git/git
synced 2024-11-05 18:59:29 +00:00
e84a26e32f
Fix a leak that's been with us since3407bb4940(Add "unpack-file" helper that unpacks a sha1 blob into a tmpfile., 2005-04-18). See00c8fd493a(cat-file: use streaming API to print blobs, 2012-03-07) for prior art which shows the same API pattern, i.e. free()-ing the result of read_object_file() after it's used. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Taylor Blau <me@ttaylorr.com>
39 lines
876 B
C
39 lines
876 B
C
#include "builtin.h"
|
|
#include "config.h"
|
|
#include "object-store.h"
|
|
|
|
static char *create_temp_file(struct object_id *oid)
|
|
{
|
|
static char path[50];
|
|
void *buf;
|
|
enum object_type type;
|
|
unsigned long size;
|
|
int fd;
|
|
|
|
buf = read_object_file(oid, &type, &size);
|
|
if (!buf || type != OBJ_BLOB)
|
|
die("unable to read blob object %s", oid_to_hex(oid));
|
|
|
|
xsnprintf(path, sizeof(path), ".merge_file_XXXXXX");
|
|
fd = xmkstemp(path);
|
|
if (write_in_full(fd, buf, size) < 0)
|
|
die_errno("unable to write temp-file");
|
|
close(fd);
|
|
free(buf);
|
|
return path;
|
|
}
|
|
|
|
int cmd_unpack_file(int argc, const char **argv, const char *prefix)
|
|
{
|
|
struct object_id oid;
|
|
|
|
if (argc != 2 || !strcmp(argv[1], "-h"))
|
|
usage("git unpack-file <blob>");
|
|
if (get_oid(argv[1], &oid))
|
|
die("Not a valid object name %s", argv[1]);
|
|
|
|
git_config(git_default_config, NULL);
|
|
|
|
puts(create_temp_file(&oid));
|
|
return 0;
|
|
}
|