mirror of
https://github.com/git/git
synced 2024-09-12 21:04:12 +00:00
75afe7ac87
As part of the add_reflog_to_walk() function, we keep a
string_list mapping refnames to their reflog contents. This
serves as a cache so that accessing the same reflog twice
requires only a single copy of the log in memory.
The string_list is initialized via xcalloc, meaning its
strdup_strings field is set to 0. But after inserting a
string into the list, we unconditionally call free() on the
string, leaving the list pointing to freed memory. If
another reflog is added (e.g., "git log -g HEAD HEAD"), then
the second one may have unpredictable results.
The extra free was added by 5026b47175 (add_reflog_for_walk:
avoid memory leak, 2017-05-04). Though if you look
carefully, you can see that the code was buggy even before
then. If we tried to read the reflogs by time but came up
with no entries, we exited with an error, freeing the string
in that code path. So the bug was harder to trigger, but
still there.
We can fix it by just asking the string list to make a copy
of the string. Technically we could fix the problem by not
calling free() on our string (and just handing over
ownership to the string list), but there are enough
conditionals that it's quite hard to figure out which code
paths need the free and which do not. Simpler is better
here.
The new test reliably shows the problem when run with
--valgrind or ASAN.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
181 lines
4.6 KiB
Bash
Executable file
181 lines
4.6 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='Test reflog display routines'
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'setup' '
|
|
echo content >file &&
|
|
git add file &&
|
|
test_tick &&
|
|
git commit -m one
|
|
'
|
|
|
|
cat >expect <<'EOF'
|
|
Reflog: HEAD@{0} (C O Mitter <committer@example.com>)
|
|
Reflog message: commit (initial): one
|
|
EOF
|
|
test_expect_success 'log -g shows reflog headers' '
|
|
git log -g -1 >tmp &&
|
|
grep ^Reflog <tmp >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
cat >expect <<'EOF'
|
|
e46513e HEAD@{0}: commit (initial): one
|
|
EOF
|
|
test_expect_success 'oneline reflog format' '
|
|
git log -g -1 --oneline >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'reflog default format' '
|
|
git reflog -1 >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
cat >expect <<'EOF'
|
|
commit e46513e
|
|
Reflog: HEAD@{0} (C O Mitter <committer@example.com>)
|
|
Reflog message: commit (initial): one
|
|
Author: A U Thor <author@example.com>
|
|
|
|
one
|
|
EOF
|
|
test_expect_success 'override reflog default format' '
|
|
git reflog --format=short -1 >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
cat >expect <<'EOF'
|
|
Reflog: HEAD@{Thu Apr 7 15:13:13 2005 -0700} (C O Mitter <committer@example.com>)
|
|
Reflog message: commit (initial): one
|
|
EOF
|
|
test_expect_success 'using @{now} syntax shows reflog date (multiline)' '
|
|
git log -g -1 HEAD@{now} >tmp &&
|
|
grep ^Reflog <tmp >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
cat >expect <<'EOF'
|
|
e46513e HEAD@{Thu Apr 7 15:13:13 2005 -0700}: commit (initial): one
|
|
EOF
|
|
test_expect_success 'using @{now} syntax shows reflog date (oneline)' '
|
|
git log -g -1 --oneline HEAD@{now} >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
cat >expect <<'EOF'
|
|
HEAD@{Thu Apr 7 15:13:13 2005 -0700}
|
|
EOF
|
|
test_expect_success 'using @{now} syntax shows reflog date (format=%gd)' '
|
|
git log -g -1 --format=%gd HEAD@{now} >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
cat >expect <<'EOF'
|
|
Reflog: HEAD@{Thu Apr 7 15:13:13 2005 -0700} (C O Mitter <committer@example.com>)
|
|
Reflog message: commit (initial): one
|
|
EOF
|
|
test_expect_success 'using --date= shows reflog date (multiline)' '
|
|
git log -g -1 --date=default >tmp &&
|
|
grep ^Reflog <tmp >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
cat >expect <<'EOF'
|
|
e46513e HEAD@{Thu Apr 7 15:13:13 2005 -0700}: commit (initial): one
|
|
EOF
|
|
test_expect_success 'using --date= shows reflog date (oneline)' '
|
|
git log -g -1 --oneline --date=default >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
cat >expect <<'EOF'
|
|
HEAD@{1112911993 -0700}
|
|
EOF
|
|
test_expect_success 'using --date= shows reflog date (format=%gd)' '
|
|
git log -g -1 --format=%gd --date=raw >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
cat >expect <<'EOF'
|
|
Reflog: HEAD@{0} (C O Mitter <committer@example.com>)
|
|
Reflog message: commit (initial): one
|
|
EOF
|
|
test_expect_success 'log.date does not invoke "--date" magic (multiline)' '
|
|
test_config log.date raw &&
|
|
git log -g -1 >tmp &&
|
|
grep ^Reflog <tmp >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
cat >expect <<'EOF'
|
|
e46513e HEAD@{0}: commit (initial): one
|
|
EOF
|
|
test_expect_success 'log.date does not invoke "--date" magic (oneline)' '
|
|
test_config log.date raw &&
|
|
git log -g -1 --oneline >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
cat >expect <<'EOF'
|
|
HEAD@{0}
|
|
EOF
|
|
test_expect_success 'log.date does not invoke "--date" magic (format=%gd)' '
|
|
test_config log.date raw &&
|
|
git log -g -1 --format=%gd >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
cat >expect <<'EOF'
|
|
HEAD@{0}
|
|
EOF
|
|
test_expect_success '--date magic does not override explicit @{0} syntax' '
|
|
git log -g -1 --format=%gd --date=raw HEAD@{0} >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
: >expect
|
|
test_expect_success 'empty reflog file' '
|
|
git branch empty &&
|
|
git reflog expire --expire=all refs/heads/empty &&
|
|
|
|
git log -g empty >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
# This guards against the alternative of showing the diffs vs. the
|
|
# reflog ancestor. The reflog used is designed to list the commits
|
|
# more than once, so as to exercise the corresponding logic.
|
|
test_expect_success 'git log -g -p shows diffs vs. parents' '
|
|
test_commit two &&
|
|
git branch flipflop &&
|
|
git update-ref refs/heads/flipflop -m flip1 HEAD^ &&
|
|
git update-ref refs/heads/flipflop -m flop1 HEAD &&
|
|
git update-ref refs/heads/flipflop -m flip2 HEAD^ &&
|
|
git log -g -p flipflop >reflog &&
|
|
grep -v ^Reflog reflog >actual &&
|
|
git log -1 -p HEAD^ >log.one &&
|
|
git log -1 -p HEAD >log.two &&
|
|
(
|
|
cat log.one; echo
|
|
cat log.two; echo
|
|
cat log.one; echo
|
|
cat log.two
|
|
) >expect &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'reflog exists works' '
|
|
git reflog exists refs/heads/master &&
|
|
! git reflog exists refs/heads/nonexistent
|
|
'
|
|
|
|
# The behavior with two reflogs is buggy and the output is in flux; for now
|
|
# we're just checking that the program works at all without segfaulting.
|
|
test_expect_success 'showing multiple reflogs works' '
|
|
git log -g HEAD HEAD >actual
|
|
'
|
|
|
|
test_done
|