mirror of
https://github.com/git/git
synced 2024-08-27 11:39:22 +00:00
![Ævar Arnfjörð Bjarmason](/assets/img/avatar_default.png)
When the "ab/various-leak-fixes" topic was merged in [1] only t6021 would fail if the tests were run in the "GIT_TEST_PASSING_SANITIZE_LEAK=check" mode, i.e. to check whether we marked all leak-free tests with "TEST_PASSES_SANITIZE_LEAK=true". Since then we've had various tests starting to pass under SANITIZE=leak. Let's mark those as passing, this is when they started to pass, narrowed down with "git bisect": - t5317-pack-objects-filter-objects.sh: Infaebba436e
(list-objects-filter: plug pattern_list leak, 2022-12-01). - t3210-pack-refs.sh, t5613-info-alternate.sh, t7403-submodule-sync.sh: In189e97bc4b
(diff: remove parseopts member from struct diff_options, 2022-12-01). - t1408-packed-refs.sh: Inab91f6b7c4
(Merge branch 'rs/diff-parseopts', 2022-12-19). - t0023-crlf-am.sh, t4152-am-subjects.sh, t4254-am-corrupt.sh, t4256-am-format-flowed.sh, t4257-am-interactive.sh, t5403-post-checkout-hook.sh: Ina658e881c1
(am: don't pass strvec to apply_parse_options(), 2022-12-13) - t1301-shared-repo.sh, t1302-repo-version.sh: Inb07a819c05
(reflog: clear leftovers in reflog_expiry_cleanup(), 2022-12-13). - t1304-default-acl.sh, t1410-reflog.sh, t5330-no-lazy-fetch-with-commit-graph.sh, t5502-quickfetch.sh, t5604-clone-reference.sh, t6014-rev-list-all.sh, t7701-repack-unpack-unreachable.sh: Inb0c61be320
(Merge branch 'rs/reflog-expiry-cleanup', 2022-12-26) - t3800-mktag.sh, t5302-pack-index.sh, t5306-pack-nobase.sh, t5573-pull-verify-signatures.sh, t7612-merge-verify-signatures.sh: In69bbbe484b
(hash-object: use fsck for object checks, 2023-01-18). - t1451-fsck-buffer.sh: In8e4309038f
(fsck: do not assume NUL-termination of buffers, 2023-01-19). - t6501-freshen-objects.sh: Inabf2bb895b
(Merge branch 'jk/hash-object-fsck', 2023-01-30) 1.9ea1378d04
(Merge branch 'ab/various-leak-fixes', 2022-12-14) Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
49 lines
1.8 KiB
Bash
Executable file
49 lines
1.8 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='test for no lazy fetch with the commit-graph'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'setup: prepare a repository with a commit' '
|
|
git init with-commit &&
|
|
test_commit -C with-commit the-commit &&
|
|
oid=$(git -C with-commit rev-parse HEAD)
|
|
'
|
|
|
|
test_expect_success 'setup: prepare a repository with commit-graph contains the commit' '
|
|
git init with-commit-graph &&
|
|
echo "$(pwd)/with-commit/.git/objects" \
|
|
>with-commit-graph/.git/objects/info/alternates &&
|
|
# create a ref that points to the commit in alternates
|
|
git -C with-commit-graph update-ref refs/ref_to_the_commit "$oid" &&
|
|
# prepare some other objects to commit-graph
|
|
test_commit -C with-commit-graph something &&
|
|
git -c gc.writeCommitGraph=true -C with-commit-graph gc &&
|
|
test_path_is_file with-commit-graph/.git/objects/info/commit-graph
|
|
'
|
|
|
|
test_expect_success 'setup: change the alternates to what without the commit' '
|
|
git init --bare without-commit &&
|
|
git -C with-commit-graph cat-file -e $oid &&
|
|
echo "$(pwd)/without-commit/objects" \
|
|
>with-commit-graph/.git/objects/info/alternates &&
|
|
test_must_fail git -C with-commit-graph cat-file -e $oid
|
|
'
|
|
|
|
test_expect_success 'fetch any commit from promisor with the usage of the commit graph' '
|
|
# setup promisor and prepare any commit to fetch
|
|
git -C with-commit-graph remote add origin "$(pwd)/with-commit" &&
|
|
git -C with-commit-graph config remote.origin.promisor true &&
|
|
git -C with-commit-graph config remote.origin.partialclonefilter blob:none &&
|
|
test_commit -C with-commit any-commit &&
|
|
anycommit=$(git -C with-commit rev-parse HEAD) &&
|
|
GIT_TRACE="$(pwd)/trace.txt" \
|
|
git -C with-commit-graph fetch origin $anycommit 2>err &&
|
|
! grep "fatal: promisor-remote: unable to fork off fetch subprocess" err &&
|
|
grep "git fetch origin" trace.txt >actual &&
|
|
test_line_count = 1 actual
|
|
'
|
|
|
|
test_done
|