mirror of
https://github.com/git/git
synced 2024-10-30 14:03:28 +00:00
9081a421a6
The "checkout" command is one of the main sources of leaks in the test
suite, let's fix the common ones by not leaking from the "struct
branch_info".
Doing this is rather straightforward, albeit verbose, we need to
xstrdup() constant strings going into the struct, and free() the ones
we clobber as we go along.
This also means that we can delete previous partial leak fixes in this
area, i.e. the "path_to_free" accounting added by 96ec7b1e70 (Convert
resolve_ref+xstrdup to new resolve_refdup function, 2011-12-13).
There was some discussion about whether "we should retain the "const
char *" here and cast at free() time, or have it be a "char *". Since
this is not a public API with any sort of API boundary let's use
"char *", as is already being done for the "refname" member of the
same struct.
The tests to mark as passing were found with:
rm .prove; GIT_SKIP_TESTS=t0027 prove -j8 --state=save t[0-9]*.sh :: --immediate
# apply & compile this change
prove -j8 --state=failed :: --immediate
I.e. the ones that were newly passing when the --state=failed command
was run. I left out "t3040-subprojects-basic.sh" and
"t4131-apply-fake-ancestor.sh" to to optimization-level related
differences similar to the ones noted in[1], except that these would
be something the current 'linux-leaks' job would run into.
1. https://lore.kernel.org/git/cover-v3-0.6-00000000000-20211022T175227Z-avarab@gmail.com/
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
61 lines
1.5 KiB
Bash
Executable file
61 lines
1.5 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='checkout handling of ambiguous (branch/tag) refs'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'setup ambiguous refs' '
|
|
test_commit branch file &&
|
|
git branch ambiguity &&
|
|
git branch vagueness &&
|
|
test_commit tag file &&
|
|
git tag ambiguity &&
|
|
git tag vagueness HEAD:file &&
|
|
test_commit other file
|
|
'
|
|
|
|
test_expect_success 'checkout ambiguous ref succeeds' '
|
|
git checkout ambiguity >stdout 2>stderr
|
|
'
|
|
|
|
test_expect_success 'checkout produces ambiguity warning' '
|
|
grep "warning.*ambiguous" stderr
|
|
'
|
|
|
|
test_expect_success 'checkout chooses branch over tag' '
|
|
echo refs/heads/ambiguity >expect &&
|
|
git symbolic-ref HEAD >actual &&
|
|
test_cmp expect actual &&
|
|
echo branch >expect &&
|
|
test_cmp expect file
|
|
'
|
|
|
|
test_expect_success 'checkout reports switch to branch' '
|
|
test_i18ngrep "Switched to branch" stderr &&
|
|
test_i18ngrep ! "^HEAD is now at" stderr
|
|
'
|
|
|
|
test_expect_success 'checkout vague ref succeeds' '
|
|
git checkout vagueness >stdout 2>stderr &&
|
|
test_set_prereq VAGUENESS_SUCCESS
|
|
'
|
|
|
|
test_expect_success VAGUENESS_SUCCESS 'checkout produces ambiguity warning' '
|
|
grep "warning.*ambiguous" stderr
|
|
'
|
|
|
|
test_expect_success VAGUENESS_SUCCESS 'checkout chooses branch over tag' '
|
|
echo refs/heads/vagueness >expect &&
|
|
git symbolic-ref HEAD >actual &&
|
|
test_cmp expect actual &&
|
|
echo branch >expect &&
|
|
test_cmp expect file
|
|
'
|
|
|
|
test_expect_success VAGUENESS_SUCCESS 'checkout reports switch to branch' '
|
|
test_i18ngrep "Switched to branch" stderr &&
|
|
test_i18ngrep ! "^HEAD is now at" stderr
|
|
'
|
|
|
|
test_done
|