mirror of
https://github.com/git/git
synced 2024-10-30 04:01:21 +00:00
533033024a
Travis CI runs the 32 bit Linux build job in a Docker container, where all commands are executed as root by default. Therefore, ever since we added this build job in88dedd5e7(Travis: also test on 32-bit Linux, 2017-03-05), we have a bit of code to create a user in the container matching the ID of the host user and then to run the test suite as this user. Matching the host user ID is important, because otherwise the host user would have no access to any files written by processes running in the container, notably the logs of failed tests couldn't be included in the build job's trace log. Alas, this piece of code never worked, because it sets the variable holding the user name ($CI_USER) in a subshell, meaning it doesn't have any effect by the time we get to the point to actually use the variable to switch users with 'su'. So all this time we were running the test suite as root. Reorganize that piece of code in 'ci/run-linux32-build.sh' a bit to avoid that problematic subshell and to ensure that we switch to the right user. Furthermore, make the script's optional host user ID option mandatory, so running the build accidentally as root will become harder when debugging locally. If someone really wants to run the test suite as root, whatever the reasons might be, it'll still be possible to do so by explicitly passing '0' as host user ID. Finally, one last catch: since commit7e72cfcee(travis-ci: save prove state for the 32 bit Linux build, 2017-12-27) the 'prove' test harness has been writing its state to the Travis CI cache directory from within the Docker container while running as root. After this patch 'prove' will run as a regular user, so in future build jobs it won't be able overwrite a previously written, still root-owned state file, resulting in build job failures. To resolve this we should manually delete caches containing such root-owned files, but that would be a hassle. Instead, work this around by changing the owner of the whole contents of the cache directory to the host user ID. Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
31 lines
802 B
Bash
Executable file
31 lines
802 B
Bash
Executable file
#!/bin/sh
|
|
#
|
|
# Download and run Docker image to build and test 32-bit Git
|
|
#
|
|
|
|
. ${0%/*}/lib-travisci.sh
|
|
|
|
docker pull daald/ubuntu32:xenial
|
|
|
|
# Use the following command to debug the docker build locally:
|
|
# $ docker run -itv "${PWD}:/usr/src/git" --entrypoint /bin/bash daald/ubuntu32:xenial
|
|
# root@container:/# /usr/src/git/ci/run-linux32-build.sh <host-user-id>
|
|
|
|
container_cache_dir=/tmp/travis-cache
|
|
|
|
docker run \
|
|
--interactive \
|
|
--env DEVELOPER \
|
|
--env DEFAULT_TEST_TARGET \
|
|
--env GIT_PROVE_OPTS \
|
|
--env GIT_TEST_OPTS \
|
|
--env GIT_TEST_CLONE_2GB \
|
|
--env cache_dir="$container_cache_dir" \
|
|
--volume "${PWD}:/usr/src/git" \
|
|
--volume "$cache_dir:$container_cache_dir" \
|
|
daald/ubuntu32:xenial \
|
|
/usr/src/git/ci/run-linux32-build.sh $(id -u $USER)
|
|
|
|
check_unignored_build_artifacts
|
|
|
|
save_good_tree
|