mirror of
https://github.com/git/git
synced 2024-08-24 02:11:08 +00:00
![Damien Marié](/assets/img/avatar_default.png)
When an hook is present but the file is not set as executable then git will ignore the hook. For now this is silent which can be confusing. This commit adds this warning to improve the situation: hint: The 'pre-commit' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false` To allow the old use-case of enabling/disabling hooks via the executable flag a new setting is introduced: advice.ignoredHook. Signed-off-by: Damien Marié <damien@dam.io> Signed-off-by: Junio C Hamano <gitster@pobox.com>
42 lines
1.1 KiB
Bash
Executable file
42 lines
1.1 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='ignored hook warning'
|
|
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success setup '
|
|
hookdir="$(git rev-parse --git-dir)/hooks" &&
|
|
hook="$hookdir/pre-commit" &&
|
|
mkdir -p "$hookdir" &&
|
|
write_script "$hook" <<-\EOF
|
|
exit 0
|
|
EOF
|
|
'
|
|
|
|
test_expect_success 'no warning if hook is not ignored' '
|
|
git commit --allow-empty -m "more" 2>message &&
|
|
test_i18ngrep ! -e "hook was ignored" message
|
|
'
|
|
|
|
test_expect_success POSIXPERM 'warning if hook is ignored' '
|
|
chmod -x "$hook" &&
|
|
git commit --allow-empty -m "even more" 2>message &&
|
|
test_i18ngrep -e "hook was ignored" message
|
|
'
|
|
|
|
test_expect_success POSIXPERM 'no warning if advice.ignoredHook set to false' '
|
|
test_config advice.ignoredHook false &&
|
|
chmod -x "$hook" &&
|
|
git commit --allow-empty -m "even more" 2>message &&
|
|
test_i18ngrep ! -e "hook was ignored" message
|
|
'
|
|
|
|
test_expect_success 'no warning if unset advice.ignoredHook and hook removed' '
|
|
rm -f "$hook" &&
|
|
test_unconfig advice.ignoredHook &&
|
|
git commit --allow-empty -m "even more" 2>message &&
|
|
test_i18ngrep ! -e "hook was ignored" message
|
|
'
|
|
|
|
test_done
|