mirror of
https://github.com/git/git
synced 2024-09-13 13:24:41 +00:00
12878c8351
Assigning hashmap_entry.hash manually leaves hashmap_entry.next uninitialized, which can be dangerous once the hashmap_entry is inserted into a hashmap. Detect those assignments and use hashmap_entry_init, instead. Signed-off-by: Eric Wong <e@80x24.org> Reviewed-by: Derrick Stolee <stolee@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
17 lines
280 B
Plaintext
17 lines
280 B
Plaintext
@ hashmap_entry_init_usage @
|
|
expression E;
|
|
struct hashmap_entry HME;
|
|
@@
|
|
- HME.hash = E;
|
|
+ hashmap_entry_init(&HME, E);
|
|
|
|
@@
|
|
identifier f !~ "^hashmap_entry_init$";
|
|
expression E;
|
|
struct hashmap_entry *HMEP;
|
|
@@
|
|
f(...) {<...
|
|
- HMEP->hash = E;
|
|
+ hashmap_entry_init(HMEP, E);
|
|
...>}
|