mirror of
https://github.com/git/git
synced 2024-08-28 12:09:19 +00:00
![Denton Liu](/assets/img/avatar_default.png)
Before, the `git frotz` command would fail but its return code was hidden since it was in the upstream of a pipe. Break the pipeline into two commands so that the return code is no longer lost. Also, mark `git frotz` with test_must_fail since it's supposed to fail. Signed-off-by: Denton Liu <liu.denton@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
48 lines
1.6 KiB
Bash
Executable file
48 lines
1.6 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='git command aliasing'
|
|
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'nested aliases - internal execution' '
|
|
git config alias.nested-internal-1 nested-internal-2 &&
|
|
git config alias.nested-internal-2 status &&
|
|
git nested-internal-1 >output &&
|
|
test_i18ngrep "^On branch " output
|
|
'
|
|
|
|
test_expect_success 'nested aliases - mixed execution' '
|
|
git config alias.nested-external-1 nested-external-2 &&
|
|
git config alias.nested-external-2 "!git nested-external-3" &&
|
|
git config alias.nested-external-3 status &&
|
|
git nested-external-1 >output &&
|
|
test_i18ngrep "^On branch " output
|
|
'
|
|
|
|
test_expect_success 'looping aliases - internal execution' '
|
|
git config alias.loop-internal-1 loop-internal-2 &&
|
|
git config alias.loop-internal-2 loop-internal-3 &&
|
|
git config alias.loop-internal-3 loop-internal-2 &&
|
|
test_must_fail git loop-internal-1 2>output &&
|
|
test_i18ngrep "^fatal: alias loop detected: expansion of" output
|
|
'
|
|
|
|
# This test is disabled until external loops are fixed, because would block
|
|
# the test suite for a full minute.
|
|
#
|
|
#test_expect_failure 'looping aliases - mixed execution' '
|
|
# git config alias.loop-mixed-1 loop-mixed-2 &&
|
|
# git config alias.loop-mixed-2 "!git loop-mixed-1" &&
|
|
# test_must_fail git loop-mixed-1 2>output &&
|
|
# test_i18ngrep "^fatal: alias loop detected: expansion of" output
|
|
#'
|
|
|
|
test_expect_success 'run-command formats empty args properly' '
|
|
test_must_fail env GIT_TRACE=1 git frotz a "" b " " c 2>actual.raw &&
|
|
sed -ne "/run_command:/s/.*trace: run_command: //p" actual.raw >actual &&
|
|
echo "git-frotz a '\'''\'' b '\'' '\'' c" >expect &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_done
|