mirror of
https://github.com/git/git
synced 2024-11-05 18:59:29 +00:00
9081a421a6
The "checkout" command is one of the main sources of leaks in the test
suite, let's fix the common ones by not leaking from the "struct
branch_info".
Doing this is rather straightforward, albeit verbose, we need to
xstrdup() constant strings going into the struct, and free() the ones
we clobber as we go along.
This also means that we can delete previous partial leak fixes in this
area, i.e. the "path_to_free" accounting added by 96ec7b1e70 (Convert
resolve_ref+xstrdup to new resolve_refdup function, 2011-12-13).
There was some discussion about whether "we should retain the "const
char *" here and cast at free() time, or have it be a "char *". Since
this is not a public API with any sort of API boundary let's use
"char *", as is already being done for the "refname" member of the
same struct.
The tests to mark as passing were found with:
rm .prove; GIT_SKIP_TESTS=t0027 prove -j8 --state=save t[0-9]*.sh :: --immediate
# apply & compile this change
prove -j8 --state=failed :: --immediate
I.e. the ones that were newly passing when the --state=failed command
was run. I left out "t3040-subprojects-basic.sh" and
"t4131-apply-fake-ancestor.sh" to to optimization-level related
differences similar to the ones noted in[1], except that these would
be something the current 'linux-leaks' job would run into.
1. https://lore.kernel.org/git/cover-v3-0.6-00000000000-20211022T175227Z-avarab@gmail.com/
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
140 lines
3.2 KiB
Bash
Executable file
140 lines
3.2 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='Test that adding/removing many notes triggers automatic fanout restructuring'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
path_has_fanout() {
|
|
path=$1 &&
|
|
fanout=$2 &&
|
|
after_last_slash=$(($(test_oid hexsz) - $fanout * 2)) &&
|
|
echo $path | grep -q "^\([0-9a-f]\{2\}/\)\{$fanout\}[0-9a-f]\{$after_last_slash\}$"
|
|
}
|
|
|
|
touched_one_note_with_fanout() {
|
|
notes_commit=$1 &&
|
|
modification=$2 && # 'A' for addition, 'D' for deletion
|
|
fanout=$3 &&
|
|
diff=$(git diff-tree --no-commit-id --name-status --root -r $notes_commit) &&
|
|
path=$(echo $diff | sed -e "s/^$modification[\t ]//") &&
|
|
path_has_fanout "$path" $fanout;
|
|
}
|
|
|
|
all_notes_have_fanout() {
|
|
notes_commit=$1 &&
|
|
fanout=$2 &&
|
|
git ls-tree -r --name-only $notes_commit 2>/dev/null |
|
|
while read path
|
|
do
|
|
path_has_fanout $path $fanout || return 1
|
|
done
|
|
}
|
|
|
|
test_expect_success 'tweak test environment' '
|
|
git checkout -b nondeterminism &&
|
|
test_commit A &&
|
|
git checkout --orphan with_notes;
|
|
'
|
|
|
|
test_expect_success 'creating many notes with git-notes' '
|
|
num_notes=300 &&
|
|
i=0 &&
|
|
while test $i -lt $num_notes
|
|
do
|
|
i=$(($i + 1)) &&
|
|
test_tick &&
|
|
echo "file for commit #$i" > file &&
|
|
git add file &&
|
|
git commit -q -m "commit #$i" &&
|
|
git notes add -m "note #$i" || return 1
|
|
done
|
|
'
|
|
|
|
test_expect_success 'many notes created correctly with git-notes' '
|
|
git log | grep "^ " > output &&
|
|
i=$num_notes &&
|
|
while test $i -gt 0
|
|
do
|
|
echo " commit #$i" &&
|
|
echo " note #$i" &&
|
|
i=$(($i - 1));
|
|
done > expect &&
|
|
test_cmp expect output
|
|
'
|
|
|
|
test_expect_success 'stable fanout 0 is followed by stable fanout 1' '
|
|
i=$num_notes &&
|
|
fanout=0 &&
|
|
while test $i -gt 0
|
|
do
|
|
i=$(($i - 1)) &&
|
|
if touched_one_note_with_fanout refs/notes/commits~$i A $fanout
|
|
then
|
|
continue
|
|
elif test $fanout -eq 0
|
|
then
|
|
fanout=1 &&
|
|
if all_notes_have_fanout refs/notes/commits~$i $fanout
|
|
then
|
|
echo "Fanout 0 -> 1 at refs/notes/commits~$i" &&
|
|
continue
|
|
fi
|
|
fi &&
|
|
echo "Failed fanout=$fanout check at refs/notes/commits~$i" &&
|
|
git ls-tree -r --name-only refs/notes/commits~$i &&
|
|
return 1
|
|
done &&
|
|
all_notes_have_fanout refs/notes/commits 1
|
|
'
|
|
|
|
test_expect_success 'deleting most notes with git-notes' '
|
|
remove_notes=285 &&
|
|
i=0 &&
|
|
git rev-list HEAD |
|
|
while test $i -lt $remove_notes && read sha1
|
|
do
|
|
i=$(($i + 1)) &&
|
|
test_tick &&
|
|
git notes remove "$sha1" 2>/dev/null || return 1
|
|
done
|
|
'
|
|
|
|
test_expect_success 'most notes deleted correctly with git-notes' '
|
|
git log HEAD~$remove_notes | grep "^ " > output &&
|
|
i=$(($num_notes - $remove_notes)) &&
|
|
while test $i -gt 0
|
|
do
|
|
echo " commit #$i" &&
|
|
echo " note #$i" &&
|
|
i=$(($i - 1));
|
|
done > expect &&
|
|
test_cmp expect output
|
|
'
|
|
|
|
test_expect_success 'stable fanout 1 is followed by stable fanout 0' '
|
|
i=$remove_notes &&
|
|
fanout=1 &&
|
|
while test $i -gt 0
|
|
do
|
|
i=$(($i - 1)) &&
|
|
if touched_one_note_with_fanout refs/notes/commits~$i D $fanout
|
|
then
|
|
continue
|
|
elif test $fanout -eq 1
|
|
then
|
|
fanout=0 &&
|
|
if all_notes_have_fanout refs/notes/commits~$i $fanout
|
|
then
|
|
echo "Fanout 1 -> 0 at refs/notes/commits~$i" &&
|
|
continue
|
|
fi
|
|
fi &&
|
|
echo "Failed fanout=$fanout check at refs/notes/commits~$i" &&
|
|
git ls-tree -r --name-only refs/notes/commits~$i &&
|
|
return 1
|
|
done &&
|
|
all_notes_have_fanout refs/notes/commits 0
|
|
'
|
|
|
|
test_done
|