mirror of
https://github.com/git/git
synced 2024-10-30 14:03:28 +00:00
716a6b2c3a
We call repo_get_merge_bases(), which allocates a commit_list, but never free the result, causing a leak. The obvious solution is to free it, but we need to look at the contents of the first item to decide whether to leave the loop. One option is to free it in both code paths. But since the commit that the list points to is longer-lived than the list itself, we can just dereference it immediately, free the list, and then continue with the existing logic. This is about the same amount of code, but keeps the list management all in one place. This lets us mark a number of merge-related test scripts as leak-free. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
178 lines
4.9 KiB
Bash
Executable file
178 lines
4.9 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='"git merge" top-level frontend'
|
|
|
|
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
|
|
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
t3033_reset () {
|
|
git checkout -B main two &&
|
|
git branch -f left three &&
|
|
git branch -f right four
|
|
}
|
|
|
|
test_expect_success setup '
|
|
test_commit one &&
|
|
git branch left &&
|
|
git branch right &&
|
|
test_commit two &&
|
|
git checkout left &&
|
|
test_commit three &&
|
|
git checkout right &&
|
|
test_commit four &&
|
|
git checkout --orphan newroot &&
|
|
test_commit five &&
|
|
git checkout main
|
|
'
|
|
|
|
# Local branches
|
|
|
|
test_expect_success 'merge an octopus into void' '
|
|
t3033_reset &&
|
|
git checkout --orphan test &&
|
|
git rm -fr . &&
|
|
test_must_fail git merge left right &&
|
|
test_must_fail git rev-parse --verify HEAD &&
|
|
git diff --quiet &&
|
|
test_must_fail git rev-parse HEAD
|
|
'
|
|
|
|
test_expect_success 'merge an octopus, fast-forward (ff)' '
|
|
t3033_reset &&
|
|
git reset --hard one &&
|
|
git merge left right &&
|
|
# one is ancestor of three (left) and four (right)
|
|
test_must_fail git rev-parse --verify HEAD^3 &&
|
|
git rev-parse HEAD^1 HEAD^2 | sort >actual &&
|
|
git rev-parse three four | sort >expect &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'merge octopus, non-fast-forward (ff)' '
|
|
t3033_reset &&
|
|
git reset --hard one &&
|
|
git merge --no-ff left right &&
|
|
# one is ancestor of three (left) and four (right)
|
|
test_must_fail git rev-parse --verify HEAD^4 &&
|
|
git rev-parse HEAD^1 HEAD^2 HEAD^3 | sort >actual &&
|
|
git rev-parse one three four | sort >expect &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'merge octopus, fast-forward (does not ff)' '
|
|
t3033_reset &&
|
|
git merge left right &&
|
|
# two (main) is not an ancestor of three (left) and four (right)
|
|
test_must_fail git rev-parse --verify HEAD^4 &&
|
|
git rev-parse HEAD^1 HEAD^2 HEAD^3 | sort >actual &&
|
|
git rev-parse two three four | sort >expect &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'merge octopus, non-fast-forward' '
|
|
t3033_reset &&
|
|
git merge --no-ff left right &&
|
|
test_must_fail git rev-parse --verify HEAD^4 &&
|
|
git rev-parse HEAD^1 HEAD^2 HEAD^3 | sort >actual &&
|
|
git rev-parse two three four | sort >expect &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
# The same set with FETCH_HEAD
|
|
|
|
test_expect_success 'merge FETCH_HEAD octopus into void' '
|
|
t3033_reset &&
|
|
git checkout --orphan test &&
|
|
git rm -fr . &&
|
|
git fetch . left right &&
|
|
test_must_fail git merge FETCH_HEAD &&
|
|
test_must_fail git rev-parse --verify HEAD &&
|
|
git diff --quiet &&
|
|
test_must_fail git rev-parse HEAD
|
|
'
|
|
|
|
test_expect_success 'merge FETCH_HEAD octopus fast-forward (ff)' '
|
|
t3033_reset &&
|
|
git reset --hard one &&
|
|
git fetch . left right &&
|
|
git merge FETCH_HEAD &&
|
|
# one is ancestor of three (left) and four (right)
|
|
test_must_fail git rev-parse --verify HEAD^3 &&
|
|
git rev-parse HEAD^1 HEAD^2 | sort >actual &&
|
|
git rev-parse three four | sort >expect &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'merge FETCH_HEAD octopus non-fast-forward (ff)' '
|
|
t3033_reset &&
|
|
git reset --hard one &&
|
|
git fetch . left right &&
|
|
git merge --no-ff FETCH_HEAD &&
|
|
# one is ancestor of three (left) and four (right)
|
|
test_must_fail git rev-parse --verify HEAD^4 &&
|
|
git rev-parse HEAD^1 HEAD^2 HEAD^3 | sort >actual &&
|
|
git rev-parse one three four | sort >expect &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'merge FETCH_HEAD octopus fast-forward (does not ff)' '
|
|
t3033_reset &&
|
|
git fetch . left right &&
|
|
git merge FETCH_HEAD &&
|
|
# two (main) is not an ancestor of three (left) and four (right)
|
|
test_must_fail git rev-parse --verify HEAD^4 &&
|
|
git rev-parse HEAD^1 HEAD^2 HEAD^3 | sort >actual &&
|
|
git rev-parse two three four | sort >expect &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'merge FETCH_HEAD octopus non-fast-forward' '
|
|
t3033_reset &&
|
|
git fetch . left right &&
|
|
git merge --no-ff FETCH_HEAD &&
|
|
test_must_fail git rev-parse --verify HEAD^4 &&
|
|
git rev-parse HEAD^1 HEAD^2 HEAD^3 | sort >actual &&
|
|
git rev-parse two three four | sort >expect &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
# two-project merge
|
|
test_expect_success 'refuse two-project merge by default' '
|
|
t3033_reset &&
|
|
git reset --hard four &&
|
|
test_must_fail git merge five
|
|
'
|
|
|
|
test_expect_success 'refuse two-project merge by default, quit before --autostash happens' '
|
|
t3033_reset &&
|
|
git reset --hard four &&
|
|
echo change >>one.t &&
|
|
git diff >expect &&
|
|
test_must_fail git merge --autostash five 2>err &&
|
|
test_i18ngrep ! "stash" err &&
|
|
git diff >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'two-project merge with --allow-unrelated-histories' '
|
|
t3033_reset &&
|
|
git reset --hard four &&
|
|
git merge --allow-unrelated-histories five &&
|
|
git diff --exit-code five
|
|
'
|
|
|
|
test_expect_success 'two-project merge with --allow-unrelated-histories with --autostash' '
|
|
t3033_reset &&
|
|
git reset --hard four &&
|
|
echo change >>one.t &&
|
|
git diff one.t >expect &&
|
|
git merge --allow-unrelated-histories --autostash five 2>err &&
|
|
test_i18ngrep "Applied autostash." err &&
|
|
git diff one.t >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_done
|