mirror of
https://github.com/git/git
synced 2024-10-31 00:45:12 +00:00
482e1488a9
Witha54e938e5b(strbuf: support long paths w/o read rights in strbuf_getcwd() on FreeBSD, 2017-03-26) we had t0001 break on systems like OpenBSD and AIX whose getcwd(3) has standard (but not like glibc et al) behavior. This was partially fixed inbed67874e2(t0001: skip test with restrictive permissions if getpwd(3) respects them, 2017-08-07). The problem with that fix is that while its analysis of the problem is correct, it doesn't actually call getcwd(3), instead it invokes "pwd -P". There is no guarantee that "pwd -P" is going to call getcwd(3), as opposed to e.g. being a shell built-in. On AIX under both bash and ksh this test breaks because "pwd -P" will happily display the current working directory, but getcwd(3) called by the "git init" we're testing here will fail to get it. I checked whether clobbering the $PWD environment variable would affect it, and it didn't. Presumably these shells keep track of their working directory internally. There's possible follow-up work here in teaching strbuf_getcwd() to get the working directory with whatever method "pwd" uses on these platforms. See [1] for a discussion of that, but let's take the easy way out here and just skip these tests by fixing the GETCWD_IGNORES_PERMS prerequisite to match the limitations of strbuf_getcwd(). 1. https://lore.kernel.org/git/b650bef5-d739-d98d-e9f1-fa292b6ce982@web.de/ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
26 lines
446 B
C
26 lines
446 B
C
#include "test-tool.h"
|
|
#include "git-compat-util.h"
|
|
#include "parse-options.h"
|
|
|
|
static const char *getcwd_usage[] = {
|
|
"test-tool getcwd",
|
|
NULL
|
|
};
|
|
|
|
int cmd__getcwd(int argc, const char **argv)
|
|
{
|
|
struct option options[] = {
|
|
OPT_END()
|
|
};
|
|
char *cwd;
|
|
|
|
argc = parse_options(argc, argv, "test-tools", options, getcwd_usage, 0);
|
|
if (argc > 0)
|
|
usage_with_options(getcwd_usage, options);
|
|
|
|
cwd = xgetcwd();
|
|
puts(cwd);
|
|
free(cwd);
|
|
|
|
return 0;
|
|
}
|