mirror of
https://github.com/git/git
synced 2024-10-28 19:25:47 +00:00
4a9b204920
Christoph Reiter reported on the Git for Windows issue tracker[1], that mingw_strftime() imports strftime() from ucrtbase.dll with the wrong calling convention. It should be __cdecl instead of WINAPI, which we always use in DECLARE_PROC_ADDR(). The MSYS2 project encountered cmake sefaults on x86 Windows caused by the same issue in the cmake source. [2] There are no known git crashes that where caused by this, yet, but we should try to prevent them. We import two other non-WINAPI functions via DECLARE_PROC_ADDR(), too. * NtSetSystemInformation() (NTAPI) * GetUserNameExW() (SEC_ENTRY) NTAPI, SEC_ENTRY and WINAPI are all ususally defined as __stdcall, but there are circumstances where they're defined differently. Teach DECLARE_PROC_ADDR() about calling conventions and be explicit about when we want to use which calling convention. Import winnt.h for the definition of NTAPI and sspi.h for SEC_ENTRY near their respective only users. [1] https://github.com/git-for-windows/git/issues/3560 [2] https://github.com/msys2/MINGW-packages/issues/10152 Reported-By: Christoph Reiter <reiter.christoph@gmail.com> Signed-off-by: Matthias Aßhauer <mha1993@live.de> Signed-off-by: Junio C Hamano <gitster@pobox.com> |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| test-advise.c | ||
| test-bitmap.c | ||
| test-bloom.c | ||
| test-chmtime.c | ||
| test-config.c | ||
| test-crontab.c | ||
| test-ctype.c | ||
| test-date.c | ||
| test-delta.c | ||
| test-dir-iterator.c | ||
| test-drop-caches.c | ||
| test-dump-cache-tree.c | ||
| test-dump-fsmonitor.c | ||
| test-dump-split-index.c | ||
| test-dump-untracked-cache.c | ||
| test-example-decorate.c | ||
| test-fake-ssh.c | ||
| test-fast-rebase.c | ||
| test-genrandom.c | ||
| test-genzeros.c | ||
| test-getcwd.c | ||
| test-hash-speed.c | ||
| test-hash.c | ||
| test-hashmap.c | ||
| test-index-version.c | ||
| test-json-writer.c | ||
| test-lazy-init-name-hash.c | ||
| test-match-trees.c | ||
| test-mergesort.c | ||
| test-mktemp.c | ||
| test-oid-array.c | ||
| test-oidmap.c | ||
| test-oidtree.c | ||
| test-online-cpus.c | ||
| test-parse-options.c | ||
| test-parse-pathspec-file.c | ||
| test-partial-clone.c | ||
| test-path-utils.c | ||
| test-pcre2-config.c | ||
| test-pkt-line.c | ||
| test-prio-queue.c | ||
| test-proc-receive.c | ||
| test-progress.c | ||
| test-reach.c | ||
| test-read-cache.c | ||
| test-read-graph.c | ||
| test-read-midx.c | ||
| test-ref-store.c | ||
| test-regex.c | ||
| test-repository.c | ||
| test-revision-walking.c | ||
| test-run-command.c | ||
| test-scrap-cache-tree.c | ||
| test-serve-v2.c | ||
| test-sha1.c | ||
| test-sha1.sh | ||
| test-sha256.c | ||
| test-sigchain.c | ||
| test-simple-ipc.c | ||
| test-strcmp-offset.c | ||
| test-string-list.c | ||
| test-submodule-config.c | ||
| test-submodule-nested-repo-config.c | ||
| test-subprocess.c | ||
| test-tool.c | ||
| test-tool.h | ||
| test-trace2.c | ||
| test-urlmatch-normalization.c | ||
| test-userdiff.c | ||
| test-wildmatch.c | ||
| test-windows-named-pipe.c | ||
| test-write-cache.c | ||
| test-xml-encode.c | ||