mirror of
https://github.com/git/git
synced 2024-10-30 14:03:28 +00:00
b571fb9800
We did not bother to clean up at all in `git branch` or `git tag`, and
`git for-each-ref` only cleans up a couple of members.
Add and call `ref_filter_clear()` when cleaning up a `struct
ref_filter`. Running this patch (without any test changes) indicates a
couple of now leak-free tests. This was found by running:
$ make SANITIZE=leak
$ make -C t GIT_TEST_PASSING_SANITIZE_LEAK=check GIT_TEST_OPTS=--immediate
(Note that the `reachable_from` and `unreachable_from` lists should be
cleaned as they are used. So this is just covering any case where we
might bail before running the reachability check.)
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
111 lines
3.3 KiB
Bash
Executable file
111 lines
3.3 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='Test commands behavior when given invalid argument value'
|
|
|
|
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
|
|
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'setup ' '
|
|
test_commit "v1.0"
|
|
'
|
|
|
|
test_expect_success 'tag --contains <existent_tag>' '
|
|
git tag --contains "v1.0" >actual 2>actual.err &&
|
|
grep "v1.0" actual &&
|
|
test_line_count = 0 actual.err
|
|
'
|
|
|
|
test_expect_success 'tag --contains <inexistent_tag>' '
|
|
test_must_fail git tag --contains "notag" >actual 2>actual.err &&
|
|
test_line_count = 0 actual &&
|
|
test_i18ngrep "error" actual.err &&
|
|
test_i18ngrep ! "usage" actual.err
|
|
'
|
|
|
|
test_expect_success 'tag --no-contains <existent_tag>' '
|
|
git tag --no-contains "v1.0" >actual 2>actual.err &&
|
|
test_line_count = 0 actual &&
|
|
test_line_count = 0 actual.err
|
|
'
|
|
|
|
test_expect_success 'tag --no-contains <inexistent_tag>' '
|
|
test_must_fail git tag --no-contains "notag" >actual 2>actual.err &&
|
|
test_line_count = 0 actual &&
|
|
test_i18ngrep "error" actual.err &&
|
|
test_i18ngrep ! "usage" actual.err
|
|
'
|
|
|
|
test_expect_success 'tag usage error' '
|
|
test_must_fail git tag --noopt >actual 2>actual.err &&
|
|
test_line_count = 0 actual &&
|
|
test_i18ngrep "usage" actual.err
|
|
'
|
|
|
|
test_expect_success 'branch --contains <existent_commit>' '
|
|
git branch --contains "main" >actual 2>actual.err &&
|
|
test_i18ngrep "main" actual &&
|
|
test_line_count = 0 actual.err
|
|
'
|
|
|
|
test_expect_success 'branch --contains <inexistent_commit>' '
|
|
test_must_fail git branch --no-contains "nocommit" >actual 2>actual.err &&
|
|
test_line_count = 0 actual &&
|
|
test_i18ngrep "error" actual.err &&
|
|
test_i18ngrep ! "usage" actual.err
|
|
'
|
|
|
|
test_expect_success 'branch --no-contains <existent_commit>' '
|
|
git branch --no-contains "main" >actual 2>actual.err &&
|
|
test_line_count = 0 actual &&
|
|
test_line_count = 0 actual.err
|
|
'
|
|
|
|
test_expect_success 'branch --no-contains <inexistent_commit>' '
|
|
test_must_fail git branch --no-contains "nocommit" >actual 2>actual.err &&
|
|
test_line_count = 0 actual &&
|
|
test_i18ngrep "error" actual.err &&
|
|
test_i18ngrep ! "usage" actual.err
|
|
'
|
|
|
|
test_expect_success 'branch usage error' '
|
|
test_must_fail git branch --noopt >actual 2>actual.err &&
|
|
test_line_count = 0 actual &&
|
|
test_i18ngrep "usage" actual.err
|
|
'
|
|
|
|
test_expect_success 'for-each-ref --contains <existent_object>' '
|
|
git for-each-ref --contains "main" >actual 2>actual.err &&
|
|
test_line_count = 2 actual &&
|
|
test_line_count = 0 actual.err
|
|
'
|
|
|
|
test_expect_success 'for-each-ref --contains <inexistent_object>' '
|
|
test_must_fail git for-each-ref --no-contains "noobject" >actual 2>actual.err &&
|
|
test_line_count = 0 actual &&
|
|
test_i18ngrep "error" actual.err &&
|
|
test_i18ngrep ! "usage" actual.err
|
|
'
|
|
|
|
test_expect_success 'for-each-ref --no-contains <existent_object>' '
|
|
git for-each-ref --no-contains "main" >actual 2>actual.err &&
|
|
test_line_count = 0 actual &&
|
|
test_line_count = 0 actual.err
|
|
'
|
|
|
|
test_expect_success 'for-each-ref --no-contains <inexistent_object>' '
|
|
test_must_fail git for-each-ref --no-contains "noobject" >actual 2>actual.err &&
|
|
test_line_count = 0 actual &&
|
|
test_i18ngrep "error" actual.err &&
|
|
test_i18ngrep ! "usage" actual.err
|
|
'
|
|
|
|
test_expect_success 'for-each-ref usage error' '
|
|
test_must_fail git for-each-ref --noopt >actual 2>actual.err &&
|
|
test_line_count = 0 actual &&
|
|
test_i18ngrep "usage" actual.err
|
|
'
|
|
|
|
test_done
|