mirror of
https://github.com/git/git
synced 2024-10-29 17:08:46 +00:00
e75d2f7f73
Extend the the release_revisions() function so that it frees the "filter" in the "struct rev_info". This in combination with a preceding change to free "cmdline" means that we can mark another set of tests as passing under "TEST_PASSES_SANITIZE_LEAK=true". The "filter" member was added recently inffaa137f64(revision: put object filter into struct rev_info, 2022-03-09), and this fixes leaks intruded in the subsequent leak7940941de1(pack-objects: use rev.filter when possible, 2022-03-09) and105c6f14ad(bundle: parse filter capability, 2022-03-09). The "builtin/pack-objects.c" leak in7940941de1was effectively with us already, but the variable was referred to by a "static" file-scoped variable. The "bundle.c " leak in105c6f14adwas newly introduced with the new "filter" feature for bundles. The "t5600-clone-fail-cleanup.sh" change here to add "TEST_PASSES_SANITIZE_LEAK=true" is one of the cases where run-command.c in not carrying the abort() exit code upwards would have had that test passing before, but now it *actually* passes[1]. We should fix the lack of 1=1 mapping of SANITIZE=leak testing to actual leaks some other time, but it's an existing edge case, let's just mark the really-passing test as passing for now. 1. https://lore.kernel.org/git/220303.86fsnz5o9w.gmgdl@evledraar.gmail.com/ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
26 lines
511 B
Bash
Executable file
26 lines
511 B
Bash
Executable file
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2014 Ephrim Khong
|
|
#
|
|
|
|
test_description='repack involving cyclic alternate'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success setup '
|
|
GIT_OBJECT_DIRECTORY=.git//../.git/objects &&
|
|
export GIT_OBJECT_DIRECTORY &&
|
|
touch a &&
|
|
git add a &&
|
|
git commit -m 1 &&
|
|
git repack -adl &&
|
|
echo "$(pwd)"/.git/objects/../objects >.git/objects/info/alternates
|
|
'
|
|
|
|
test_expect_success 're-packing repository with itsself as alternate' '
|
|
git repack -adl &&
|
|
git fsck
|
|
'
|
|
|
|
test_done
|