mirror of
https://github.com/git/git
synced 2024-11-05 18:59:29 +00:00
0f7443bdc7
The comments in create_default_files() talks about reading config from
the config file in the specified `--templates` directory, which leads to
the question of whether core.bare could be set in such a config file and
thus whether the code is doing the right thing. It turns out, that it
doesn't; it unconditionally ignores core.bare in the config file in any
--templates directory. It is not clear to me that fixing it can be done
within this function; it seems to occur too late:
* create_default_files() is called by init_db()
* init_db() is called by both builtin/{clone.c,init-db.c}
* both callers of init_db() call set_git_work_tree() before init_db()
and in order to actual affect whether a repository is bear, we'd need to
somewhere reset these values, not just the is_bare_repository_cfg
setting.
I do not want to open this can of worms at this time; I'm trying to
clean up some headers, for which I need to move some functions, for
which I need to clean up some globals, and that's far enough down the
rabbit hole. So, simply document the issue with a careful TODO comment
and a few testcases.
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
241 lines
5.8 KiB
Bash
Executable file
241 lines
5.8 KiB
Bash
Executable file
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2007 Johannes Schindelin
|
|
#
|
|
|
|
test_description='Test shared repository initialization'
|
|
|
|
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
|
|
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
|
|
|
|
TEST_CREATE_REPO_NO_TEMPLATE=1
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
# Remove a default ACL from the test dir if possible.
|
|
setfacl -k . 2>/dev/null
|
|
|
|
# User must have read permissions to the repo -> failure on --shared=0400
|
|
test_expect_success 'shared = 0400 (faulty permission u-w)' '
|
|
test_when_finished "rm -rf sub" &&
|
|
mkdir sub && (
|
|
cd sub &&
|
|
test_must_fail git init --shared=0400
|
|
)
|
|
'
|
|
|
|
for u in 002 022
|
|
do
|
|
test_expect_success POSIXPERM "shared=1 does not clear bits preset by umask $u" '
|
|
test_when_finished "rm -rf sub" &&
|
|
mkdir sub && (
|
|
cd sub &&
|
|
umask $u &&
|
|
git init --shared=1 &&
|
|
test 1 = "$(git config core.sharedrepository)"
|
|
) &&
|
|
actual=$(ls -l sub/.git/HEAD) &&
|
|
case "$actual" in
|
|
-rw-rw-r--*)
|
|
: happy
|
|
;;
|
|
*)
|
|
echo Oops, .git/HEAD is not 0664 but $actual
|
|
false
|
|
;;
|
|
esac
|
|
'
|
|
done
|
|
|
|
test_expect_success 'shared=all' '
|
|
git init --template= --shared=all &&
|
|
test 2 = $(git config core.sharedrepository)
|
|
'
|
|
|
|
test_expect_failure 'template can set core.bare' '
|
|
test_when_finished "rm -rf subdir" &&
|
|
test_when_finished "rm -rf templates" &&
|
|
test_config core.bare true &&
|
|
umask 0022 &&
|
|
mkdir -p templates/ &&
|
|
cp .git/config templates/config &&
|
|
git init --template=templates subdir &&
|
|
test_path_exists subdir/HEAD
|
|
'
|
|
|
|
test_expect_success 'template can set core.bare but overridden by command line' '
|
|
test_when_finished "rm -rf subdir" &&
|
|
test_when_finished "rm -rf templates" &&
|
|
test_config core.bare true &&
|
|
umask 0022 &&
|
|
mkdir -p templates/ &&
|
|
cp .git/config templates/config &&
|
|
git init --no-bare --template=templates subdir &&
|
|
test_path_exists subdir/.git/HEAD
|
|
'
|
|
|
|
test_expect_success POSIXPERM 'update-server-info honors core.sharedRepository' '
|
|
: > a1 &&
|
|
git add a1 &&
|
|
test_tick &&
|
|
git commit -m a1 &&
|
|
mkdir .git/info &&
|
|
umask 0277 &&
|
|
git update-server-info &&
|
|
actual="$(ls -l .git/info/refs)" &&
|
|
case "$actual" in
|
|
-r--r--r--*)
|
|
: happy
|
|
;;
|
|
*)
|
|
echo Oops, .git/info/refs is not 0444
|
|
false
|
|
;;
|
|
esac
|
|
'
|
|
|
|
for u in 0660:rw-rw---- \
|
|
0640:rw-r----- \
|
|
0600:rw------- \
|
|
0666:rw-rw-rw- \
|
|
0664:rw-rw-r--
|
|
do
|
|
x=$(expr "$u" : ".*:\([rw-]*\)") &&
|
|
y=$(echo "$x" | sed -e "s/w/-/g") &&
|
|
u=$(expr "$u" : "\([0-7]*\)") &&
|
|
git config core.sharedrepository "$u" &&
|
|
umask 0277 &&
|
|
|
|
test_expect_success POSIXPERM "shared = $u ($y) ro" '
|
|
|
|
rm -f .git/info/refs &&
|
|
git update-server-info &&
|
|
actual="$(test_modebits .git/info/refs)" &&
|
|
test "x$actual" = "x-$y"
|
|
|
|
'
|
|
|
|
umask 077 &&
|
|
test_expect_success POSIXPERM "shared = $u ($x) rw" '
|
|
|
|
rm -f .git/info/refs &&
|
|
git update-server-info &&
|
|
actual="$(test_modebits .git/info/refs)" &&
|
|
test "x$actual" = "x-$x"
|
|
|
|
'
|
|
|
|
done
|
|
|
|
test_expect_success POSIXPERM 'info/refs respects umask in unshared repo' '
|
|
rm -f .git/info/refs &&
|
|
test_unconfig core.sharedrepository &&
|
|
umask 002 &&
|
|
git update-server-info &&
|
|
echo "-rw-rw-r--" >expect &&
|
|
test_modebits .git/info/refs >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success POSIXPERM 'git reflog expire honors core.sharedRepository' '
|
|
umask 077 &&
|
|
git config core.sharedRepository group &&
|
|
git reflog expire --all &&
|
|
actual="$(ls -l .git/logs/refs/heads/main)" &&
|
|
case "$actual" in
|
|
-rw-rw-*)
|
|
: happy
|
|
;;
|
|
*)
|
|
echo Ooops, .git/logs/refs/heads/main is not 066x [$actual]
|
|
false
|
|
;;
|
|
esac
|
|
'
|
|
|
|
test_expect_success POSIXPERM 'forced modes' '
|
|
test_when_finished "rm -rf new" &&
|
|
mkdir -p templates/hooks &&
|
|
echo update-server-info >templates/hooks/post-update &&
|
|
chmod +x templates/hooks/post-update &&
|
|
echo : >random-file &&
|
|
mkdir new &&
|
|
(
|
|
cd new &&
|
|
umask 002 &&
|
|
git init --shared=0660 --template=../templates &&
|
|
test_path_is_file .git/hooks/post-update &&
|
|
>frotz &&
|
|
git add frotz &&
|
|
git commit -a -m initial &&
|
|
git repack
|
|
) &&
|
|
# List repository files meant to be protected; note that
|
|
# COMMIT_EDITMSG does not matter---0mode is not about a
|
|
# repository with a work tree.
|
|
find new/.git -type f -name COMMIT_EDITMSG -prune -o -print |
|
|
xargs ls -ld >actual &&
|
|
|
|
# Everything must be unaccessible to others
|
|
test -z "$(sed -e "/^.......---/d" actual)" &&
|
|
|
|
# All directories must have either 2770 or 770
|
|
test -z "$(sed -n -e "/^drwxrw[sx]---/d" -e "/^d/p" actual)" &&
|
|
|
|
# post-update hook must be 0770
|
|
test -z "$(sed -n -e "/post-update/{
|
|
/^-rwxrwx---/d
|
|
p
|
|
}" actual)" &&
|
|
|
|
# All files inside objects must be accessible by us
|
|
test -z "$(sed -n -e "/objects\//{
|
|
/^d/d
|
|
/^-r.-r.----/d
|
|
p
|
|
}" actual)"
|
|
'
|
|
|
|
test_expect_success POSIXPERM 'remote init does not use config from cwd' '
|
|
test_when_finished "rm -rf child.git" &&
|
|
git config core.sharedrepository 0666 &&
|
|
umask 0022 &&
|
|
git init --bare child.git &&
|
|
echo "-rw-r--r--" >expect &&
|
|
test_modebits child.git/config >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success POSIXPERM 're-init respects core.sharedrepository (local)' '
|
|
git config core.sharedrepository 0666 &&
|
|
umask 0022 &&
|
|
echo whatever >templates/foo &&
|
|
git init --template=templates &&
|
|
echo "-rw-rw-rw-" >expect &&
|
|
test_modebits .git/foo >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success POSIXPERM 're-init respects core.sharedrepository (remote)' '
|
|
test_when_finished "rm -rf child.git" &&
|
|
umask 0022 &&
|
|
git init --bare --shared=0666 child.git &&
|
|
test_path_is_missing child.git/foo &&
|
|
git init --bare --template=templates child.git &&
|
|
echo "-rw-rw-rw-" >expect &&
|
|
test_modebits child.git/foo >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success POSIXPERM 'template can set core.sharedrepository' '
|
|
test_when_finished "rm -rf child.git" &&
|
|
umask 0022 &&
|
|
git config core.sharedrepository 0666 &&
|
|
cp .git/config templates/config &&
|
|
git init --bare --template=templates child.git &&
|
|
echo "-rw-rw-rw-" >expect &&
|
|
test_modebits child.git/HEAD >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_done
|