mirror of
https://github.com/git/git
synced 2024-10-30 14:03:28 +00:00
7fb8e163bd
Test "pushing to local repo" in t5800-remote-helpers can hang due to a race condition in git-remote-testgit. Fix it by setting stdin to unbuffered. On the writer side, "git push" invokes push_refs_with_export(), which sends to stdout the command "export\n" and immediately starts up "git fast-export". The latter writes its output stream to the same stdout. On the reader side, remote helper "git-remote-testgit" reads from stdin to get its next command. It uses getc() to read characters from libc up until \n. Libc has buffered a potentially much larger chunk of stdin. When it sees the "export\n" command, it forks "git fast-import" to read the stream. If fast-export finishes before git fast-import starts, the fast-export output can end up in libc's buffer in git-remote-testgit, rather than in git fast-import. The latter hangs indefinitely on a now-empty stdin. Signed-off-by: Pete Wyckoff <pw@padd.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
148 lines
3.3 KiB
Bash
Executable file
148 lines
3.3 KiB
Bash
Executable file
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2010 Sverre Rabbelier
|
|
#
|
|
|
|
test_description='Test remote-helper import and export commands'
|
|
|
|
. ./test-lib.sh
|
|
|
|
if ! test_have_prereq PYTHON ; then
|
|
skip_all='skipping git-remote-hg tests, python not available'
|
|
test_done
|
|
fi
|
|
|
|
"$PYTHON_PATH" -c '
|
|
import sys
|
|
if sys.hexversion < 0x02040000:
|
|
sys.exit(1)
|
|
' || {
|
|
skip_all='skipping git-remote-hg tests, python version < 2.4'
|
|
test_done
|
|
}
|
|
|
|
compare_refs() {
|
|
git --git-dir="$1/.git" rev-parse --verify $2 >expect &&
|
|
git --git-dir="$3/.git" rev-parse --verify $4 >actual &&
|
|
test_cmp expect actual
|
|
}
|
|
|
|
test_expect_success 'setup repository' '
|
|
git init --bare server/.git &&
|
|
git clone server public &&
|
|
(cd public &&
|
|
echo content >file &&
|
|
git add file &&
|
|
git commit -m one &&
|
|
git push origin master)
|
|
'
|
|
|
|
test_expect_success 'cloning from local repo' '
|
|
git clone "testgit::${PWD}/server" localclone &&
|
|
test_cmp public/file localclone/file
|
|
'
|
|
|
|
test_expect_success 'cloning from remote repo' '
|
|
git clone "testgit::file://${PWD}/server" clone &&
|
|
test_cmp public/file clone/file
|
|
'
|
|
|
|
test_expect_success 'create new commit on remote' '
|
|
(cd public &&
|
|
echo content >>file &&
|
|
git commit -a -m two &&
|
|
git push)
|
|
'
|
|
|
|
test_expect_success 'pulling from local repo' '
|
|
(cd localclone && git pull) &&
|
|
test_cmp public/file localclone/file
|
|
'
|
|
|
|
test_expect_success 'pulling from remote remote' '
|
|
(cd clone && git pull) &&
|
|
test_cmp public/file clone/file
|
|
'
|
|
|
|
test_expect_success 'pushing to local repo' '
|
|
(cd localclone &&
|
|
echo content >>file &&
|
|
git commit -a -m three &&
|
|
git push) &&
|
|
compare_refs localclone HEAD server HEAD
|
|
'
|
|
|
|
# Generally, skip this test. It demonstrates a now-fixed race in
|
|
# git-remote-testgit, but is too slow to leave in for general use.
|
|
: test_expect_success 'racily pushing to local repo' '
|
|
test_when_finished "rm -rf server2 localclone2" &&
|
|
cp -a server server2 &&
|
|
git clone "testgit::${PWD}/server2" localclone2 &&
|
|
(cd localclone2 &&
|
|
echo content >>file &&
|
|
git commit -a -m three &&
|
|
GIT_REMOTE_TESTGIT_SLEEPY=2 git push) &&
|
|
compare_refs localclone2 HEAD server2 HEAD
|
|
'
|
|
|
|
test_expect_success 'synch with changes from localclone' '
|
|
(cd clone &&
|
|
git pull)
|
|
'
|
|
|
|
test_expect_success 'pushing remote local repo' '
|
|
(cd clone &&
|
|
echo content >>file &&
|
|
git commit -a -m four &&
|
|
git push) &&
|
|
compare_refs clone HEAD server HEAD
|
|
'
|
|
|
|
test_expect_success 'fetch new branch' '
|
|
(cd public &&
|
|
git checkout -b new &&
|
|
echo content >>file &&
|
|
git commit -a -m five &&
|
|
git push origin new
|
|
) &&
|
|
(cd localclone &&
|
|
git fetch origin new
|
|
) &&
|
|
compare_refs public HEAD localclone FETCH_HEAD
|
|
'
|
|
|
|
test_expect_success 'fetch multiple branches' '
|
|
(cd localclone &&
|
|
git fetch
|
|
) &&
|
|
compare_refs server master localclone refs/remotes/origin/master &&
|
|
compare_refs server new localclone refs/remotes/origin/new
|
|
'
|
|
|
|
test_expect_success 'push when remote has extra refs' '
|
|
(cd clone &&
|
|
echo content >>file &&
|
|
git commit -a -m six &&
|
|
git push
|
|
) &&
|
|
compare_refs clone master server master
|
|
'
|
|
|
|
test_expect_success 'push new branch by name' '
|
|
(cd clone &&
|
|
git checkout -b new-name &&
|
|
echo content >>file &&
|
|
git commit -a -m seven &&
|
|
git push origin new-name
|
|
) &&
|
|
compare_refs clone HEAD server refs/heads/new-name
|
|
'
|
|
|
|
test_expect_failure 'push new branch with old:new refspec' '
|
|
(cd clone &&
|
|
git push origin new-name:new-refspec
|
|
) &&
|
|
compare_refs clone HEAD server refs/heads/new-refspec
|
|
'
|
|
|
|
test_done
|