mirror of
https://github.com/git/git
synced 2024-10-28 19:25:47 +00:00
3e4068ed90
If create_symref() fails, git-symbolic-ref will still exit with code 0, and our caller has no idea that the command did nothing. This appears to have been broken since the beginning of time (e.g., it is not a regression where create_symref() stopped calling die() or something similar). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
72 lines
2 KiB
Bash
Executable file
72 lines
2 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='basic symbolic-ref tests'
|
|
. ./test-lib.sh
|
|
|
|
# If the tests munging HEAD fail, they can break detection of
|
|
# the git repo, meaning that further tests will operate on
|
|
# the surrounding git repo instead of the trash directory.
|
|
reset_to_sane() {
|
|
echo ref: refs/heads/foo >.git/HEAD
|
|
}
|
|
|
|
test_expect_success 'symbolic-ref writes HEAD' '
|
|
git symbolic-ref HEAD refs/heads/foo &&
|
|
echo ref: refs/heads/foo >expect &&
|
|
test_cmp expect .git/HEAD
|
|
'
|
|
|
|
test_expect_success 'symbolic-ref reads HEAD' '
|
|
echo refs/heads/foo >expect &&
|
|
git symbolic-ref HEAD >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'symbolic-ref refuses non-ref for HEAD' '
|
|
test_must_fail git symbolic-ref HEAD foo
|
|
'
|
|
reset_to_sane
|
|
|
|
test_expect_success 'symbolic-ref refuses bare sha1' '
|
|
echo content >file && git add file && git commit -m one &&
|
|
test_must_fail git symbolic-ref HEAD `git rev-parse HEAD`
|
|
'
|
|
reset_to_sane
|
|
|
|
test_expect_success 'symbolic-ref deletes HEAD' '
|
|
git symbolic-ref -d HEAD &&
|
|
test_path_is_file .git/refs/heads/foo &&
|
|
test_path_is_missing .git/HEAD
|
|
'
|
|
reset_to_sane
|
|
|
|
test_expect_success 'symbolic-ref deletes dangling HEAD' '
|
|
git symbolic-ref HEAD refs/heads/missing &&
|
|
git symbolic-ref -d HEAD &&
|
|
test_path_is_missing .git/refs/heads/missing &&
|
|
test_path_is_missing .git/HEAD
|
|
'
|
|
reset_to_sane
|
|
|
|
test_expect_success 'symbolic-ref fails to delete missing FOO' '
|
|
echo "fatal: Cannot delete FOO, not a symbolic ref" >expect &&
|
|
test_must_fail git symbolic-ref -d FOO >actual 2>&1 &&
|
|
test_cmp expect actual
|
|
'
|
|
reset_to_sane
|
|
|
|
test_expect_success 'symbolic-ref fails to delete real ref' '
|
|
echo "fatal: Cannot delete refs/heads/foo, not a symbolic ref" >expect &&
|
|
test_must_fail git symbolic-ref -d refs/heads/foo >actual 2>&1 &&
|
|
test_path_is_file .git/refs/heads/foo &&
|
|
test_cmp expect actual
|
|
'
|
|
reset_to_sane
|
|
|
|
test_expect_success 'symbolic-ref reports failure in exit code' '
|
|
test_when_finished "rm -f .git/HEAD.lock" &&
|
|
>.git/HEAD.lock &&
|
|
test_must_fail git symbolic-ref HEAD refs/heads/whatever
|
|
'
|
|
|
|
test_done
|