Taylor Blau 64f1e658e9 contrib/credential: avoid fixed-size buffer in libsecret ... The libsecret credential helper reads the newline-delimited protocol stream one line at a time by repeatedly calling fgets() into a fixed-size buffer, and is thus affected by the vulnerability described in the previous commit. To mitigate this attack, avoid using a fixed-size buffer, and instead rely on getline() to allocate a buffer as large as necessary to fit the entire content of the line, preventing any protocol injection. In most parts of Git we don't assume that every platform has getline(). But libsecret is primarily used on Linux, where we do already assume it (using a knob in config.mak.uname). POSIX also added getline() in 2008, so we'd expect other recent Unix-like operating systems to have it (e.g., FreeBSD also does). Note that the buffer was already allocated on the heap in this case, but we'll swap `g_free()` for `free()`, since it will now be allocated by the system `getline()`, rather than glib's `g_malloc()`. Tested-by: Jeff King <peff@peff.net> Co-authored-by: Jeff King <peff@peff.net> Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Taylor Blau <me@ttaylorr.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>		2023-05-01 09:27:02 -07:00
..
.gitignore	contrib/credential: .gitignore libsecret build artifacts	2023-05-01 09:27:02 -07:00
git-credential-libsecret.c	contrib/credential: avoid fixed-size buffer in libsecret	2023-05-01 09:27:02 -07:00
Makefile	contrib: add credential helper for libsecret	2016-10-11 13:14:51 -07:00