mirror of
https://github.com/git/git
synced 2024-09-12 21:04:12 +00:00
334afbc76f
In addition to the manual adjustment to let the `linux-gcc` CI job run the test suite with `master` and then with `main`, this patch makes sure that GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME is set in all test scripts that currently rely on the initial branch name being `master by default. To determine which test scripts to mark up, the first step was to force-set the default branch name to `master` in - all test scripts that contain the keyword `master`, - t4211, which expects `t/t4211/history.export` with a hard-coded ref to initialize the default branch, - t5560 because it sources `t/t556x_common` which uses `master`, - t8002 and t8012 because both source `t/annotate-tests.sh` which also uses `master`) This trick was performed by this command: $ sed -i '/^ *\. \.\/\(test-lib\|lib-\(bash\|cvs\|git-svn\)\|gitweb-lib\)\.sh$/i\ GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master\ export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\ ' $(git grep -l master t/t[0-9]*.sh) \ t/t4211*.sh t/t5560*.sh t/t8002*.sh t/t8012*.sh After that, careful, manual inspection revealed that some of the test scripts containing the needle `master` do not actually rely on a specific default branch name: either they mention `master` only in a comment, or they initialize that branch specificially, or they do not actually refer to the current default branch. Therefore, the aforementioned modification was undone in those test scripts thusly: $ git checkout HEAD -- \ t/t0027-auto-crlf.sh t/t0060-path-utils.sh \ t/t1011-read-tree-sparse-checkout.sh \ t/t1305-config-include.sh t/t1309-early-config.sh \ t/t1402-check-ref-format.sh t/t1450-fsck.sh \ t/t2024-checkout-dwim.sh \ t/t2106-update-index-assume-unchanged.sh \ t/t3040-subprojects-basic.sh t/t3301-notes.sh \ t/t3308-notes-merge.sh t/t3423-rebase-reword.sh \ t/t3436-rebase-more-options.sh \ t/t4015-diff-whitespace.sh t/t4257-am-interactive.sh \ t/t5323-pack-redundant.sh t/t5401-update-hooks.sh \ t/t5511-refspec.sh t/t5526-fetch-submodules.sh \ t/t5529-push-errors.sh t/t5530-upload-pack-error.sh \ t/t5548-push-porcelain.sh \ t/t5552-skipping-fetch-negotiator.sh \ t/t5572-pull-submodule.sh t/t5608-clone-2gb.sh \ t/t5614-clone-submodules-shallow.sh \ t/t7508-status.sh t/t7606-merge-custom.sh \ t/t9302-fast-import-unpack-limit.sh We excluded one set of test scripts in these commands, though: the range of `git p4` tests. The reason? `git p4` stores the (foreign) remote branch in the branch called `p4/master`, which is obviously not the default branch. Manual analysis revealed that only five of these tests actually require a specific default branch name to pass; They were modified thusly: $ sed -i '/^ *\. \.\/lib-git-p4\.sh$/i\ GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master\ export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\ ' t/t980[0167]*.sh t/t9811*.sh Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
285 lines
8.3 KiB
Bash
Executable file
285 lines
8.3 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
test_description='pre-commit and pre-merge-commit hooks'
|
|
|
|
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master
|
|
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
|
|
|
|
. ./test-lib.sh
|
|
|
|
HOOKDIR="$(git rev-parse --git-dir)/hooks"
|
|
PRECOMMIT="$HOOKDIR/pre-commit"
|
|
PREMERGE="$HOOKDIR/pre-merge-commit"
|
|
|
|
# Prepare sample scripts that write their $0 to actual_hooks
|
|
test_expect_success 'sample script setup' '
|
|
mkdir -p "$HOOKDIR" &&
|
|
write_script "$HOOKDIR/success.sample" <<-\EOF &&
|
|
echo $0 >>actual_hooks
|
|
exit 0
|
|
EOF
|
|
write_script "$HOOKDIR/fail.sample" <<-\EOF &&
|
|
echo $0 >>actual_hooks
|
|
exit 1
|
|
EOF
|
|
write_script "$HOOKDIR/non-exec.sample" <<-\EOF &&
|
|
echo $0 >>actual_hooks
|
|
exit 1
|
|
EOF
|
|
chmod -x "$HOOKDIR/non-exec.sample" &&
|
|
write_script "$HOOKDIR/require-prefix.sample" <<-\EOF &&
|
|
echo $0 >>actual_hooks
|
|
test $GIT_PREFIX = "success/"
|
|
EOF
|
|
write_script "$HOOKDIR/check-author.sample" <<-\EOF
|
|
echo $0 >>actual_hooks
|
|
test "$GIT_AUTHOR_NAME" = "New Author" &&
|
|
test "$GIT_AUTHOR_EMAIL" = "newauthor@example.com"
|
|
EOF
|
|
'
|
|
|
|
test_expect_success 'root commit' '
|
|
echo "root" >file &&
|
|
git add file &&
|
|
git commit -m "zeroth" &&
|
|
git checkout -b side &&
|
|
echo "foo" >foo &&
|
|
git add foo &&
|
|
git commit -m "make it non-ff" &&
|
|
git branch side-orig side &&
|
|
git checkout master
|
|
'
|
|
|
|
test_expect_success 'setup conflicting branches' '
|
|
test_when_finished "git checkout master" &&
|
|
git checkout -b conflicting-a master &&
|
|
echo a >conflicting &&
|
|
git add conflicting &&
|
|
git commit -m conflicting-a &&
|
|
git checkout -b conflicting-b master &&
|
|
echo b >conflicting &&
|
|
git add conflicting &&
|
|
git commit -m conflicting-b
|
|
'
|
|
|
|
test_expect_success 'with no hook' '
|
|
test_when_finished "rm -f actual_hooks" &&
|
|
echo "foo" >file &&
|
|
git add file &&
|
|
git commit -m "first" &&
|
|
test_path_is_missing actual_hooks
|
|
'
|
|
|
|
test_expect_success 'with no hook (merge)' '
|
|
test_when_finished "rm -f actual_hooks" &&
|
|
git branch -f side side-orig &&
|
|
git checkout side &&
|
|
git merge -m "merge master" master &&
|
|
git checkout master &&
|
|
test_path_is_missing actual_hooks
|
|
'
|
|
|
|
test_expect_success '--no-verify with no hook' '
|
|
test_when_finished "rm -f actual_hooks" &&
|
|
echo "bar" >file &&
|
|
git add file &&
|
|
git commit --no-verify -m "bar" &&
|
|
test_path_is_missing actual_hooks
|
|
'
|
|
|
|
test_expect_success '--no-verify with no hook (merge)' '
|
|
test_when_finished "rm -f actual_hooks" &&
|
|
git branch -f side side-orig &&
|
|
git checkout side &&
|
|
git merge --no-verify -m "merge master" master &&
|
|
git checkout master &&
|
|
test_path_is_missing actual_hooks
|
|
'
|
|
|
|
test_expect_success 'with succeeding hook' '
|
|
test_when_finished "rm -f \"$PRECOMMIT\" expected_hooks actual_hooks" &&
|
|
cp "$HOOKDIR/success.sample" "$PRECOMMIT" &&
|
|
echo "$PRECOMMIT" >expected_hooks &&
|
|
echo "more" >>file &&
|
|
git add file &&
|
|
git commit -m "more" &&
|
|
test_cmp expected_hooks actual_hooks
|
|
'
|
|
|
|
test_expect_success 'with succeeding hook (merge)' '
|
|
test_when_finished "rm -f \"$PREMERGE\" expected_hooks actual_hooks" &&
|
|
cp "$HOOKDIR/success.sample" "$PREMERGE" &&
|
|
echo "$PREMERGE" >expected_hooks &&
|
|
git checkout side &&
|
|
git merge -m "merge master" master &&
|
|
git checkout master &&
|
|
test_cmp expected_hooks actual_hooks
|
|
'
|
|
|
|
test_expect_success 'automatic merge fails; both hooks are available' '
|
|
test_when_finished "rm -f \"$PREMERGE\" \"$PRECOMMIT\"" &&
|
|
test_when_finished "rm -f expected_hooks actual_hooks" &&
|
|
test_when_finished "git checkout master" &&
|
|
cp "$HOOKDIR/success.sample" "$PREMERGE" &&
|
|
cp "$HOOKDIR/success.sample" "$PRECOMMIT" &&
|
|
|
|
git checkout conflicting-a &&
|
|
test_must_fail git merge -m "merge conflicting-b" conflicting-b &&
|
|
test_path_is_missing actual_hooks &&
|
|
|
|
echo "$PRECOMMIT" >expected_hooks &&
|
|
echo a+b >conflicting &&
|
|
git add conflicting &&
|
|
git commit -m "resolve conflict" &&
|
|
test_cmp expected_hooks actual_hooks
|
|
'
|
|
|
|
test_expect_success '--no-verify with succeeding hook' '
|
|
test_when_finished "rm -f \"$PRECOMMIT\" actual_hooks" &&
|
|
cp "$HOOKDIR/success.sample" "$PRECOMMIT" &&
|
|
echo "even more" >>file &&
|
|
git add file &&
|
|
git commit --no-verify -m "even more" &&
|
|
test_path_is_missing actual_hooks
|
|
'
|
|
|
|
test_expect_success '--no-verify with succeeding hook (merge)' '
|
|
test_when_finished "rm -f \"$PREMERGE\" actual_hooks" &&
|
|
cp "$HOOKDIR/success.sample" "$PREMERGE" &&
|
|
git branch -f side side-orig &&
|
|
git checkout side &&
|
|
git merge --no-verify -m "merge master" master &&
|
|
git checkout master &&
|
|
test_path_is_missing actual_hooks
|
|
'
|
|
|
|
test_expect_success 'with failing hook' '
|
|
test_when_finished "rm -f \"$PRECOMMIT\" expected_hooks actual_hooks" &&
|
|
cp "$HOOKDIR/fail.sample" "$PRECOMMIT" &&
|
|
echo "$PRECOMMIT" >expected_hooks &&
|
|
echo "another" >>file &&
|
|
git add file &&
|
|
test_must_fail git commit -m "another" &&
|
|
test_cmp expected_hooks actual_hooks
|
|
'
|
|
|
|
test_expect_success '--no-verify with failing hook' '
|
|
test_when_finished "rm -f \"$PRECOMMIT\" actual_hooks" &&
|
|
cp "$HOOKDIR/fail.sample" "$PRECOMMIT" &&
|
|
echo "stuff" >>file &&
|
|
git add file &&
|
|
git commit --no-verify -m "stuff" &&
|
|
test_path_is_missing actual_hooks
|
|
'
|
|
|
|
test_expect_success 'with failing hook (merge)' '
|
|
test_when_finished "rm -f \"$PREMERGE\" expected_hooks actual_hooks" &&
|
|
cp "$HOOKDIR/fail.sample" "$PREMERGE" &&
|
|
echo "$PREMERGE" >expected_hooks &&
|
|
git checkout side &&
|
|
test_must_fail git merge -m "merge master" master &&
|
|
git checkout master &&
|
|
test_cmp expected_hooks actual_hooks
|
|
'
|
|
|
|
test_expect_success '--no-verify with failing hook (merge)' '
|
|
test_when_finished "rm -f \"$PREMERGE\" actual_hooks" &&
|
|
cp "$HOOKDIR/fail.sample" "$PREMERGE" &&
|
|
git branch -f side side-orig &&
|
|
git checkout side &&
|
|
git merge --no-verify -m "merge master" master &&
|
|
git checkout master &&
|
|
test_path_is_missing actual_hooks
|
|
'
|
|
|
|
test_expect_success POSIXPERM 'with non-executable hook' '
|
|
test_when_finished "rm -f \"$PRECOMMIT\" actual_hooks" &&
|
|
cp "$HOOKDIR/non-exec.sample" "$PRECOMMIT" &&
|
|
echo "content" >>file &&
|
|
git add file &&
|
|
git commit -m "content" &&
|
|
test_path_is_missing actual_hooks
|
|
'
|
|
|
|
test_expect_success POSIXPERM '--no-verify with non-executable hook' '
|
|
test_when_finished "rm -f \"$PRECOMMIT\" actual_hooks" &&
|
|
cp "$HOOKDIR/non-exec.sample" "$PRECOMMIT" &&
|
|
echo "more content" >>file &&
|
|
git add file &&
|
|
git commit --no-verify -m "more content" &&
|
|
test_path_is_missing actual_hooks
|
|
'
|
|
|
|
test_expect_success POSIXPERM 'with non-executable hook (merge)' '
|
|
test_when_finished "rm -f \"$PREMERGE\" actual_hooks" &&
|
|
cp "$HOOKDIR/non-exec.sample" "$PREMERGE" &&
|
|
git branch -f side side-orig &&
|
|
git checkout side &&
|
|
git merge -m "merge master" master &&
|
|
git checkout master &&
|
|
test_path_is_missing actual_hooks
|
|
'
|
|
|
|
test_expect_success POSIXPERM '--no-verify with non-executable hook (merge)' '
|
|
test_when_finished "rm -f \"$PREMERGE\" actual_hooks" &&
|
|
cp "$HOOKDIR/non-exec.sample" "$PREMERGE" &&
|
|
git branch -f side side-orig &&
|
|
git checkout side &&
|
|
git merge --no-verify -m "merge master" master &&
|
|
git checkout master &&
|
|
test_path_is_missing actual_hooks
|
|
'
|
|
|
|
test_expect_success 'with hook requiring GIT_PREFIX' '
|
|
test_when_finished "rm -rf \"$PRECOMMIT\" expected_hooks actual_hooks success" &&
|
|
cp "$HOOKDIR/require-prefix.sample" "$PRECOMMIT" &&
|
|
echo "$PRECOMMIT" >expected_hooks &&
|
|
echo "more content" >>file &&
|
|
git add file &&
|
|
mkdir success &&
|
|
(
|
|
cd success &&
|
|
git commit -m "hook requires GIT_PREFIX = success/"
|
|
) &&
|
|
test_cmp expected_hooks actual_hooks
|
|
'
|
|
|
|
test_expect_success 'with failing hook requiring GIT_PREFIX' '
|
|
test_when_finished "rm -rf \"$PRECOMMIT\" expected_hooks actual_hooks fail" &&
|
|
cp "$HOOKDIR/require-prefix.sample" "$PRECOMMIT" &&
|
|
echo "$PRECOMMIT" >expected_hooks &&
|
|
echo "more content" >>file &&
|
|
git add file &&
|
|
mkdir fail &&
|
|
(
|
|
cd fail &&
|
|
test_must_fail git commit -m "hook must fail"
|
|
) &&
|
|
git checkout -- file &&
|
|
test_cmp expected_hooks actual_hooks
|
|
'
|
|
|
|
test_expect_success 'check the author in hook' '
|
|
test_when_finished "rm -f \"$PRECOMMIT\" expected_hooks actual_hooks" &&
|
|
cp "$HOOKDIR/check-author.sample" "$PRECOMMIT" &&
|
|
cat >expected_hooks <<-EOF &&
|
|
$PRECOMMIT
|
|
$PRECOMMIT
|
|
$PRECOMMIT
|
|
EOF
|
|
test_must_fail git commit --allow-empty -m "by a.u.thor" &&
|
|
(
|
|
GIT_AUTHOR_NAME="New Author" &&
|
|
GIT_AUTHOR_EMAIL="newauthor@example.com" &&
|
|
export GIT_AUTHOR_NAME GIT_AUTHOR_EMAIL &&
|
|
git commit --allow-empty -m "by new.author via env" &&
|
|
git show -s
|
|
) &&
|
|
git commit --author="New Author <newauthor@example.com>" \
|
|
--allow-empty -m "by new.author via command line" &&
|
|
git show -s &&
|
|
test_cmp expected_hooks actual_hooks
|
|
'
|
|
|
|
test_done
|